Skip to content

Add check for deleted rows in resultsets for scrollable & updatable resultsets#552

Merged
peterbae merged 2 commits intomicrosoft:devfrom
peterbae:github-477
Dec 5, 2017
Merged

Add check for deleted rows in resultsets for scrollable & updatable resultsets#552
peterbae merged 2 commits intomicrosoft:devfrom
peterbae:github-477

Conversation

@peterbae
Copy link
Copy Markdown
Contributor

@peterbae peterbae commented Nov 16, 2017

fixes issue #477

@peterbae peterbae changed the title GitHub 477 Add check for deleted rows in resultsets Nov 16, 2017
@peterbae peterbae changed the title Add check for deleted rows in resultsets Add check for deleted rows in resultsets for scrollable & updatable resultsets Nov 16, 2017
@codecov-io
Copy link
Copy Markdown

codecov-io commented Nov 16, 2017

Codecov Report

Merging #552 into dev will increase coverage by 0.01%.
The diff coverage is 87.5%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #552      +/-   ##
============================================
+ Coverage     46.66%   46.68%   +0.01%     
  Complexity     2223     2223              
============================================
  Files           108      108              
  Lines         25307    25312       +5     
  Branches       4176     4177       +1     
============================================
+ Hits          11810    11817       +7     
+ Misses        11465    11462       -3     
- Partials       2032     2033       +1
Flag Coverage Δ Complexity Δ
#JDBC41 46.46% <87.5%> (ø) 2212 <0> (+2) ⬆️
#JDBC42 46.44% <87.5%> (-0.11%) 2215 <0> (-2)
Impacted Files Coverage Δ Complexity Δ
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 33.23% <87.5%> (+0.17%) 244 <0> (+1) ⬆️
...c/main/java/com/microsoft/sqlserver/jdbc/Util.java 60.75% <0%> (-0.45%) 87% <0%> (-1%)
...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java 62.93% <0%> (-0.31%) 0% <0%> (ø)
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java 52.64% <0%> (-0.13%) 239% <0%> (-1%)
...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java 44.92% <0%> (ø) 104% <0%> (-1%) ⬇️
...m/microsoft/sqlserver/jdbc/SQLServerStatement.java 59.47% <0%> (+0.1%) 131% <0%> (+1%) ⬆️
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 53.93% <0%> (+0.19%) 0% <0%> (ø) ⬇️
...ncurrentlinkedhashmap/ConcurrentLinkedHashMap.java 42.42% <0%> (+0.21%) 46% <0%> (ø) ⬇️
...om/microsoft/sqlserver/jdbc/SimpleInputStream.java 52.59% <0%> (+1.48%) 12% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be14e88...c006af2. Read the comment docs.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Nov 16, 2017 •
edited
Loading

Codecov Report

Merging #552 into dev will increase coverage by 0.01%.
The diff coverage is 87.5%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #552      +/-   ##
============================================
+ Coverage     46.66%   46.68%   +0.01%     
  Complexity     2223     2223              
============================================
  Files           108      108              
  Lines         25307    25312       +5     
  Branches       4176     4177       +1     
============================================
+ Hits          11810    11817       +7     
+ Misses        11465    11462       -3     
- Partials       2032     2033       +1
Flag Coverage Δ Complexity Δ
#JDBC41 46.46% <87.5%> (ø) 2212 <0> (+2) ⬆️
#JDBC42 46.44% <87.5%> (-0.11%) 2215 <0> (-2)
Impacted Files Coverage Δ Complexity Δ
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 33.23% <87.5%> (+0.17%) 244 <0> (+1) ⬆️
...c/main/java/com/microsoft/sqlserver/jdbc/Util.java 60.75% <0%> (-0.45%) 87% <0%> (-1%)
...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java 62.93% <0%> (-0.31%) 0% <0%> (ø)
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java 52.64% <0%> (-0.13%) 239% <0%> (-1%)
...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java 44.92% <0%> (ø) 104% <0%> (-1%) ⬇️
...m/microsoft/sqlserver/jdbc/SQLServerStatement.java 59.47% <0%> (+0.1%) 131% <0%> (+1%) ⬆️
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 53.93% <0%> (+0.19%) 0% <0%> (ø) ⬇️
...ncurrentlinkedhashmap/ConcurrentLinkedHashMap.java 42.42% <0%> (+0.21%) 46% <0%> (ø) ⬇️
...om/microsoft/sqlserver/jdbc/SimpleInputStream.java 52.59% <0%> (+1.48%) 12% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be14e88...c006af2. Read the comment docs.

@peterbae peterbae mentioned this pull request Nov 21, 2017
Closed
@rickysang
Copy link
Copy Markdown

rickysang commented Nov 27, 2017

@peterbae Thanks for the fix. Test passed.

@cheenamalhotra cheenamalhotra added this to the 6.3.6 milestone Nov 30, 2017
@peterbae peterbae merged commit a8ed6f6 into microsoft:dev Dec 5, 2017
@peterbae peterbae deleted the github-477 branch December 5, 2017 18:11
@peterbae peterbae mentioned this pull request Dec 7, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cheenamalhotra cheenamalhotra cheenamalhotra approved these changes

@xiangyushawn xiangyushawn Awaiting requested review from xiangyushawn

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

6.3.6

Development

Successfully merging this pull request may close these issues.

5 participants

@peterbae @codecov-io @rickysang @cheenamalhotra @lilgreenbird