Update Dependency section in README#18
Conversation
azure-keyvault (mssql-jdbc's dependencies) microsoft#17 : Adding section in README related to dependency
xiangyushawn
left a comment
There was a problem hiding this comment.
This dependency is used for Always Encrypted Azure Key Vault feature, at line 83 should we say this instead of "Azure Web Services for authentication" ?
README.md
Outdated
| </dependency> | ||
| ``` | ||
|
|
||
| ###Dependency Tree |
There was a problem hiding this comment.
Instead of listing the output for the dependency tree, perhaps you can describe how someone can get this information for themselves? (This list will be hard to maintain if it changes in the future.)
README.md
Outdated
|
|
||
| Compile Time: | ||
|
|
||
| - `azure-keyvault` |
There was a problem hiding this comment.
Can we add what this dependency is used for? E.g. used for Azure Key Vault Provider for Always Encrypted
README.md
Outdated
|
|
||
| - `junit:jar` | ||
|
|
||
| If anybody wants to use driver as a run-time dependency but not using Azure Web Services for authentication then you either describe as optional dependency or exclude azure. |
There was a problem hiding this comment.
Let's make this more generic in case we need to add more dependencies in the future. I'd suggest something like this:
###Exclude Dependencies
If you wish to limit the number of run-time dependencies, and your project does not require the features named above, you can explicitly exclude them. For example:
There was a problem hiding this comment.
Added Exclude Dependencies section.
Update Dependency section in README microsoft#18
|
@v-mabarw & @v-xiangs : Please review updated README |
|
Reopening Pull Request. |
@v-mabarw & @v-xiangs : Can you review Dependency Section in README?