Use StandardCharsets where possible#15
Merged
xiangyushawn merged 2 commits intomicrosoft:devfrom Nov 23, 2016
marschall:StandardCharsets
Merged
Use StandardCharsets where possible#15xiangyushawn merged 2 commits intomicrosoft:devfrom marschall:StandardCharsets
xiangyushawn merged 2 commits intomicrosoft:devfrom
marschall:StandardCharsets
Conversation
Since Java 1.7 there is the StandardCharsets class which provides constants for frequently used Charsets. Using this also allows us to remove several UnsupportedEncodingException catch blocks. * use StandardCharsets in String constructors where possible * use StandardCharsets in #getBytes where possible * use StandardCharsets instead of Charset.foreName where possible
Contributor
There was a problem hiding this comment.
Perfect! @marschall Accepted the PR, thanks for your contribution.
lilgreenbird
pushed a commit
to lilgreenbird/mssql-jdbc
that referenced
this pull request
Aug 25, 2020
Merge from upstream dev branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since Java 1.7 there is the StandardCharsets class which provides
constants for frequently used Charsets. Using this also allows us to
remove several UnsupportedEncodingException catch blocks.