Avoid unnecessary calls to String copy constructor#14
Merged
Suraiya-Hameed merged 2 commits intomicrosoft:devfrom Dec 1, 2016
marschall:String-copy-constructor
Merged
Avoid unnecessary calls to String copy constructor#14Suraiya-Hameed merged 2 commits intomicrosoft:devfrom marschall:String-copy-constructor
Suraiya-Hameed merged 2 commits intomicrosoft:devfrom
marschall:String-copy-constructor
Conversation
The driver currently contains 20 calls to the String(String) copy
constructor. To quote from the Javadoc
> Unless an explicit copy of {@code original} is needed, use of this
> constructor is unnecessary since Strings are immutable.
Calling the constructor only results in unnecessary pressure of both
the allocator and the heap.
…ring-copy-constructor # Conflicts: # src/main/java/com/microsoft/sqlserver/jdbc/IOBuffer.java # src/main/java/com/microsoft/sqlserver/jdbc/dtv.java
Contributor
|
Thanks for your contribution @marschall |
lilgreenbird
pushed a commit
to lilgreenbird/mssql-jdbc
that referenced
this pull request
Aug 24, 2020
Keyvault upgrade
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The driver currently contains 20 calls to the String(String) copy
constructor. To quote from the Javadoc
Calling the constructor only results in unnecessary pressure of both
the allocator and the heap.