Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5523 +/- ##
==========================================
+ Coverage 84.65% 85.46% +0.81%
==========================================
Files 59 59
Lines 18621 18621
==========================================
+ Hits 15763 15915 +152
+ Misses 2858 2706 -152 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
guhetier
approved these changes
Oct 16, 2025
Collaborator
guhetier
left a comment
There was a problem hiding this comment.
Do we need to backport this to v2.5?
Contributor
Author
Yes |
guhetier
pushed a commit
that referenced
this pull request
Oct 22, 2025
* changed signed to unsigned * updated clog
guhetier
added a commit
that referenced
this pull request
Oct 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The msquic pipeline in undock using UCRT compiler is failing due to format specifier mismatch. BOOLEAN is typedef'd as unsigned char, but the format string uses %d which expects a signed integer. When an unsigned char is passed to a function that expects a signed type, the compiler generates a C6340 warning.
Testing
The new changes are tested on the undock pipeline and its passing.
Documentation
No