Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5352 +/- ##
==========================================
- Coverage 85.90% 85.37% -0.54%
==========================================
Files 59 59
Lines 18600 18600
==========================================
- Hits 15979 15880 -99
- Misses 2621 2720 +99 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
95b1417 to
be15c7a
Compare
mtfriesen
requested changes
Sep 10, 2025
Contributor
mtfriesen
left a comment
There was a problem hiding this comment.
Please add a description to the PR explaining what this does and why.
mtfriesen
approved these changes
Sep 12, 2025
anrossi
added a commit
that referenced
this pull request
Sep 12, 2025
anrossi
added a commit
that referenced
this pull request
Sep 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add /profile link flag to Windows user mode builds. This flag puts extra debug information in the PDB to enable performance analysis of the binary and is required for shipping in some scenarios.
Testing
Existing tests should cover this.
Documentation
N/A