Docs typo: missing ` in insertSpaces#1824
Closed
JoshuaKGoldberg wants to merge 3 commits intomicrosoft:masterfrom
JoshuaKGoldberg:patch-1
Closed
Docs typo: missing ` in insertSpaces#1824JoshuaKGoldberg wants to merge 3 commits intomicrosoft:masterfrom JoshuaKGoldberg:patch-1
JoshuaKGoldberg wants to merge 3 commits intomicrosoft:masterfrom
JoshuaKGoldberg:patch-1
Conversation
Contributor
JoshuaKGoldberg
commented
Feb 9, 2020
Member
|
@JoshuaKGoldberg Thank you, that file is generated and the real truth is at https://github.com/microsoft/vscode/blob/b22dd8e612c4b360d4289e199579cd0a04f8459f/src/vs/editor/standalone/browser/standaloneCodeEditor.ts#L93 Would you please consider making a PR in vscode. Thank you! |
Contributor
Author
|
Sure, thank you! microsoft/vscode#90374 |
alexdima
pushed a commit
to microsoft/vscode
that referenced
this pull request
Feb 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.