fix: set a proper default value for non-nullable python fields#6489
Closed
ntauth wants to merge 1 commit intomicrosoft:mainfrom
Closed
fix: set a proper default value for non-nullable python fields#6489ntauth wants to merge 1 commit intomicrosoft:mainfrom
ntauth wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Author
@microsoft-github-policy-service agree company="Hoshii AG" |
ntauth
commented
Apr 22, 2025
| conventions.WriteInLineDescription(codeElement, writer); | ||
| var isNonNullableCollection = !codeElement.Type.IsNullable && codeElement.Type.CollectionKind != CodeTypeBase.CodeTypeCollectionKind.None; | ||
| writer.WriteLine($"{conventions.GetAccessModifier(codeElement.Access)}{codeElement.NamePrefix}{codeElement.Name}: {(codeElement.Type.IsNullable ? "Optional[" : string.Empty)}{returnType}{(codeElement.Type.IsNullable ? "]" : string.Empty)} {(isNonNullableCollection ? "= []" : "= None")}"); | ||
| var defaultFactoryType = codeElement.Type.CollectionKind.IsArray() ? "list" : "dict"; |
Author
There was a problem hiding this comment.
I added "dict" as the other option because of the Complex type of CollectionKind. I assume Complex == object? That should never happen irl though
Member
There was a problem hiding this comment.
None = single value,
Array = Array,
Complex = List or equivalent on the platform.
With that information in mind, can you please update the code?
baywet
requested changes
May 12, 2025
Member
baywet
left a comment
There was a problem hiding this comment.
also, can you please add a changelog entry (unreleased, changed)
| conventions.WriteInLineDescription(codeElement, writer); | ||
| var isNonNullableCollection = !codeElement.Type.IsNullable && codeElement.Type.CollectionKind != CodeTypeBase.CodeTypeCollectionKind.None; | ||
| writer.WriteLine($"{conventions.GetAccessModifier(codeElement.Access)}{codeElement.NamePrefix}{codeElement.Name}: {(codeElement.Type.IsNullable ? "Optional[" : string.Empty)}{returnType}{(codeElement.Type.IsNullable ? "]" : string.Empty)} {(isNonNullableCollection ? "= []" : "= None")}"); | ||
| var defaultFactoryType = codeElement.Type.CollectionKind.IsArray() ? "list" : "dict"; |
Member
There was a problem hiding this comment.
None = single value,
Array = Array,
Complex = List or equivalent on the platform.
With that information in mind, can you please update the code?
Member
|
@ntauth gentle reminder on this :) |
Author
|
I am currently swamped with my own work, I will pick it back up when I have time and headroom. Feel free to fix the review comments if in a rush 👍
Il lun, giu 9, 2025 alle 21:20, Vincent Biret ***@***.***(mailto:Il lun, giu 9, 2025 alle 21:20, Vincent Biret <<a href=)> ha scritto:
… baywet left a comment [(microsoft/kiota#6489)](#6489 (comment))
***@***.***(https://github.com/ntauth) gentle reminder on this :)
—
Reply to this email directly, [view it on GitHub](#6489 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/ADEKROBNVDVBW6RCXGSIQCL3CXNBRAVCNFSM6AAAAAB3TDPPSSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDSNJWG42DKNZQGE).
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6350