Skip to content

parsable interface split#1315

Merged
baywet merged 10 commits intomainfrom
feature/parsable-split
Mar 4, 2022
Merged

parsable interface split#1315
baywet merged 10 commits intomainfrom
feature/parsable-split

Conversation

@baywet
Copy link
Member

@baywet baywet commented Mar 2, 2022 •
edited
Loading

fixes #737

Generation diff

microsoft/kiota-samples#544

TODO

CSharp

  • test with additional properties disabled
  • bump abstractions and serialization

Go

  • add new interface and update parsable
  • update refiner for new types
  • update parse node implementation
  • check the interface extraction code
  • test with additional properties disabled

Java

  • add new interface and update parsable
  • udpate refienr for new types
  • update parse node implementation
  • bump abstractions and serialization
  • test with additional properties disabled

TypeScript

  • add new interface and update parsable
  • update refiner for new types
  • update parse node implementation
  • bump abstractions and serialization
  • test with additional properties disabled

Global

  • add unit tests for usings/interfaces
  • update documentation
  • ping php and python teams
  • update ruby checklist

@baywet baywet added this to the Community Preview milestone Mar 2, 2022
@baywet baywet added generator Issues or improvements relater to generation capabilities. Go Csharp Pull requests that update .net code Java TypeScript Pull requests that update Javascript code labels Mar 2, 2022
@baywet baywet self-assigned this Mar 2, 2022
@baywet baywet force-pushed the feature/parsable-split branch from f63f02a to d348932 Compare March 3, 2022 13:00
baywet added 2 commits March 3, 2022 10:44
@baywet
- code linting
bfd41b0 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
- updates dotnet generation to split the parsable interface
f9531dd
@baywet baywet force-pushed the feature/parsable-split branch from d348932 to f9531dd Compare March 3, 2022 15:44
@baywet baywet marked this pull request as ready for review March 3, 2022 19:37
This was referenced Mar 3, 2022
Closed
Closed
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

98.1% 98.1% Coverage
0.0% 0.0% Duplication

andrueastman
andrueastman approved these changes Mar 4, 2022
View reviewed changes
@andrueastman
Copy link
Contributor

andrueastman commented Mar 4, 2022

@baywet
Just to confirm, do you usually have to update the go references after the merge since you need a ref to the merge commit?

nikithauc
nikithauc reviewed Mar 4, 2022
View reviewed changes
abstractions/typescript/src/serialization/additionalDataHolder.ts
* Gets the additional data for this object that did not belong to the properties.
* @return The additional data for this object.
*/
additionalData: Map<string, unknown>;
Copy link
Contributor

@nikithauc nikithauc Mar 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could merge #1328 here. Using Record instead of Map

Copy link
Member Author

@baywet baywet Mar 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to go ahead and merge this PR, this way you can rebase #1328

@baywet baywet merged commit 1b038c9 into main Mar 4, 2022
@baywet baywet deleted the feature/parsable-split branch March 4, 2022 19:05
This was referenced Mar 7, 2022
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@darrelmiller darrelmiller Awaiting requested review from darrelmiller

@zengin zengin Awaiting requested review from zengin

@MIchaelMainer MIchaelMainer Awaiting requested review from MIchaelMainer

@ddyett ddyett Awaiting requested review from ddyett

@peombwa peombwa Awaiting requested review from peombwa

@ramsessanchez ramsessanchez Awaiting requested review from ramsessanchez

2 more reviewers

@nikithauc nikithauc nikithauc left review comments

@andrueastman andrueastman andrueastman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@baywet baywet

Labels

Csharp Pull requests that update .net code generator Issues or improvements relater to generation capabilities. Go Java TypeScript Pull requests that update Javascript code

Projects

None yet

Milestone

Community Preview

Development

Successfully merging this pull request may close these issues.

Parsable interface should be splat

3 participants

@baywet @andrueastman @nikithauc