Skip to content

Using record for additional data#1328

Merged
baywet merged 5 commits intomainfrom
nikithauc/additional-data-record
Mar 21, 2022
Merged

Using record for additional data#1328
baywet merged 5 commits intomainfrom
nikithauc/additional-data-record

Conversation

@nikithauc
Copy link
Contributor

No description provided.

@nikithauc nikithauc added the TypeScript Pull requests that update Javascript code label Mar 4, 2022
@nikithauc nikithauc marked this pull request as draft March 4, 2022 08:40
@nikithauc nikithauc mentioned this pull request Mar 4, 2022
21 tasks
@nikithauc
Copy link
Contributor Author

Waiting for #1327

@nikithauc nikithauc added the blocked This work can't be done until an external dependent work is done. label Mar 15, 2022
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the codemethod writer needs to be updated to use records/objects in stead of maps for the deserialiser and the default vaues values in the constructors

@nikithauc nikithauc removed the blocked This work can't be done until an external dependent work is done. label Mar 21, 2022
@nikithauc
Copy link
Contributor Author

the codemethod writer needs to be updated to use records/objects in stead of maps for the deserialiser and the default vaues values in the constructors

Done. Please verify

@nikithauc nikithauc marked this pull request as ready for review March 21, 2022 05:40
@baywet baywet added this to the Community Preview milestone Mar 21, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@baywet baywet merged commit 4f4c424 into main Mar 21, 2022
@baywet baywet deleted the nikithauc/additional-data-record branch March 21, 2022 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

TypeScript Pull requests that update Javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants