fix(scripts): correct type assertions in Invoke-YamlLint.Tests.ps1 by WilliamBerryiii · Pull Request #332 · microsoft/hve-core

WilliamBerryiii · 2026-01-27T20:47:27Z

Description

This PR fixes incorrect type assertions in the Invoke-YamlLint Pester tests. The Set-GitHubOutput function accepts string parameters, but the test assertions were comparing against integer values instead of strings. This caused test failures when validating the correct behavior of the YAML linting script.

fix(scripts): Changed 8 Set-GitHubOutput value assertions from integers to quoted strings
- $Value -eq 0 → $Value -eq '0'
- $Value -eq 1 → $Value -eq '1'
- $Value -eq 2 → $Value -eq '2'

Related Issue(s)

Fixes #330

Type of Change

Select all that apply:

Code & Documentation:

Bug fix (non-breaking change fixing an issue)
New feature (non-breaking change adding functionality)
Breaking change (fix or feature causing existing functionality to change)
Documentation update

Infrastructure & Configuration:

AI Artifacts:

Reviewed contribution with prompt-builder agent and addressed all feedback
Copilot instructions (.github/instructions/*.instructions.md)
Copilot prompt (.github/prompts/*.prompt.md)
Copilot agent (.github/agents/*.agent.md)

Note for AI Artifact Contributors:

Agents: Research, indexing/referencing other project (using standard VS Code GitHub Copilot/MCP tools), planning, and general implementation agents likely already exist. Review .github/agents/ before creating new ones.

Model Versions: Only contributions targeting the latest Anthropic and OpenAI models will be accepted. Older model versions (e.g., GPT-3.5, Claude 3) will be rejected.

See Agents Not Accepted and Model Version Requirements.

Other:

Script/automation (.ps1, .sh, .py)
Other (please describe):

Testing

Verified all 8 assertions updated from integer to string comparisons
PowerShell linting passed via npm run lint:ps

Checklist

Required Checks

Documentation is updated (if applicable)
Files follow existing naming conventions
Changes are backwards compatible (if applicable)
Tests added for new functionality (if applicable)

AI Artifact Contributions

N/A - This PR does not include AI artifact contributions.

Required Automated Checks

The following validation commands must pass before merging:

Markdown linting: npm run lint:md
Spell checking: npm run spell-check
Frontmatter validation: npm run lint:frontmatter
Link validation: npm run lint:md-links
PowerShell analysis: npm run lint:ps

Security Considerations

This PR does not contain any sensitive or NDA information
Any new dependencies have been reviewed for security issues
Security-related scripts follow the principle of least privilege

Additional Notes

This fix addresses code review feedback from PR #326 where the copilot-pull-request-reviewer identified that Set-GitHubOutput accepts string parameters, making the integer comparisons technically incorrect.

🐛 - Generated by Copilot

- change 8 Set-GitHubOutput value assertions from integers to strings - Set-GitHubOutput accepts string parameters, not integers Fixes #330 🐛 - Generated by Copilot

github-actions · 2026-01-27T20:47:44Z

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

codecov-commenter · 2026-01-27T20:48:43Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 40.60%. Comparing base (4ef6d20) to head (2ad87cb).
⚠️ Report is 193 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #332      +/-   ##
==========================================
- Coverage   40.64%   40.60%   -0.04%     
==========================================
  Files          15       15              
  Lines        2864     2864              
==========================================
- Hits         1164     1163       -1     
- Misses       1700     1701       +1

Flag	Coverage Δ
pester	`40.60% <ø> (-0.04%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1 file with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot

Pull request overview

This PR fixes type assertion mismatches in the Pester tests for Invoke-YamlLint.ps1. The Set-GitHubOutput function accepts a [string]$Value parameter, but test assertions were incorrectly comparing against integer values instead of strings. This inconsistency was identified during code review of PR #326.

Changes:

Updated 8 test assertions to use string comparisons instead of integer comparisons for Set-GitHubOutput value parameters
Changed comparisons like $Value -eq 0 to $Value -eq '0' (covering values 0, 1, and 2)
Aligned all assertions with the function's parameter type and existing correct assertions in the same file

…scoveredAgents call 🔧 - Generated by Copilot

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

scripts/extension/Prepare-Extension.ps1

…h Get-DiscoveredAgents call" This reverts commit 8427552.

🤖 I have created a release *beep* *boop* --- ## [2.0.0](hve-core-v1.1.0...hve-core-v2.0.0) (2026-01-28) ### ⚠ BREAKING CHANGES * **agents:** add Task Reviewer and expand RPI to 4-phase workflow ([#277](#277)) ### ✨ Features * **agents:** add hve-core-installer agent to extension package ([#297](#297)) ([c0e48c6](c0e48c6)) * **agents:** add Task Reviewer and expand RPI to 4-phase workflow ([#277](#277)) ([ae76cab](ae76cab)) * **build:** add code coverage reporting to Pester workflow ([#230](#230)) ([a34822a](a34822a)) * **docs:** add GOVERNANCE.md for OSSF Silver Badge compliance ([#235](#235)) ([b0e752c](b0e752c)) * **docs:** add ROADMAP.md for OSSF Silver badge compliance ([#238](#238)) ([4a41c16](4a41c16)) * **mcp:** add MCP server configuration guidance and installer enhancements ([#225](#225)) ([0bce418](0bce418)) * **scripts:** add YAML linting with actionlint ([#234](#234)) ([d9301f9](d9301f9)) * **security:** add OpenSSF Scorecard workflow and badge ([#271](#271)) ([7c6d788](7c6d788)) * **skills:** add video-to-gif conversion skill with FFmpeg two-pass optimization ([#247](#247)) ([8d65c42](8d65c42)) * **tests:** add Pester tests for LintingHelpers and Validate-MarkdownFrontmatter ([#197](#197), [#198](#198)) ([#205](#205)) ([51ae563](51ae563)) ### 🐛 Bug Fixes * **build:** detect table formatting changes via git diff ([#261](#261)) ([985eee0](985eee0)) * **build:** disable MD024 lint rule in CHANGELOG for release-please ([#220](#220)) ([971df94](971df94)) * **build:** quote shell variables and group redirects in workflow files ([#299](#299)) ([3372509](3372509)) * **build:** resolve scorecard badge and workflow security issues ([#301](#301)) ([aeaed13](aeaed13)) * **extension:** remove frontmatter from README and exclude from markdown linting ([#223](#223)) ([4272529](4272529)) * **instructions:** quote applyTo glob pattern for YAML compatibility ([#216](#216)) ([085199c](085199c)) * **scripts:** add FooterExcludePaths parameter to frontmatter validation ([#334](#334)) ([64db98d](64db98d)) * **scripts:** add GHSA word and logs/ exclusion to cspell config ([#214](#214)) ([5c99b3f](5c99b3f)) * **scripts:** correct type assertions in Invoke-YamlLint.Tests.ps1 ([#332](#332)) ([af7050d](af7050d)) * **scripts:** eliminate false positives in dependency pinning npm pattern ([#273](#273)) ([ccbdfa3](ccbdfa3)) * **security:** add artifact attestation for signed releases ([#257](#257)) ([c52d6e2](c52d6e2)) * standardize markdown footers and complete frontmatter ([#217](#217)) ([b4e7556](b4e7556)) ### 📚 Documentation * add OpenSSF Best Practices Passing badge to README ([#239](#239)) ([91bc529](91bc529)) * **architecture:** add architecture documentation and value proposition ([#252](#252)) ([0e4b02f](0e4b02f)) * **contributing:** add testing requirements for OSSF compliance ([#254](#254)) ([4db1a18](4db1a18)) * **docs:** add enterprise status badges to README header ([#270](#270)) ([ccb68a4](ccb68a4)) * **security:** add security assurance case and threat model for OSSF Silver ([#259](#259)) ([a390e26](a390e26)) ### ♻️ Refactoring * **application:** wrap execution with try blocks, ensure proper … ([#296](#296)) ([35c4417](35c4417)) * **scripts:** extract frontmatter validation to testable module ([#293](#293)) ([4e8707e](4e8707e)) * **scripts:** extract pure functions for Pester testability ([#221](#221)) ([d40e742](d40e742)) ### 🔧 Maintenance * **deps-dev:** bump cspell from 9.4.0 to 9.6.0 in the npm-dependencies group ([#208](#208)) ([855914b](855914b)) * **deps-dev:** bump cspell from 9.6.0 to 9.6.1 in the npm-dependencies group ([#294](#294)) ([1e45ad6](1e45ad6)) * **deps:** bump actions/setup-node from 6.1.0 to 6.2.0 in the github-actions group ([#209](#209)) ([c4c69e2](c4c69e2)) * **deps:** bump the github-actions group with 4 updates ([#295](#295)) ([d8337b8](d8337b8)) * remove step-security/harden-runner from workflows ([#246](#246)) ([c5708d8](c5708d8)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: hve-core-release-please[bot] <254602402+hve-core-release-please[bot]@users.noreply.github.com>

fix(scripts): correct type assertions in Invoke-YamlLint.Tests.ps1

0a8a3ab

- change 8 Set-GitHubOutput value assertions from integers to strings - Set-GitHubOutput accepts string parameters, not integers Fixes #330 🐛 - Generated by Copilot

WilliamBerryiii requested a review from a team as a code owner January 27, 2026 20:47

Copilot AI review requested due to automatic review settings January 27, 2026 20:47

Copilot started reviewing on behalf of WilliamBerryiii January 27, 2026 20:47 View session

Copilot AI reviewed Jan 27, 2026

View reviewed changes

refactor(scripts): replace duplicate agent discovery loop with Get-Di…

8427552

…scoveredAgents call 🔧 - Generated by Copilot

auyidi1 approved these changes Jan 27, 2026

View reviewed changes

Merge branch 'main' into fix/invoke-yamllint-tests-string-types

998b0ed

Copilot AI review requested due to automatic review settings January 27, 2026 22:01

Copilot started reviewing on behalf of WilliamBerryiii January 27, 2026 22:01 View session

Copilot AI reviewed Jan 27, 2026

View reviewed changes

scripts/extension/Prepare-Extension.ps1 Outdated Show resolved Hide resolved

Revert "refactor(scripts): replace duplicate agent discovery loop wit…

2ad87cb

…h Get-DiscoveredAgents call" This reverts commit 8427552.

WilliamBerryiii merged commit af7050d into main Jan 27, 2026
16 checks passed

WilliamBerryiii deleted the fix/invoke-yamllint-tests-string-types branch January 27, 2026 22:15

hve-core-release-please bot mentioned this pull request Jan 27, 2026

chore(main): release hve-core 2.0.0 #212

Merged

This was referenced Jan 28, 2026

chore(main): release hve-core 3.0.0 #341

Closed

chore(main): release hve-core 3.0.0 #417

Closed

This was referenced Feb 6, 2026

chore(main): release hve-core 3.0.0 #441

Closed

chore(main): release hve-core 3.0.0 #530

Closed

chore(main): release hve-core 3.0.0 #532

Closed

chore(main): release hve-core 3.0.0 #534

Closed

hve-core-release-please bot mentioned this pull request Feb 17, 2026

chore(main): release hve-core 3.0.0 #641

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(scripts): correct type assertions in Invoke-YamlLint.Tests.ps1#332

fix(scripts): correct type assertions in Invoke-YamlLint.Tests.ps1#332
WilliamBerryiii merged 4 commits intomainfrom
fix/invoke-yamllint-tests-string-types

WilliamBerryiii commented Jan 27, 2026

Uh oh!

github-actions bot commented Jan 27, 2026 •

edited

Loading

Uh oh!

codecov-commenter commented Jan 27, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

WilliamBerryiii commented Jan 27, 2026

Description

Related Issue(s)

Type of Change

Testing

Checklist

Required Checks

AI Artifact Contributions

Required Automated Checks

Security Considerations

Additional Notes

Uh oh!

github-actions bot commented Jan 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Dependency Review

Scanned Files

Uh oh!

codecov-commenter commented Jan 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

github-actions bot commented Jan 27, 2026 •

edited

Loading

codecov-commenter commented Jan 27, 2026 •

edited

Loading