refactor(scripts): extract pure functions for Pester testability by WilliamBerryiii · Pull Request #221 · microsoft/hve-core

WilliamBerryiii · 2026-01-21T02:01:27Z

Description

Refactors four PowerShell scripts to extract pure functions for improved Pester unit testability. This architectural change separates business logic from I/O operations, enabling comprehensive testing without mocking external dependencies.

Changes by Script

Get-VerifiedDownload.ps1

Extract hash verification: Get-FileHashValue, Test-HashMatch
Extract path resolution: Get-DownloadTargetPath, Test-ExistingFileValid
Extract result building: New-DownloadResult, Get-ArchiveType, Test-TarAvailable
Add I/O orchestrator: Invoke-VerifiedDownload
Add dot-source guard for direct execution

Package-Extension.ps1

Extract validation: Test-VsceAvailable, Test-ExtensionManifestValid
Extract path/command building: Get-ExtensionOutputPath, Get-VscePackageCommand
Extract version resolution: Get-ResolvedPackageVersion
Extract result building: New-PackagingResult

Prepare-Extension.ps1

Extract maturity filtering: Get-AllowedMaturities
Extract validation: Test-PathsExist
Extract discovery: Get-DiscoveredAgents, Get-DiscoveredPrompts, Get-DiscoveredInstructions
Extract JSON manipulation: Update-PackageJsonContributes
Fix bug in Update-PackageJsonContributes using Add-Member for dynamic properties

Generate-PrReference.ps1

Add [OutputType()] attributes to existing functions
Add explicit param() blocks where missing

Test Coverage

Added four comprehensive Pester test files covering all extracted pure functions with 191 total tests passing.

Related Issue(s)

Closes #200

Type of Change

Testing

All validation passes:

Pester v5.7.1
Tests completed in 1.48s
Tests Passed: 191, Failed: 0, Skipped: 0

Validation commands run:

npm run lint:md - Markdown linting passed
npm run lint:frontmatter - Frontmatter validation passed
npm run lint:ps - PSScriptAnalyzer passed

Checklist

Required for all contributions

I have performed a self-review of my own changes
My changes follow the project's coding standards and guidelines
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation (if applicable)
My changes generate no new warnings or errors
I have added tests that prove my fix is effective or that my feature works

AI Artifact contributions

I have tested my AI artifacts with GitHub Copilot
My prompts and instructions follow the project's AI artifact guidelines
I have validated that my AI artifacts produce consistent, expected outputs

Required automated checks

npm run lint:md passes
npm run spell-check passes (or words added to custom dictionary)
npm run lint:frontmatter passes
npm run lint:md-links passes
npm run lint:ps passes

Security Considerations

No security implications:

No new dependencies introduced
No credential handling changes
No external API integrations added
Pure function extraction maintains existing security boundaries

- refactor Get-VerifiedDownload.ps1 with hash verification and path resolution functions - refactor Generate-PrReference.ps1 with git output parsing and XML generation functions - refactor Package-Extension.ps1 with manifest validation and version resolution functions - refactor Prepare-Extension.ps1 with JSON manipulation and contributor discovery functions - add 4 comprehensive Pester test files covering all extracted pure functions - fix bug in Update-PackageJsonContributes using Add-Member for dynamic properties 🧪 - Generated by Copilot

github-actions · 2026-01-21T02:01:40Z

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

- Replace Windows-specific paths (C:\temp, C:\ext, C:\nonexistent) with platform-agnostic path construction - Use [System.IO.Path]::Combine() and [System.IO.Path]::GetTempPath() for test directories - Fixes CI failures on Linux runners 🔧 - Generated by Copilot

- Add entry point guard to Generate-PrReference.ps1 to prevent execution when dot-sourced - Replace #Requires -Modules with runtime check in Prepare-Extension.ps1 entry point - Both changes allow test files to dot-source scripts without triggering execution or module errors 🔧 - Generated by Copilot

…ility-refactoring

Copilot

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 7 comments.

scripts/extension/Prepare-Extension.ps1

- change Get-CommitCount assertion to BeGreaterOrEqual 1 (merge commits inflate count) - add dynamic branch detection fallback for shallow CI checkouts - add skip conditions for YAML-dependent tests when PowerShell-Yaml unavailable 🔧 - Generated by Copilot

- Get-FrontmatterData performs I/O via Get-Content and ConvertFrom-Yaml - Test-PathsExist performs I/O via Test-Path - Get-DiscoveredAgents performs I/O via Get-ChildItem and Test-Path - Get-DiscoveredPrompts performs I/O via Get-ChildItem and Test-Path - Get-DiscoveredInstructions performs I/O via Get-ChildItem and Test-Path 📝 - Generated by Copilot

- Invoke-PrReferenceGeneration Describe block was truncated - File ended without closing It block and Describe block braces 🔧 - Generated by Copilot

- add Get-CurrentBranchOrRef helper function - fall back to detached@<sha> when git branch --show-current returns empty - add unit tests for new function 🔧 - Generated by Copilot

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.

Comments suppressed due to low confidence (1)

scripts/dev-tools/Generate-PrReference.ps1:457

These lines have inconsistent indentation compared to surrounding code. They should be indented to align with other statements in the try block (lines 449-455).

    $commitEntries = Get-CommitEntry -ComparisonRef $comparisonInfo.Ref
        $commitCount = Get-CommitCount -ComparisonRef $comparisonInfo.Ref
        $diffOutput = Get-DiffOutput -ComparisonRef $comparisonInfo.Ref -ExcludeMarkdownDiff:$ExcludeMarkdownDiff
        $diffSummary = Get-DiffSummary -ComparisonRef $comparisonInfo.Ref -ExcludeMarkdownDiff:$ExcludeMarkdownDiff

    $xmlContent = Get-PrXmlContent -CurrentBranch $currentBranch -BaseBranch $BaseBranch -CommitEntries $commitEntries -DiffOutput $diffOutput

scripts/tests/Generate-PrReference.Tests.ps1

….ps1 🧹 - Generated by Copilot

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

katriendg

Nice one!

🤖 I have created a release *beep* *boop* --- ## [2.0.0](hve-core-v1.1.0...hve-core-v2.0.0) (2026-01-28) ### ⚠ BREAKING CHANGES * **agents:** add Task Reviewer and expand RPI to 4-phase workflow ([#277](#277)) ### ✨ Features * **agents:** add hve-core-installer agent to extension package ([#297](#297)) ([c0e48c6](c0e48c6)) * **agents:** add Task Reviewer and expand RPI to 4-phase workflow ([#277](#277)) ([ae76cab](ae76cab)) * **build:** add code coverage reporting to Pester workflow ([#230](#230)) ([a34822a](a34822a)) * **docs:** add GOVERNANCE.md for OSSF Silver Badge compliance ([#235](#235)) ([b0e752c](b0e752c)) * **docs:** add ROADMAP.md for OSSF Silver badge compliance ([#238](#238)) ([4a41c16](4a41c16)) * **mcp:** add MCP server configuration guidance and installer enhancements ([#225](#225)) ([0bce418](0bce418)) * **scripts:** add YAML linting with actionlint ([#234](#234)) ([d9301f9](d9301f9)) * **security:** add OpenSSF Scorecard workflow and badge ([#271](#271)) ([7c6d788](7c6d788)) * **skills:** add video-to-gif conversion skill with FFmpeg two-pass optimization ([#247](#247)) ([8d65c42](8d65c42)) * **tests:** add Pester tests for LintingHelpers and Validate-MarkdownFrontmatter ([#197](#197), [#198](#198)) ([#205](#205)) ([51ae563](51ae563)) ### 🐛 Bug Fixes * **build:** detect table formatting changes via git diff ([#261](#261)) ([985eee0](985eee0)) * **build:** disable MD024 lint rule in CHANGELOG for release-please ([#220](#220)) ([971df94](971df94)) * **build:** quote shell variables and group redirects in workflow files ([#299](#299)) ([3372509](3372509)) * **build:** resolve scorecard badge and workflow security issues ([#301](#301)) ([aeaed13](aeaed13)) * **extension:** remove frontmatter from README and exclude from markdown linting ([#223](#223)) ([4272529](4272529)) * **instructions:** quote applyTo glob pattern for YAML compatibility ([#216](#216)) ([085199c](085199c)) * **scripts:** add FooterExcludePaths parameter to frontmatter validation ([#334](#334)) ([64db98d](64db98d)) * **scripts:** add GHSA word and logs/ exclusion to cspell config ([#214](#214)) ([5c99b3f](5c99b3f)) * **scripts:** correct type assertions in Invoke-YamlLint.Tests.ps1 ([#332](#332)) ([af7050d](af7050d)) * **scripts:** eliminate false positives in dependency pinning npm pattern ([#273](#273)) ([ccbdfa3](ccbdfa3)) * **security:** add artifact attestation for signed releases ([#257](#257)) ([c52d6e2](c52d6e2)) * standardize markdown footers and complete frontmatter ([#217](#217)) ([b4e7556](b4e7556)) ### 📚 Documentation * add OpenSSF Best Practices Passing badge to README ([#239](#239)) ([91bc529](91bc529)) * **architecture:** add architecture documentation and value proposition ([#252](#252)) ([0e4b02f](0e4b02f)) * **contributing:** add testing requirements for OSSF compliance ([#254](#254)) ([4db1a18](4db1a18)) * **docs:** add enterprise status badges to README header ([#270](#270)) ([ccb68a4](ccb68a4)) * **security:** add security assurance case and threat model for OSSF Silver ([#259](#259)) ([a390e26](a390e26)) ### ♻️ Refactoring * **application:** wrap execution with try blocks, ensure proper … ([#296](#296)) ([35c4417](35c4417)) * **scripts:** extract frontmatter validation to testable module ([#293](#293)) ([4e8707e](4e8707e)) * **scripts:** extract pure functions for Pester testability ([#221](#221)) ([d40e742](d40e742)) ### 🔧 Maintenance * **deps-dev:** bump cspell from 9.4.0 to 9.6.0 in the npm-dependencies group ([#208](#208)) ([855914b](855914b)) * **deps-dev:** bump cspell from 9.6.0 to 9.6.1 in the npm-dependencies group ([#294](#294)) ([1e45ad6](1e45ad6)) * **deps:** bump actions/setup-node from 6.1.0 to 6.2.0 in the github-actions group ([#209](#209)) ([c4c69e2](c4c69e2)) * **deps:** bump the github-actions group with 4 updates ([#295](#295)) ([d8337b8](d8337b8)) * remove step-security/harden-runner from workflows ([#246](#246)) ([c5708d8](c5708d8)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: hve-core-release-please[bot] <254602402+hve-core-release-please[bot]@users.noreply.github.com>

WilliamBerryiii requested a review from a team as a code owner January 21, 2026 02:01

Copilot AI review requested due to automatic review settings January 21, 2026 02:01

Copilot started reviewing on behalf of WilliamBerryiii January 21, 2026 02:02 View session

Copilot AI reviewed Jan 21, 2026

View reviewed changes

WilliamBerryiii added 2 commits January 20, 2026 18:34

Copilot AI review requested due to automatic review settings January 21, 2026 02:59

Copilot started reviewing on behalf of WilliamBerryiii January 21, 2026 02:59 View session

Merge remote-tracking branch 'origin/main' into feature/pester-testab…

f82d479

…ility-refactoring

Copilot AI reviewed Jan 21, 2026

View reviewed changes

WilliamBerryiii added 2 commits January 20, 2026 19:22

Copilot AI review requested due to automatic review settings January 21, 2026 03:28

Copilot started reviewing on behalf of WilliamBerryiii January 21, 2026 03:28 View session

WilliamBerryiii added 2 commits January 20, 2026 20:06

fix(build): add missing closing braces to test file

8fabbd1

- Invoke-PrReferenceGeneration Describe block was truncated - File ended without closing It block and Describe block braces 🔧 - Generated by Copilot

fix(build): handle detached HEAD in CI for branch detection

895e473

- add Get-CurrentBranchOrRef helper function - fall back to detached@<sha> when git branch --show-current returns empty - add unit tests for new function 🔧 - Generated by Copilot

WilliamBerryiii requested review from agreaves-ms, katriendg and kgmwang1 January 21, 2026 04:45

Copilot AI reviewed Jan 21, 2026

View reviewed changes

WilliamBerryiii requested a review from Copilot January 21, 2026 05:21

Copilot started reviewing on behalf of WilliamBerryiii January 21, 2026 05:22 View session

Copilot AI reviewed Jan 21, 2026

View reviewed changes

scripts/tests/Generate-PrReference.Tests.ps1 Outdated Show resolved Hide resolved

style(scripts): fix trailing whitespace in Generate-PrReference.Tests…

6c2742c

….ps1 🧹 - Generated by Copilot

Copilot AI reviewed Jan 21, 2026

View reviewed changes

katriendg approved these changes Jan 21, 2026

View reviewed changes

WilliamBerryiii merged commit d40e742 into main Jan 21, 2026
15 checks passed

WilliamBerryiii deleted the feature/pester-testability-refactoring branch January 21, 2026 17:39

hve-core-release-please bot mentioned this pull request Jan 21, 2026

chore(main): release hve-core 2.0.0 #212

Merged

WilliamBerryiii mentioned this pull request Jan 24, 2026

[Issue]: Refactor Package-Extension.ps1 entry point for testability #263

Closed

5 tasks

This was referenced Jan 28, 2026

chore(main): release hve-core 3.0.0 #341

Closed

chore(main): release hve-core 3.0.0 #417

Closed

This was referenced Feb 6, 2026

chore(main): release hve-core 3.0.0 #441

Closed

chore(main): release hve-core 3.0.0 #530

Closed

chore(main): release hve-core 3.0.0 #532

Closed

chore(main): release hve-core 3.0.0 #534

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor(scripts): extract pure functions for Pester testability#221

refactor(scripts): extract pure functions for Pester testability#221
WilliamBerryiii merged 9 commits intomainfrom
feature/pester-testability-refactoring

WilliamBerryiii commented Jan 21, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Jan 21, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

katriendg left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

WilliamBerryiii commented Jan 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changes by Script

Test Coverage

Related Issue(s)

Type of Change

Testing

Checklist

Required for all contributions

AI Artifact contributions

Required automated checks

Security Considerations

Uh oh!

github-actions bot commented Jan 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Dependency Review

Scanned Files

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

katriendg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

WilliamBerryiii commented Jan 21, 2026 •

edited

Loading

github-actions bot commented Jan 21, 2026 •

edited

Loading