Handle Process/Container not found errors and force exits#571
Merged
Handle Process/Container not found errors and force exits#571
Conversation
Contributor
jterry75
commented
Apr 17, 2019
- Fix panic on hcs/process.Close() with nil error
- Force HCS process exit on ERROR_NOT_FOUND
- Force UVM exit after 30 seconds of issuing SIGKILL
Signed-off-by: Justin Terry (VM) <juterry@microsoft.com>
Signed-off-by: Justin Terry (VM) <juterry@microsoft.com>
1. When a SIGKILL is sent to the init process we force the UVM exit after 30 seconds in order to make sure that whatever state the guest is in the exit is honored. Signed-off-by: Justin Terry (VM) <juterry@microsoft.com>
Contributor
Author
|
The GCS side: microsoft/opengcs#294 |
lowenna
reviewed
Apr 17, 2019
| // closing `he.p` and unblocking all waiters. | ||
| go func() { | ||
| // Give the HCS 1 second to finish and deliver the notification. | ||
| time.Sleep(1 * time.Second) |
Contributor
Author
There was a problem hiding this comment.
We have to wait because if we don't and this was a valid exit we wont be able to capture the proper exit code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.