This repository was archived by the owner on Jul 28, 2021. It is now read-only.
Fix errors returned by GCS to align with expectations in the HCS#294
Merged
Fix errors returned by GCS to align with expectations in the HCS#294
Conversation
Signed-off-by: Justin Terry (VM) <juterry@microsoft.com>
lowenna
reviewed
Apr 17, 2019
internal/runtime/hcsv2/process.go
Outdated
|
|
||
| // Kill sends 'signal' to the process. | ||
| // | ||
| // If the processes has already exited returns `gcserr.HrErrNotFound` by |
Contributor
|
Minor nit but LGTM |
lowenna
previously approved these changes
Apr 17, 2019
Signed-off-by: Justin Terry (VM) <juterry@microsoft.com>
1. When a container is not found the HCS expects a GCS to return an HRESULT error ERROR_VMCOMPUTE_SYSTEM_NOT_FOUND to indicate this condition. Signed-off-by: Justin Terry (VM) <juterry@microsoft.com>
…existing ID Signed-off-by: Justin Terry (VM) <juterry@microsoft.com>
Contributor
Author
|
@jhowardmsft - Made the change. Submitting. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
error ERROR_VMCOMPUTE_SYSTEM_NOT_FOUND to indicate this condition.