Validate runhcs sandbox isolation and platform#2473
Merged
helsaawy merged 1 commit intomicrosoft:mainfrom Jul 10, 2025
Merged
Conversation
anmaxvl
approved these changes
Jul 9, 2025
ambarve
approved these changes
Jul 10, 2025
Check that the OCI spec correctly identifies the OS and isolation type specified in the `"runhcsopts".Options`. Make `"oci".IsJobContainer` check if it is an WCOW pod, so spurious host process container annotations are ignored for LCOW. Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
anmaxvl
approved these changes
Jul 10, 2025
rzlink
added a commit
to rzlink/hcsshim
that referenced
this pull request
Mar 2, 2026
When runtime options are non-empty (e.g., SandboxIsolation is set) but
SandboxPlatform is empty, infer the platform from the OCI spec rather
than failing validation. This matches the existing behavior when options
are entirely empty.
containerd's default config (config_windows.go) sets SandboxIsolation=1
for the runhcs-wcow-hypervisor runtime handler but omits SandboxPlatform,
making options non-empty with an empty platform string. This causes
platforms.Parse("") to fail with 'invalid runtime sandbox platform'.
The OCI spec already contains sufficient information to determine the
platform: spec.Linux != nil indicates LCOW, while spec.Windows != nil
with spec.Linux == nil indicates WCOW.
Fixes the interaction between containerd's default runtime config and
hcsshim's strict validation added in PR microsoft#2473.
rzlink
added a commit
to rzlink/hcsshim
that referenced
this pull request
Mar 4, 2026
When runtime options are non-empty (e.g., SandboxIsolation is set) but
SandboxPlatform is empty, infer the platform from the OCI spec rather
than failing validation. This matches the existing behavior when options
are entirely empty.
containerd's default config (config_windows.go) sets SandboxIsolation=1
for the runhcs-wcow-hypervisor runtime handler but omits SandboxPlatform,
making options non-empty with an empty platform string. This causes
platforms.Parse("") to fail with 'invalid runtime sandbox platform'.
The OCI spec already contains sufficient information to determine the
platform: spec.Linux != nil indicates LCOW, while spec.Windows != nil
with spec.Linux == nil indicates WCOW.
Fixes the interaction between containerd's default runtime config and
hcsshim's strict validation added in PR microsoft#2473.
rzlink
added a commit
to rzlink/hcsshim
that referenced
this pull request
Mar 4, 2026
When runtime options are non-empty (e.g., SandboxIsolation is set) but
SandboxPlatform is empty, infer the platform from the OCI spec rather
than failing validation. This matches the existing behavior when options
are entirely empty.
containerd's default config (config_windows.go) sets SandboxIsolation=1
for the runhcs-wcow-hypervisor runtime handler but omits SandboxPlatform,
making options non-empty with an empty platform string. This causes
platforms.Parse("") to fail with 'invalid runtime sandbox platform'.
The OCI spec already contains sufficient information to determine the
platform: spec.Linux != nil indicates LCOW, while spec.Windows != nil
with spec.Linux == nil indicates WCOW.
Fixes the interaction between containerd's default runtime config and
hcsshim's strict validation added in PR microsoft#2473.
rzlink
added a commit
to rzlink/hcsshim
that referenced
this pull request
Mar 4, 2026
When runtime options are non-empty (e.g., SandboxIsolation is set) but
SandboxPlatform is empty, infer the platform from the OCI spec rather
than failing validation. This matches the existing behavior when options
are entirely empty.
containerd's default config (config_windows.go) sets SandboxIsolation=1
for the runhcs-wcow-hypervisor runtime handler but omits SandboxPlatform,
making options non-empty with an empty platform string. This causes
platforms.Parse("") to fail with 'invalid runtime sandbox platform'.
The OCI spec already contains sufficient information to determine the
platform: spec.Linux != nil indicates LCOW, while spec.Windows != nil
with spec.Linux == nil indicates WCOW.
Fixes the interaction between containerd's default runtime config and
hcsshim's strict validation added in PR microsoft#2473.
Signed-off-by: Dawei Wei <wei.dawei.cn@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check that the OCI spec correctly identifies the OS and isolation type specified in the
"runhcsopts".Options.Make
"oci".IsJobContainercheck if it is an WCOW pod, so spurious host process container annotations are ignored for LCOW.