Skip to content

Move use to avoid GC problem in GLMP#2

Merged
lowenna merged 1 commit intomasterfrom
glmp-use
Jul 1, 2015
Merged

Move use to avoid GC problem in GLMP#2
lowenna merged 1 commit intomasterfrom
glmp-use

Conversation

@lowenna
Copy link
Contributor

@lowenna lowenna commented Jul 1, 2015

Signed-off-by: John Howard jhoward@microsoft.com

Fixes GC collection issues over timing of use

Signed-off-by: John Howard <jhoward@microsoft.com>
lowenna pushed a commit that referenced this pull request Jul 1, 2015
Move use to avoid GC problem in GLMP
@lowenna lowenna merged commit 1efe3d0 into master Jul 1, 2015
@lowenna lowenna deleted the glmp-use branch July 2, 2015 16:07
darstahl added a commit that referenced this pull request May 2, 2018
Relative open to bound paths
dcantah added a commit that referenced this pull request Jul 15, 2021
This adds basic directory mount support for job containers. As any path on the host
is already accessible from the container, the concept of volume mounts is a bit funny
for job containers. However, it still makes sense to treat the volume mount point where
the container image is mounted as where most things should be found regarding the container.

The manner in which this is done is by appending the container mount path for the volume to
where the rootfs volume is mounted on the host and then symlinking it.

So:
Container rootfs volume path = "C:\C\123456789abcdefgh\"

Example #1
--------------
{
    "host_path": "C:\mydir"
    "container_path": "\dir\in\container"
}

"C:\mydir" would be symlinked to "C:\C\123456789abcdefgh\dir\in\container"

Example #2
---------------
Drive letters will be stripped
{
    "host_path": "C:\mydir"
    "container_path": "C:\dir\in\container"
}
"C:\mydir" would be symlinked to "C:\C\123456789abcdefgh\dir\in\container"

Signed-off-by: Daniel Canter <dcanter@microsoft.com>
princepereira pushed a commit to princepereira/hcsshim that referenced this pull request Aug 29, 2024
This adds basic directory mount support for job containers. As any path on the host
is already accessible from the container, the concept of volume mounts is a bit funny
for job containers. However, it still makes sense to treat the volume mount point where
the container image is mounted as where most things should be found regarding the container.

The manner in which this is done is by appending the container mount path for the volume to
where the rootfs volume is mounted on the host and then symlinking it.

So:
Container rootfs volume path = "C:\C\123456789abcdefgh\"

Example microsoft#1
--------------
{
    "host_path": "C:\mydir"
    "container_path": "\dir\in\container"
}

"C:\mydir" would be symlinked to "C:\C\123456789abcdefgh\dir\in\container"

Example microsoft#2
---------------
Drive letters will be stripped
{
    "host_path": "C:\mydir"
    "container_path": "C:\dir\in\container"
}
"C:\mydir" would be symlinked to "C:\C\123456789abcdefgh\dir\in\container"

Signed-off-by: Daniel Canter <dcanter@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant