Fix Hyper-V check in late clone spec comparisons#1400
Merged
dcantah merged 1 commit intomicrosoft:masterfrom May 17, 2022
Merged
Fix Hyper-V check in late clone spec comparisons#1400dcantah merged 1 commit intomicrosoft:masterfrom
dcantah merged 1 commit intomicrosoft:masterfrom
Conversation
In the function that handles checking if the cloned containers spec retrieved from the registry matches the current spec, it was comparing the hyperv field on the runtime spec using the != operator which won't work as the hyperv field is a pointer so it would just be comparing the addr. Swap to reflect.DeepEqual. This became an 'issue' as we set the hyperv field now if in our shim options SandboxIsolation is set to the HYPERVISOR option. This doesn't have much of an effect being set for containers that are going to be launched IN the UVM, so this is mostly just a bug that was surfaced from a field that didn't use to be set. This additionally changes to errors.New instead of fmt.Errorf where there was no formatting in the error. Signed-off-by: Daniel Canter <dcanter@microsoft.com>
helsaawy
approved these changes
May 17, 2022
Contributor
helsaawy
left a comment
There was a problem hiding this comment.
I feel like a having an auto-generated WindowsHyperV.Equal would make everything easier ...
ambarve
approved these changes
May 17, 2022
anmaxvl
added a commit
that referenced
this pull request
Feb 7, 2023
princepereira
pushed a commit
to princepereira/hcsshim
that referenced
this pull request
Aug 29, 2024
In the function that handles checking if the cloned containers spec retrieved from the registry matches the current spec, it was comparing the hyperv field on the runtime spec using the != operator which won't work as the hyperv field is a pointer so it would just be comparing the addr. Swap to reflect.DeepEqual. This became an 'issue' as we set the hyperv field now if in our shim options SandboxIsolation is set to the HYPERVISOR option. This doesn't have much of an effect being set for containers that are going to be launched IN the UVM, so this is mostly just a bug that was surfaced from a field that didn't use to be set. This additionally changes to errors.New instead of fmt.Errorf where there was no formatting in the error. Signed-off-by: Daniel Canter <dcanter@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the function that handles checking if the cloned containers spec retrieved from the registry matches the current spec, it was comparing the hyperv field on the runtime spec using the != operator. This won't work as the hyperv field is a pointer so it would just be comparing the address and not the contents.
This became an 'issue' as we set the hyperv field now if in our shim options the SandboxIsolation field is set to the HYPERVISOR option. This doesn't have much of an effect being set for containers that are going to be launched IN the UVM, so this is mostly just a bug that was surfaced from a field that didn't use to be set. This was causing the late clone spec comparisons to fail at the hyperv field, and thus the late clone tests.
This additionally changes to errors.New instead of fmt.Errorf where there was no formatting in the error.