Add Go bindflt/silo definitions#1331
Merged
dcantah merged 2 commits intomicrosoft:masterfrom Apr 4, 2022
Merged
Conversation
9a03287 to
5838c93
Compare
90f7760 to
c692952
Compare
jterry75
reviewed
Mar 17, 2022
jterry75
reviewed
Mar 17, 2022
jterry75
reviewed
Mar 17, 2022
2a96657 to
43cb3a5
Compare
dcantah
commented
Mar 21, 2022
helsaawy
approved these changes
Mar 23, 2022
Contributor
helsaawy
left a comment
There was a problem hiding this comment.
I wonder if we should move this stuff to go-winio, since it isnt really container related (but it isnt IO related either ...)
Contributor
Author
@kevpar and I had talked about this before. I think it makes sense to me at least |
Contributor
Author
|
Re-pushed as the CI was "stuck".. Edit: Back to regularly scheduled programming |
This change adds a couple Go bindings for calls and constants from bindfltapi.dll as well as some silo flags for job objects. Together these allow file bindings (think bind mounts on Linux) to be performed for a specific job object. The bindings are only viewable from processes within that specific job. This change additionally adds a couple unit tests for this behavior. Signed-off-by: Daniel Canter <dcanter@microsoft.com>
Contributor
Author
|
@microsoft/containerplat Anyone able to take a second gander? |
anmaxvl
reviewed
Apr 4, 2022
Return error on file binding if stating the directory fails. Signed-off-by: Daniel Canter <dcanter@microsoft.com>
anmaxvl
approved these changes
Apr 4, 2022
princepereira
pushed a commit
to princepereira/hcsshim
that referenced
this pull request
Aug 29, 2024
* Add Go bindflt/silo definitions This change adds a couple Go bindings for calls and constants from bindfltapi.dll as well as some silo flags for job objects. Together these allow file bindings (think bind mounts on Linux) to be performed for a specific job object. The bindings are only viewable from processes within that specific job. This additionally adds a couple unit tests for this behavior. Signed-off-by: Daniel Canter <dcanter@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds a couple Go bindings for calls and constants from bindfltapi.dll as well as some silo flags for job objects. Together these allow file bindings (think bind mounts on Linux) to be performed for a specific job object. The bindings
are only viewable from processes within that specific job.
This change additionally adds a couple unit tests for this behavior.