Add --ref-format option to scalar clone
#829
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add ability to run Git commands for Scalar by passing a struct strvec rather than having to use varargs. Signed-off-by: Matthew John Cheetham <mjcheetham@outlook.com>
dscho
previously approved these changes
Dec 17, 2025
Member
dscho
left a comment
There was a problem hiding this comment.
We will also need a corresponding PR for vfs-2.52.0, unfortunately.
derrickstolee
previously approved these changes
Dec 17, 2025
Add the `--ref-format` option to the `scalar clone` command. This will allow users to opt-in to creating a Scalar repository using alternative ref storage backends, such as reftable. Example: scalar clone --ref-format reftable $URL Signed-off-by: Matthew John Cheetham <mjcheetham@outlook.com>
616e5f7 to
2f1cd80
Compare
Member
Author
|
Member
Author
Actually.. I guess that we'll just want the 2.52 targeting PR, right? I only target 2.51.2 in this PR since it's the default branch still. |
Member
That would at least allow us to use |
derrickstolee
approved these changes
Dec 18, 2025
|
@mjcheetham: This is something that we could send upstream, too, right? |
Member
Yes!!! |
Member
|
I'll just merge this for good luck, too (already merged the corresponding #832). |
Copilot AI
added a commit
that referenced
this pull request
Jan 14, 2026
release-winget: use WINGET_CREATE_GITHUB_TOKEN environment variable According to the winget-create documentation, for CI/CD scenarios it is recommended to use the WINGET_CREATE_GITHUB_TOKEN environment variable to pass the token to wingetcreate.exe rather than the -t command-line flag. The concern is that command-line arguments might be logged in process listings, whereas environment variables are more secure as they are not typically exposed in such listings. This change: - Retrieves the token from Azure Key Vault directly into a variable using `az keyvault secret show` instead of downloading to a file - Sets the WINGET_CREATE_GITHUB_TOKEN environment variable - Removes the -t flag from the wingetcreate.exe submit command - Removes the need for the token.txt file Co-authored-by: dscho <127790+dscho@users.noreply.github.com>
Copilot AI
added a commit
that referenced
this pull request
Jan 14, 2026
release-winget: use WINGET_CREATE_GITHUB_TOKEN environment variable According to the winget-create documentation, for CI/CD scenarios it is recommended to use the WINGET_CREATE_GITHUB_TOKEN environment variable to pass the token to wingetcreate.exe rather than the -t command-line flag. The concern is that command-line arguments might be logged in process listings, whereas environment variables are more secure as they are not typically exposed in such listings. This change: - Retrieves the token from Azure Key Vault directly into the WINGET_CREATE_GITHUB_TOKEN environment variable using `az keyvault secret show` instead of downloading to a file - Removes the -t flag from the wingetcreate.exe submit command - Removes the need for the token.txt file Co-authored-by: dscho <127790+dscho@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the
--ref-formatoption to thescalar clonecommand. This will allow users to opt-in to creating a Scalar repository using alternative ref storage backends, such as reftable. Example:scalar clone --ref-format reftable $URL