gvfs: allow overriding core.gvfs#263
Merged
derrickstolee merged 1 commit intomicrosoft:vfs-2.26.1from Apr 15, 2020
Merged
Conversation
derrickstolee
added a commit
to derrickstolee/VFSForGit
that referenced
this pull request
Apr 15, 2020
See microsoft/git#263. Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
derrickstolee
added a commit
to derrickstolee/scalar
that referenced
this pull request
Apr 15, 2020
See microsoft/git#263. Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
This was referenced Apr 15, 2020
kewillford
approved these changes
Apr 15, 2020
Member
kewillford
left a comment
There was a problem hiding this comment.
Should we add a test for this?
Author
I initially thought that we shouldn't set global config in tests, but I see some examples in the test suite so I can adapt thos. |
We found a user who had set "core.gvfs = false" in their global config. This should not have been necessary, but it also should not have caused a problem. However, it did. The reason is that gvfs_load_config_value() is called from config.c when reading config key/value pairs from all the config files. The local config should override the global config, and this is done by config.c reading the global config first then reading the local config. However, our logic only allowed writing the core_gvfs variable once. Put the guards against multiple assignments of core_gvfs into gvfs_config_is_set() instead, because that will fix the problem _and_ keep multiple calls to gvfs_config_is_set() from slowing down. Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
2818984 to
5f21f29
Compare
derrickstolee
added a commit
to derrickstolee/VFSForGit
that referenced
this pull request
Apr 15, 2020
See microsoft/git#263. Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
derrickstolee
added a commit
to derrickstolee/scalar
that referenced
this pull request
Apr 15, 2020
See microsoft/git#263. Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
dscho
pushed a commit
that referenced
this pull request
May 20, 2020
We found a user who had set "core.gvfs = false" in their global config. This should not have been necessary, but it also should not have caused a problem. However, it did. The reason is that gvfs_load_config_value() is called from config.c when reading config key/value pairs from all the config files. The local config should override the global config, and this is done by config.c reading the global config first then reading the local config. However, our logic only allowed writing the core_gvfs variable once. Put the guards against multiple assignments of core_gvfs into gvfs_config_is_set() instead, because that will fix the problem _and_ keep multiple calls to gvfs_config_is_set() from slowing down.
dscho
pushed a commit
that referenced
this pull request
May 20, 2020
We found a user who had set "core.gvfs = false" in their global config. This should not have been necessary, but it also should not have caused a problem. However, it did. The reason is that gvfs_load_config_value() is called from config.c when reading config key/value pairs from all the config files. The local config should override the global config, and this is done by config.c reading the global config first then reading the local config. However, our logic only allowed writing the core_gvfs variable once. Put the guards against multiple assignments of core_gvfs into gvfs_config_is_set() instead, because that will fix the problem _and_ keep multiple calls to gvfs_config_is_set() from slowing down.
derrickstolee
pushed a commit
that referenced
this pull request
Jun 1, 2020
derrickstolee
pushed a commit
that referenced
this pull request
Jul 18, 2020
derrickstolee
pushed a commit
that referenced
this pull request
Jul 27, 2020
derrickstolee
pushed a commit
that referenced
this pull request
Jul 28, 2020
derrickstolee
pushed a commit
that referenced
this pull request
Oct 6, 2020
derrickstolee
pushed a commit
that referenced
this pull request
Oct 6, 2020
dscho
added a commit
that referenced
this pull request
Oct 6, 2020
derrickstolee
pushed a commit
that referenced
this pull request
Oct 9, 2020
derrickstolee
pushed a commit
that referenced
this pull request
Oct 9, 2020
derrickstolee
pushed a commit
that referenced
this pull request
Oct 16, 2020
derrickstolee
pushed a commit
that referenced
this pull request
Oct 19, 2020
mjcheetham
pushed a commit
that referenced
this pull request
Dec 15, 2020
mjcheetham
pushed a commit
that referenced
this pull request
Dec 15, 2020
dscho
added a commit
that referenced
this pull request
Dec 18, 2020
dscho
added a commit
that referenced
this pull request
Dec 24, 2020
dscho
added a commit
that referenced
this pull request
Mar 8, 2021
jeffhostetler
pushed a commit
that referenced
this pull request
Mar 15, 2021
jeffhostetler
pushed a commit
that referenced
this pull request
Mar 16, 2021
derrickstolee
pushed a commit
that referenced
this pull request
May 17, 2021
derrickstolee
pushed a commit
that referenced
this pull request
May 17, 2021
derrickstolee
pushed a commit
that referenced
this pull request
May 17, 2021
dscho
added a commit
that referenced
this pull request
May 21, 2021
dscho
added a commit
that referenced
this pull request
May 22, 2021
derrickstolee
pushed a commit
that referenced
this pull request
May 28, 2021
dscho
added a commit
that referenced
this pull request
Jun 2, 2021
dscho
added a commit
that referenced
this pull request
Jun 7, 2021
derrickstolee
pushed a commit
that referenced
this pull request
Aug 3, 2021
derrickstolee
pushed a commit
that referenced
this pull request
Aug 3, 2021
dscho
added a commit
that referenced
this pull request
Aug 5, 2021
derrickstolee
pushed a commit
that referenced
this pull request
Aug 9, 2021
derrickstolee
pushed a commit
that referenced
this pull request
Aug 12, 2021
derrickstolee
pushed a commit
that referenced
this pull request
Aug 17, 2021
derrickstolee
pushed a commit
that referenced
this pull request
Oct 30, 2021
derrickstolee
pushed a commit
that referenced
this pull request
Nov 4, 2021
derrickstolee
pushed a commit
that referenced
this pull request
Nov 10, 2021
derrickstolee
pushed a commit
that referenced
this pull request
Nov 15, 2021
ldennington
pushed a commit
to ldennington/git
that referenced
this pull request
Jan 12, 2022
Most of these were done in private before microsoft/git. However, the following pull requests modified the core feature: microsoft#85 microsoft#89 microsoft#91 microsoft#98 microsoft#243 microsoft#263 Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
ldennington
pushed a commit
to ldennington/git
that referenced
this pull request
Jan 19, 2022
Most of these were done in private before microsoft/git. However, the following pull requests modified the core feature: microsoft#85 microsoft#89 microsoft#91 microsoft#98 microsoft#243 microsoft#263 Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
ldennington
pushed a commit
to ldennington/git
that referenced
this pull request
Jan 20, 2022
Most of these were done in private before microsoft/git. However, the following pull requests modified the core feature: microsoft#85 microsoft#89 microsoft#91 microsoft#98 microsoft#243 microsoft#263 Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
ldennington
pushed a commit
to ldennington/git
that referenced
this pull request
Jan 20, 2022
Most of these were done in private before microsoft/git. However, the following pull requests modified the core feature: microsoft#85 microsoft#89 microsoft#91 microsoft#98 microsoft#243 microsoft#263 Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
ldennington
pushed a commit
to ldennington/git
that referenced
this pull request
Jan 20, 2022
Most of these were done in private before microsoft/git. However, the following pull requests modified the core feature: microsoft#85 microsoft#89 microsoft#91 microsoft#98 microsoft#243 microsoft#263 Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
ldennington
pushed a commit
to ldennington/git
that referenced
this pull request
Jan 20, 2022
Most of these were done in private before microsoft/git. However, the following pull requests modified the core feature: microsoft#85 microsoft#89 microsoft#91 microsoft#98 microsoft#243 microsoft#263 Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
ldennington
pushed a commit
to ldennington/git
that referenced
this pull request
Jan 25, 2022
Most of these were done in private before microsoft/git. However, the following pull requests modified the core feature: microsoft#85 microsoft#89 microsoft#91 microsoft#98 microsoft#243 microsoft#263 Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
dscho
added a commit
that referenced
this pull request
Feb 1, 2022
derrickstolee
pushed a commit
that referenced
this pull request
Jun 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We found a user who had set "core.gvfs = false" in their global
config. This should not have been necessary, but it also should not
have caused a problem. However, it did.
The reason is that gvfs_load_config_value() is called from config.c
when reading config key/value pairs from all the config files. The
local config should override the global config, and this is done by
config.c reading the global config first then reading the local
config. However, our logic only allowed writing the core_gvfs
variable once.
Put the guards against multiple assignments of core_gvfs into
gvfs_config_is_set() instead, because that will fix the problem
and keep multiple calls to gvfs_config_is_set() from slowing down.