trace2:gvfs:experiment Add experimental regions and data events to help diagnose checkout and reset perf problems#160
Merged
derrickstolee merged 4 commits intomicrosoft:vfs-2.22.0from Jul 24, 2019
Conversation
51d386d to
717d4f1
Compare
derrickstolee
approved these changes
Jul 23, 2019
|
@jeffhostetler looks like t9800 needs an adjustment to its check for tracing, which is annoying. |
dscho
approved these changes
Jul 23, 2019
unpack-trees.c
Outdated
Member
There was a problem hiding this comment.
It seems that sometimes, the experiments are prefixed with "exp", but sometimes not. Did you mean to prefix all of them in that manner, or was it intentional to do that only with some, but not others?
Author
There was a problem hiding this comment.
yeah, i've been inconsistent. i was using "exp" for things i consider really temporary while we gather some data for a release or 2. most of the other ones that have real categories, but have "experiment" in the commit message are things that i could keep and maybe upstream or could just drop. i'm trying to not flood the telemetry stream with things that may not be useful long term, but at the same time gather enough data for our immediate analysis needs.
Member
I don't know... that's a p4 test that seems to be flaky. I restarted the |
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Jeff Hostetler <jeffhost@microsoft.com>
Signed-off-by: Jeff Hostetler <jeffhost@microsoft.com>
Signed-off-by: Jeff Hostetler <jeffhost@microsoft.com>
…and report_tracking() Signed-off-by: Jeff Hostetler <jeffhost@microsoft.com>
717d4f1 to
8d2815d
Compare
Member
|
```
CC credential.o
config.c: In function 'git_parse_signed':
config.c:873:10: error: absolute value function 'labs' given an argument of type 'intmax_t' {aka 'long long int'} but has parameter of type 'long int' which may cause truncation of value [-Werror=absolute-value]
873 | uval = labs(val);
| ^~~~
config.c:875:21: error: absolute value function 'labs' given an argument of type 'intmax_t' {aka 'long long int'} but has parameter of type 'long int' which may cause truncation of value [-Werror=absolute-value]
CC csum-file.o
CC ctype.o
875 | if (uval > max || labs(val) > uval) {
| ^~~~
CC date.o
cc1.exe: all warnings being treated as errors
CC delta-islands.o
make: *** [Makefile:2383: config.o] Error 1
make: *** Waiting for unfinished jobs....
CC decorate.o
```
so many cross-plat things to keep in mind. :(
Indeed. Sorry about my mistake: I should have fixed this in
microsoft/git a lot earlier...
|
derrickstolee
added a commit
to derrickstolee/VFSForGit
that referenced
this pull request
Jul 24, 2019
Includes changes from: * microsoft/git#158 * microsoft/git#159 * microsoft/git#160 * microsoft/git#162 Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
derrickstolee
added a commit
to microsoft/VFSForGit
that referenced
this pull request
Jul 24, 2019
Includes changes from: * microsoft/git#158 (experimental tracing: trace threading and cache-tree extension) * microsoft/git#159 (experimental tracing: prime_cache_tree()) * microsoft/git#160 (experimental tracing: checkout and reset perf) * microsoft/git#162 (support building with GCC v9.x)
derrickstolee
pushed a commit
that referenced
this pull request
Jun 1, 2020
derrickstolee
pushed a commit
that referenced
this pull request
Jul 20, 2020
derrickstolee
pushed a commit
that referenced
this pull request
Jul 27, 2020
derrickstolee
pushed a commit
that referenced
this pull request
Jul 28, 2020
dscho
pushed a commit
that referenced
this pull request
Mar 8, 2021
jeffhostetler
added a commit
that referenced
this pull request
Mar 15, 2021
jeffhostetler
added a commit
that referenced
this pull request
Mar 16, 2021
derrickstolee
pushed a commit
that referenced
this pull request
May 17, 2021
derrickstolee
pushed a commit
that referenced
this pull request
May 17, 2021
derrickstolee
pushed a commit
that referenced
this pull request
May 17, 2021
dscho
pushed a commit
that referenced
this pull request
May 21, 2021
dscho
pushed a commit
that referenced
this pull request
May 22, 2021
derrickstolee
pushed a commit
that referenced
this pull request
May 28, 2021
dscho
pushed a commit
that referenced
this pull request
Jun 2, 2021
dscho
pushed a commit
that referenced
this pull request
Jun 7, 2021
derrickstolee
pushed a commit
that referenced
this pull request
Aug 3, 2021
derrickstolee
pushed a commit
that referenced
this pull request
Aug 3, 2021
dscho
pushed a commit
that referenced
this pull request
Aug 5, 2021
derrickstolee
pushed a commit
that referenced
this pull request
Aug 9, 2021
derrickstolee
pushed a commit
that referenced
this pull request
Aug 12, 2021
derrickstolee
pushed a commit
that referenced
this pull request
Aug 17, 2021
dscho
pushed a commit
that referenced
this pull request
Oct 30, 2021
derrickstolee
pushed a commit
that referenced
this pull request
Oct 30, 2021
derrickstolee
pushed a commit
that referenced
this pull request
Nov 4, 2021
derrickstolee
pushed a commit
that referenced
this pull request
Nov 10, 2021
derrickstolee
pushed a commit
that referenced
this pull request
Nov 15, 2021
ldennington
pushed a commit
to ldennington/git
that referenced
this pull request
Jan 12, 2022
Includes gvfs-specific commits from these pull requests: microsoft#158 microsoft#159 microsoft#160 microsoft#164 Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
ldennington
pushed a commit
to ldennington/git
that referenced
this pull request
Jan 19, 2022
Includes gvfs-specific commits from these pull requests: microsoft#158 microsoft#159 microsoft#160 microsoft#164 Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
ldennington
pushed a commit
to ldennington/git
that referenced
this pull request
Jan 20, 2022
Includes gvfs-specific commits from these pull requests: microsoft#158 microsoft#159 microsoft#160 microsoft#164 Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
ldennington
pushed a commit
to ldennington/git
that referenced
this pull request
Jan 20, 2022
Includes gvfs-specific commits from these pull requests: microsoft#158 microsoft#159 microsoft#160 microsoft#164 Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
ldennington
pushed a commit
to ldennington/git
that referenced
this pull request
Jan 20, 2022
Includes gvfs-specific commits from these pull requests: microsoft#158 microsoft#159 microsoft#160 microsoft#164 Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
ldennington
pushed a commit
to ldennington/git
that referenced
this pull request
Jan 20, 2022
Includes gvfs-specific commits from these pull requests: microsoft#158 microsoft#159 microsoft#160 microsoft#164 Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
ldennington
pushed a commit
to ldennington/git
that referenced
this pull request
Jan 25, 2022
Includes gvfs-specific commits from these pull requests: microsoft#158 microsoft#159 microsoft#160 microsoft#164 Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
dscho
pushed a commit
that referenced
this pull request
Feb 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add experimental regions and data events to help diagnose
performance problems in checkout and reset.
We may or may not choose to carry these changes forward in the future.