Add Icon support for macOS#645
Merged
amgleitman merged 9 commits intomicrosoft:masterfrom Apr 15, 2021
Merged
Conversation
Saadnajmi
approved these changes
Mar 15, 2021
apps/fluent-tester/package.json
Outdated
Comment on lines
-42
to
-45
| "@microsoft/react-native-svg-desktop": "^12.1.1", | ||
| "@react-native-menu/menu": "^0.1.2", | ||
| "@react-native-picker/picker": "^1.9.11", | ||
| "react-native-svg": "^11.0.0" |
Collaborator
There was a problem hiding this comment.
Does this technically effect win32 too? Just curious
Member
Author
There was a problem hiding this comment.
It probably would, so I think it'd probably be a good idea to do some extra validation on Windows. That being said, the fact that the CI fails as is worries me a bit, so probably a good thing to double check.
Collaborator
There was a problem hiding this comment.
I personally cloned the repo on my HP Z440 and followed the instructions on apps/win32 to run the test app. Your windows machine also doesn't need to be enlisted, it can be a personal one and the test app will still run. If you don't have a windows machine on hand easily, I can try helping with that. Done that for others before
chiuam
reviewed
Mar 16, 2021
apps/macos/src/Podfile
Outdated
| pod 'FluentUI-React-Native-Button', :path => '../../../packages/experimental/NativeButton/FluentUIReactNativeButton.podspec' | ||
| pod 'FluentUI-React-Native-Avatar', :path => '../../../packages/experimental/Avatar/FluentUIReactNativeAvatar.podspec' | ||
| pod 'RNCPicker', :path => '../../../node_modules/@react-native-picker/picker' | ||
| pod 'RNSVG', :path => '../../../node_modules/@microsoft/react-native-svg-desktop' |
Contributor
There was a problem hiding this comment.
Do we need to update the iOS podfile as well? I think iOS should use the same library since FluentTester pulls in 'react-native-svg-desktop' not 'react-native-svg'.
Collaborator
|
/azp run |
|
Pull request contains merge conflicts. |
Contributor
|
I just checked out your branch and tried to run the Win32 test app locally. It didn't boot correctly, a React LogBox Error came up (empty, not sure why). But this is why the CI Win32 E2E tests are failing - the Win32 app is not booting at all. |
chiuam
pushed a commit
to chiuam/fluentui-react-native
that referenced
this pull request
Apr 28, 2021
* Add macOS support * Add link to issue regarding direct SVG imports * Replace react-native-svg with @microsoft/react-native-svg-desktop * Use react-native-svg now that it supports macOS * Upgrade react-native-svg to 12.1.1-0 everywhere * Update macos podfile * Change files
HeyImChris
pushed a commit
that referenced
this pull request
May 11, 2021
* prototype * style gradient * componentize shimmer * prototype * style gradient * Android theme (#613) * initial android theme * mapped a lot of colors, updated readme, added to fluent-tester-app * Change files * removed unneccessary dependencies * added android typography * updated versioning, removed apple specific changes * making android-theme default for the platform * update fluent-tester dependency version... * resolving comments... * resolving more comments... Co-authored-by: Tushar Masane <tushar@AZH-NT-02.middleeast.corp.microsoft.com> * 📦 applying package updates ***NO_CI*** * Add repository link for @fluentui/react-native (#649) * Change files * Remove change file * Add repository link * Change files * Add a nil check to Avatar image property (#650) * Add a nil check to AvatarData image * Change files * Update Radio Button focus border style to be WCAG 2.1 compliant (#653) * Change files * Remove change file * Update radio button focus border style * Change files * Add the rainbow gradient border image test case to experimental avatar (#654) * Add the rainbow gradient test case * Change files * Add apple theme static libraries to NuGet package (#655) * Add apple theme static libraries to NuGet, add NuGet Publish PR job * Fix path in nuspec * Comment out NugetPublish PR Job * Fix npm publish pipeline (hopefully) (#656) * fix typos in android-theme * Change files * 📦 applying package updates ***NO_CI*** * Android Svg Support (#652) * added svg, transformer to android * base64 svgs do not load, font files do not link * Change files * bump package versions manually * Change files * upgrade react-native-svg * Change files * revert 'bump package versions manually' * Change files * 📦 applying package updates ***NO_CI*** * Fix typo in nuspec (#659) * Fix typo in nuspec * Comment out NuGet Publish again * Add Icon support for macOS (#645) * Add macOS support * Add link to issue regarding direct SVG imports * Replace react-native-svg with @microsoft/react-native-svg-desktop * Use react-native-svg now that it supports macOS * Upgrade react-native-svg to 12.1.1-0 everywhere * Update macos podfile * Change files * 📦 applying package updates ***NO_CI*** * chore: `rnx-start` is deprecated (#660) `rnx-start` is being removed because it currently does not provide any value over vanilla `react-native start`. See microsoft/rnx-kit#139 * Fix more typos in the nuspec (#661) * Fix typos, uncomment pipeline * comment out pipeline again * Revamp Android ThemePicker (#664) * updated themepicker for android * Change files * add correct picker... * ignore rn-picker depcheck... * separated android themepicker... * added dropdown styles... * add types for dropdown.. * Add a Contributing markdown file (#555) * Initial Commit * Restructuring * Rewrite Slots summary * Update Guide based on feedback * More fixes * Update from PR feedback * Add RNSVG dependency to Icon and update RNSVG version throughout (#668) * Add button icon tests specific to win32 * Change files * Change files * Add dependency to rnsvg * Add RNSVG dependency to ios and mac * Remove rnsvg dep from ios and macos due to failed depcheck * Add rnsvg to ios and macos againt but also add to ignores for depcheck * Add explicit react-native-svg dependency to FURN Icon (#666) * Add direct dependency on RNSVG in FURN Icon * Change files * Update yarn.lock with react-native-svg 12.1.1 * componentize shimmer * move shimmer to experimental * create slots for shapes * revamp shimmer slots * implement shimmerElement to group sub-elements * Change files * add shimmer to android and accessibility support * use useRef hook and union types * remove rect & circle slots * documentation Co-authored-by: Tushar Anil Masane <tamasane@gmail.com> Co-authored-by: Tushar Masane <tushar@AZH-NT-02.middleeast.corp.microsoft.com> Co-authored-by: UI-Fabric-RN-Bot <uifrnbot@microsoft.com> Co-authored-by: Krystal Siler <krsiler@microsoft.com> Co-authored-by: Saad Najmi <saadnajmi2@gmail.com> Co-authored-by: Adam Gleitman <adam.gleitman@gmail.com> Co-authored-by: Tommy Nguyen <4123478+tido64@users.noreply.github.com> Co-authored-by: warren-ms <63264034+warren-ms@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Platforms Impacted
Description of changes
This adds Icon support for macOS using the recently published @microsoft/react-native-svg-desktop fork.
Verification
Validated via the test page. Things work on macOS, and there are no changes to iOS.
Pull request checklist
This PR has considered (when applicable):