Merged
Conversation
Collaborator
|
This will be blocked by #3376 as an FYI |
rurikoaraki
reviewed
Apr 3, 2024
Collaborator
|
FYI #3544 added a few more packages to dep profiles. |
Collaborator
|
For the macOS error, looks like codegen doesn't like the object iOS error I have never seen before 😕 , If we do |
Saadnajmi
reviewed
Apr 4, 2024
Collaborator
|
The Android issue might be solved by updating the Android test app. Whenever RNTA makes updates to the template files, we don't automatically get them, unless we run |
rurikoaraki
approved these changes
Apr 11, 2024
rurikoaraki
reviewed
Apr 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mostly package version bumps.
In 0.72 react-native-windows was not exporting its type info correctly, so the window type adapters were just using RN's types. Now they are more complete. With 0.73, react-native-windows is more correctly exporting its TS types, which requires updates to our adapter types. Now that we have both windows and win32 types in the adapters, it more clearly shows some of the inconsistencies between the two platforms which we should work to reduce.