Skip to content

[CI] Update to Xcode 15.2#3376

Merged
Saadnajmi merged 13 commits intomainfrom
Saadnajmi-patch-3
Apr 3, 2024
Merged

[CI] Update to Xcode 15.2#3376
Saadnajmi merged 13 commits intomainfrom
Saadnajmi-patch-3

Conversation

@Saadnajmi
Copy link
Collaborator

@Saadnajmi Saadnajmi commented Jan 20, 2024

Platforms Impacted

  • iOS
  • macOS
  • win32 (Office)
  • windows
  • android

Description of changes

Update our CI to Xcode 15.2 and macOS-13 images. Unfortunately, this means disabling the iOS E2E tests as they continue to fail (simulator won't boot) and I haven't found a resolution.

Verification

CI should pass

Pull request checklist

This PR has considered (when applicable):

  • Automated Tests
  • Documentation and examples
  • Keyboard Accessibility
  • Voiceover
  • Internationalization and Right-to-left Layouts

@Saadnajmi Saadnajmi requested a review from a team as a code owner January 20, 2024 13:30
@Saadnajmi
Copy link
Collaborator Author

@rurikoaraki @tido64 I confirmed from #3499 that it's not macOS 13 or Xcode 15 that is the problem, but the Azure Devops public image pools for macos-12 and macos-13. I'm not sure why still, if I had to assume. probably something to do with SIP. I've also mostly confirmed that we don't have many alternative pools we can use for macOS images (@dannyvv fyi). So my thoughts are as follows:

  • Dig deeper into why iOS E2E tests specifically fail on these images
  • Run a test to see if the GitHub Action images do allow the E2E tests to pass
  • Keep folllowing through to see if we can get a different pool to use (I doubt this one).

@Saadnajmi
Copy link
Collaborator Author

@rurikoaraki @tido64 I confirmed from #3499 that it's not macOS 13 or Xcode 15 that is the problem, but the Azure Devops public image pools for macos-12 and macos-13. I'm not sure why still, if I had to assume. probably something to do with SIP. I've also mostly confirmed that we don't have many alternative pools we can use for macOS images (@dannyvv fyi). So my thoughts are as follows:

  • Dig deeper into why iOS E2E tests specifically fail on these images
  • Run a test to see if the GitHub Action images do allow the E2E tests to pass
  • Keep folllowing through to see if we can get a different pool to use (I doubt this one).

EDIT:

By increasing timeouts it seems to be working now. So actually... I think the new VMs were just that much slower........ 🤦

@Saadnajmi
Copy link
Collaborator Author

OK, post FHL update #2:

Between this PR and #3499 , I think I've only had like.. 2 of 10 successful runs with iOS E2E tests. I'm pretty sure it's because with the newer VMs, they are much more hardware constrained and the iOS simulator launches much slower. Even when it passes, the total job takes ~1-1.5 hours, rather then the ~30 minutes it takes currently. Given that, I feel uneasy "upgrading" as it would be a devX decrease. I think my next test would be to rewrite the job in GitHub Actions, and see if that pool is any better (I suspect much better, and also macOS 14). @rurikoaraki @tido64 FYI. Also I'm not sure if React Native 0.73 requires Xcode 15, but this will eventually become blocking. React Native macOS most likely does.

@tido64
Copy link
Member

tido64 commented Mar 18, 2024

FWIW, 0.73 does require Xcode 15. I tried compiling it with Xcode 14 when I was debugging the visionOS condition and it did not like it at all.

@Saadnajmi
Copy link
Collaborator Author

FWIW, 0.73 does require Xcode 15. I tried compiling it with Xcode 14 when I was debugging the visionOS condition and it did not like it at all.

OK. That makes this PR part of the 0.73 effort, and now a much higher priority :D

@Saadnajmi Saadnajmi mentioned this pull request Apr 3, 2024
@Saadnajmi Saadnajmi enabled auto-merge (squash) April 3, 2024 20:25
@Saadnajmi Saadnajmi merged commit 4c95aae into main Apr 3, 2024
@Saadnajmi Saadnajmi deleted the Saadnajmi-patch-3 branch April 3, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants