Skip to content

[iOS] Fix warning in iOS 17#2214

Merged
mischreiber merged 1 commit intomicrosoft:mainfrom
mischreiber:letAllowOSHint
Sep 25, 2025
Merged

[iOS] Fix warning in iOS 17#2214
mischreiber merged 1 commit intomicrosoft:mainfrom
mischreiber:letAllowOSHint

Conversation

@mischreiber
Copy link
Copy Markdown
Collaborator

@mischreiber mischreiber commented Sep 25, 2025

Platforms Impacted

  • iOS
  • visionOS
  • macOS

Description of changes

#2211 caused a new warning ("Variable allowOSHint was never mutated, consider changing to let constant"), which our current tooling does not catch. That should be fixed, but in the meantime this at least fixes the warning.

Verification

Code builds with no warnings.

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • iPad Pointer interaction
  • SwiftUI consumption (validation or new demo scenarios needed)
  • Objective-C exposure (provide it only if needed)
Microsoft Reviewers: Open in CodeFlow

@mischreiber mischreiber requested a review from a team as a code owner September 25, 2025 03:05
@mischreiber mischreiber enabled auto-merge (squash) September 25, 2025 03:05
@nodes11
Copy link
Copy Markdown
Contributor

nodes11 commented Sep 25, 2025

Just for clarity, was the warning seen "Variable allowOSHint was never mutated, consider changing to let constant"?

@mischreiber mischreiber merged commit 6063df1 into microsoft:main Sep 25, 2025
7 checks passed
@mischreiber mischreiber deleted the letAllowOSHint branch September 25, 2025 21:16
@joannaquu joannaquu mentioned this pull request Oct 23, 2025
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants