Skip to content

Move color tokens out of common#2170

Merged
mischreiber merged 5 commits intomicrosoft:mainfrom
mischreiber:moveColorTokensOutOfCommon
Jun 2, 2025
Merged

Move color tokens out of common#2170
mischreiber merged 5 commits intomicrosoft:mainfrom
mischreiber:moveColorTokensOutOfCommon

Conversation

@mischreiber
Copy link
Copy Markdown
Collaborator

@mischreiber mischreiber commented May 30, 2025

Platforms Impacted

  • iOS
  • visionOS
  • macOS

Description of changes

Follow-up to #2165 and #2168 -- moving our system to treat iOS tokens as the same level of importance as macOS. Both now need to be provided by PlatformThemeProviding.

visionOS continues to be special, and lives on as an add-on to iOS.

Verification

Validated alias tokens load as expected in light and dark modes, and appear in components as expected.

Visual Verification
Dark Light
macOS_light macOS_dark
visionOS n/a
iOS_dark iOS_light

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • iPad Pointer interaction
  • SwiftUI consumption (validation or new demo scenarios needed)
  • Objective-C exposure (provide it only if needed)
Microsoft Reviewers: Open in CodeFlow

@mischreiber mischreiber requested a review from a team as a code owner May 30, 2025 21:20
@mischreiber mischreiber mentioned this pull request May 30, 2025
3 tasks
@mischreiber mischreiber merged commit 998b5bc into microsoft:main Jun 2, 2025
7 checks passed
@mischreiber mischreiber deleted the moveColorTokensOutOfCommon branch June 2, 2025 22:57
@mischreiber mischreiber mentioned this pull request Jun 13, 2025
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants