Skip to content

[macOS] Alias token improvments on macOS#2165

Merged
mischreiber merged 4 commits intomicrosoft:mainfrom
mischreiber:macOSAliasTokens
May 28, 2025
Merged

[macOS] Alias token improvments on macOS#2165
mischreiber merged 4 commits intomicrosoft:mainfrom
mischreiber:macOSAliasTokens

Conversation

@mischreiber
Copy link
Copy Markdown
Collaborator

@mischreiber mischreiber commented May 27, 2025

Platforms Impacted

  • iOS
  • visionOS
  • macOS

Description of changes

A few changes to improve the experience of using Alias Tokens on macOS.

  • Create a new PlatformThemeProviding protocol to let macOS supply its own alias token values
  • Move visionOS to use this new protocol for its existing overrides
  • Move some platform-agnostic ViewModifier functions into FluentUI_common
  • Create a new AliasColorTokens demo view
  • Add visionOS support to the new Demo app

Verification

Verified that override colors are implemented correctly on macOS and visionOS.

Visual Verification
Dark Light
macOS_dark macOS_light
visionOS n/a
iOS_dark iOS_light

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • iPad Pointer interaction
  • SwiftUI consumption (validation or new demo scenarios needed)
  • Objective-C exposure (provide it only if needed)
Microsoft Reviewers: Open in CodeFlow

@mischreiber mischreiber marked this pull request as ready for review May 27, 2025 22:28
@mischreiber mischreiber requested a review from a team as a code owner May 27, 2025 22:28
@joannaquu
Copy link
Copy Markdown
Contributor

vision foreground[2-3] should be white, how come it's showing up as the iOS grey?

@mischreiber
Copy link
Copy Markdown
Collaborator Author

vision foreground[2-3] should be white, how come it's showing up as the iOS grey?

Ah sorry, wrong screenshot. Updated with the correct image!

@mischreiber mischreiber merged commit 6e78444 into microsoft:main May 28, 2025
7 checks passed
@mischreiber mischreiber deleted the macOSAliasTokens branch May 28, 2025 17:13
@mischreiber mischreiber mentioned this pull request May 30, 2025
12 tasks
@mischreiber mischreiber mentioned this pull request Jun 13, 2025
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants