Skip to content

Update ccb label/icon in updateState#2164

Merged
joannaquu merged 4 commits intomicrosoft:mainfrom
joannaquu:joannaqu/fix-ccb-label
May 27, 2025
Merged

Update ccb label/icon in updateState#2164
joannaquu merged 4 commits intomicrosoft:mainfrom
joannaquu:joannaqu/fix-ccb-label

Conversation

@joannaquu
Copy link
Copy Markdown
Contributor

@joannaquu joannaquu commented May 27, 2025 •
edited by microsoft-github-policy-service bot
Loading

Platforms Impacted

  • iOS
  • visionOS
  • macOS

Description of changes

Currently, CommandBarButton sets its title/icon once in its init and never again. Move it to updateState to handle updates after init.

Verification

Visual Verification
Before After
before after

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • iPad Pointer interaction
  • SwiftUI consumption (validation or new demo scenarios needed)
  • Objective-C exposure (provide it only if needed)
Microsoft Reviewers: Open in CodeFlow

@joannaquu joannaquu requested a review from a team as a code owner May 27, 2025 17:10
@joannaquu joannaquu linked an issue May 27, 2025 that may be closed by this pull request
Restore missing testChangeTextStyleButton() XCUITest #2163
Closed
nodes11
nodes11 reviewed May 27, 2025
View reviewed changes
@joannaquu joannaquu merged commit 1df2e45 into microsoft:main May 27, 2025
12 of 19 checks passed
@joannaquu joannaquu deleted the joannaqu/fix-ccb-label branch May 27, 2025 22:53
joannaquu added a commit to joannaquu/fluentui-apple that referenced this pull request May 27, 2025
@joannaquu
Update ccb label/icon in updateState (microsoft#2164)
38dc3b7 
* update label/icon every time

* pr update

* turn xcuitest back on
joannaquu added a commit that referenced this pull request May 28, 2025
@joannaquu
Update ccb label/icon in updateState (#2164) (#2166)
d2d2a62 
* update label/icon every time

* pr update

* turn xcuitest back on
@mischreiber mischreiber mentioned this pull request Jun 13, 2025
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mischreiber mischreiber mischreiber approved these changes

@nodes11 nodes11 nodes11 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Restore missing testChangeTextStyleButton() XCUITest

3 participants

@joannaquu @mischreiber @nodes11