Skip to content

[WIP] Add CommandBarItemGroup labels#2143

Merged
joannaquu merged 2 commits intomicrosoft:mainfrom
joannaquu:joannaqu/ccb-labels
Apr 17, 2025
Merged

[WIP] Add CommandBarItemGroup labels#2143
joannaquu merged 2 commits intomicrosoft:mainfrom
joannaquu:joannaqu/ccb-labels

Conversation

@joannaquu
Copy link
Copy Markdown
Contributor

@joannaquu joannaquu commented Apr 14, 2025 •
edited by microsoft-github-policy-service bot
Loading

Platforms Impacted

  • iOS
  • visionOS
  • macOS

Description of changes

Adding support for CommandBarItemGroup labels

  • Update CommandBarItemGroup, which is currently a typealias ([CommandBarItem]) to be a class that takes in a list of items and a label
  • CommandBarButton: prevent buttons from stretching for long labels
  • CommandBarButtonGroupView: add a stack view that contains buttons + label
    • In this stack view, the label should only take the vertical space it needs. The buttons should fill the remaining space

Note: this work is experimental

Verification

Visual Verification
Before After
before after

(This is just an example of labels. CommandBarDemoController has not been updated)

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • iPad Pointer interaction
  • SwiftUI consumption (validation or new demo scenarios needed)
  • Objective-C exposure (provide it only if needed)
Microsoft Reviewers: Open in CodeFlow

@joannaquu joannaquu added the API break This PR introduces a breaking API change label Apr 14, 2025
@joannaquu joannaquu requested a review from a team as a code owner April 14, 2025 23:52
mischreiber
mischreiber reviewed Apr 15, 2025
View reviewed changes
@joannaquu joannaquu force-pushed the joannaqu/ccb-labels branch from 52bb2cf to dd7053b Compare April 16, 2025 20:06
@joannaquu joannaquu force-pushed the joannaqu/ccb-labels branch from dd7053b to 1fc57ee Compare April 16, 2025 20:22
@joannaquu joannaquu requested a review from a team as a code owner April 16, 2025 21:58
@mischreiber mischreiber self-assigned this Apr 17, 2025
@mischreiber mischreiber requested review from a team April 17, 2025 16:45
@joannaquu joannaquu merged commit 7e5efea into microsoft:main Apr 17, 2025
7 checks passed
@joannaquu joannaquu deleted the joannaqu/ccb-labels branch April 17, 2025 19:09
@mischreiber mischreiber mentioned this pull request Jun 13, 2025
Merged
12 tasks
joannaquu added a commit to joannaquu/fluentui-apple that referenced this pull request Oct 21, 2025
@joannaquu
Revert "[WIP] Add CommandBarItemGroup labels (microsoft#2143)"
5961a06 
This reverts commit 7e5efea.
joannaquu added a commit to joannaquu/fluentui-apple that referenced this pull request Oct 22, 2025
@joannaquu
Revert "[WIP] Add CommandBarItemGroup labels (microsoft#2143)"
3888c19 
This reverts commit 7e5efea.
joannaquu added a commit that referenced this pull request Oct 22, 2025
@joannaquu
Fully remove CommandBar label (#2224)
a97585d 
* Revert "[WIP] Add CommandBarItemGroup labels (#2143)"

This reverts commit 7e5efea.

* cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mischreiber mischreiber mischreiber approved these changes

Assignees

@mischreiber mischreiber

Labels

API break This PR introduces a breaking API change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@joannaquu @mischreiber