[iOS] Removing Avatar activity clip and ShapeCutout#2128
Merged
mischreiber merged 1 commit intomicrosoft:mainfrom Feb 7, 2025
Merged
[iOS] Removing Avatar activity clip and ShapeCutout#2128mischreiber merged 1 commit intomicrosoft:mainfrom
mischreiber merged 1 commit intomicrosoft:mainfrom
Conversation
joannaquu
approved these changes
Feb 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Platforms Impacted
Description of changes
We still have some vestigial code for creating a clipping for
Avatarpresence and activity badges. This clipping has been hidden away since #2081 but the code was never fully removed. Unfortunately, it can cause some visual artifacting in certain UIKit-based clients running under RTL, so let's take this opportunity to remove it entirely.Binary change
TBA
Verification
Ensured that
Avatarcutouts and badges look correct across various sizes, in both light and dark mode.Visual Verification
Pull request checklist
This PR has considered:
Microsoft Reviewers: Open in CodeFlow