Skip to content

[iOS] Removing Avatar activity clip and ShapeCutout#2128

Merged
mischreiber merged 1 commit intomicrosoft:mainfrom
mischreiber:RemoveAvatarActivityCutout
Feb 7, 2025
Merged

[iOS] Removing Avatar activity clip and ShapeCutout#2128
mischreiber merged 1 commit intomicrosoft:mainfrom
mischreiber:RemoveAvatarActivityCutout

Conversation

@mischreiber
Copy link
Copy Markdown
Collaborator

@mischreiber mischreiber commented Feb 7, 2025

Platforms Impacted

  • iOS
  • visionOS
  • macOS

Description of changes

We still have some vestigial code for creating a clipping for Avatar presence and activity badges. This clipping has been hidden away since #2081 but the code was never fully removed. Unfortunately, it can cause some visual artifacting in certain UIKit-based clients running under RTL, so let's take this opportunity to remove it entirely.

Binary change

TBA

Verification

Ensured that Avatar cutouts and badges look correct across various sizes, in both light and dark mode.

Visual Verification
Dark Light
Simulator Screenshot - iPhone 16 Pro - 2025-02-07 at 10 39 36 Simulator Screenshot - iPhone 16 Pro - 2025-02-07 at 10 39 34
Simulator Screenshot - iPhone 16 Pro - 2025-02-07 at 10 39 43 Simulator Screenshot - iPhone 16 Pro - 2025-02-07 at 10 39 44
Simulator Screenshot - iPhone 16 Pro - 2025-02-07 at 10 40 00 Simulator Screenshot - iPhone 16 Pro - 2025-02-07 at 10 39 58

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • iPad Pointer interaction
  • SwiftUI consumption (validation or new demo scenarios needed)
  • Objective-C exposure (provide it only if needed)
Microsoft Reviewers: Open in CodeFlow

@mischreiber mischreiber requested a review from a team as a code owner February 7, 2025 18:43
@mischreiber mischreiber enabled auto-merge (squash) February 7, 2025 18:46
@mischreiber mischreiber merged commit 41127a9 into microsoft:main Feb 7, 2025
@mischreiber mischreiber deleted the RemoveAvatarActivityCutout branch February 7, 2025 19:03
@joannaquu joannaquu mentioned this pull request Apr 4, 2025
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants