New Avatar API: hasBackgroundOutline#2081
Merged
mischreiber merged 2 commits intomicrosoft:mainfrom Aug 3, 2024
Merged
Conversation
joannaquu
reviewed
Aug 2, 2024
joannaquu
approved these changes
Aug 2, 2024
12 tasks
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Platforms Impacted
Description of changes
Adding a new API for
AvatarandAvatarGroupthat optionally renders an outline around theAvatarinstances with the Fluent background color.This is the same color (and the same logic) that is used when drawing a ring around the
Avatar. Useful for when the control is being rendered atop a dark or complicated background, such as a photo.As an addendum, this change also brings formal deprecation to the
isTransparentproperty ofAvatar. This is from a very old version of the Fluent spec, and should not be used anymore. The default value has been changed tofalse, and will be fully removed in a future version of Fluent.Binary change
Total increase: 31,000 bytes
Total decrease: 0 bytes
Full breakdown
Verification
Verified enabling and disabling the value in both UIKit and SwiftUI.
Visual Verification
Pull request checklist
This PR has considered:
Microsoft Reviewers: Open in CodeFlow