Skip to content

Fixed typo in podspec in resource cleanup step#2124

Merged
mischreiber merged 4 commits intomicrosoft:mainfrom
cyberscorpion:user/rajatjain/build-fix-patch-1
Feb 11, 2025
Merged

Fixed typo in podspec in resource cleanup step#2124
mischreiber merged 4 commits intomicrosoft:mainfrom
cyberscorpion:user/rajatjain/build-fix-patch-1

Conversation

@cyberscorpion
Copy link
Copy Markdown
Contributor

@cyberscorpion cyberscorpion commented Feb 6, 2025 •
edited by microsoft-github-policy-service bot
Loading

Fixing CI pipeline build issue

Platforms Impacted

  • iOS
  • visionOS
  • macOS

Description of changes

Fixing CI pipeline build issue.
Error: ❌ error: Cycle inside a single target; building could produce unreliable results.

Binary change

(how is our binary size impacted -- see https://github.com/microsoft/fluentui-apple/wiki/Size-Comparison)

Verification

Tested building CI pipeline for the project

Visual Verification No change

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • iPad Pointer interaction
  • SwiftUI consumption (validation or new demo scenarios needed)
  • Objective-C exposure (provide it only if needed)
Microsoft Reviewers: Open in CodeFlow

@cyberscorpion
Fixing CI pipeline build issue
1a52594 
Fixing CI pipeline build issue
@cyberscorpion cyberscorpion requested a review from a team as a code owner February 6, 2025 06:51
thomasjross
thomasjross reviewed Feb 6, 2025
View reviewed changes
@cyberscorpion cyberscorpion changed the title Fixing CI pipeline build issue Fixed typo in podspec in resource cleanup step Feb 11, 2025
@mischreiber mischreiber merged commit c7f0c7f into microsoft:main Feb 11, 2025
@cyberscorpion cyberscorpion deleted the user/rajatjain/build-fix-patch-1 branch February 11, 2025 04:29
mischreiber pushed a commit to mischreiber/fluentui-apple that referenced this pull request Feb 11, 2025
@cyberscorpion @mischreiber
Fixed typo in podspec in resource cleanup step (microsoft#2124)
2b2e443 
* Fixing CI pipeline build issue

Fixing CI pipeline build issue

* Updating variable names
mischreiber pushed a commit to mischreiber/fluentui-apple that referenced this pull request Feb 11, 2025
@cyberscorpion @mischreiber
Fixed typo in podspec in resource cleanup step (microsoft#2124)
281d4c2 
* Fixing CI pipeline build issue

Fixing CI pipeline build issue

* Updating variable names
mischreiber added a commit that referenced this pull request Feb 11, 2025
@mischreiber @cyberscorpion
Fixed typo in podspec in resource cleanup step (#2124) (#2130)
94686f0 
* Fixing CI pipeline build issue

Fixing CI pipeline build issue

* Updating variable names

Co-authored-by: Rajat Jain <mznrajatjain@gmail.com>
mischreiber added a commit that referenced this pull request Feb 11, 2025
@mischreiber @cyberscorpion
Fixed typo in podspec in resource cleanup step (#2124) (#2129)
9c6a501 
* Fixing CI pipeline build issue

Fixing CI pipeline build issue

* Updating variable names

Co-authored-by: Rajat Jain <mznrajatjain@gmail.com>
@joannaquu joannaquu mentioned this pull request Apr 4, 2025
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anandrajeswaran anandrajeswaran anandrajeswaran approved these changes

@joannaquu joannaquu joannaquu approved these changes

+1 more reviewer

@thomasjross thomasjross thomasjross approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@cyberscorpion @thomasjross @anandrajeswaran @joannaquu @mischreiber