feat(workspace-plugin): various executor fixes and inferred ws plugin configuration capabilities#33098
Merged
Hotell merged 12 commits intomicrosoft:masterfrom Oct 23, 2024
Conversation
…js extension emit within build executor
…n generate-api executor, to properly turn off path aliases
… within verify-packaging executor
…in type-check executor, to properly turn off path aliases
…tor to properly resolve aliases during griffel transform
…p/context within inferred plugin
Collaborator
📊 Bundle size report✅ No changes found |
Hotell
commented
Oct 22, 2024
This was referenced Oct 22, 2024
dmytrokirpa
approved these changes
Oct 23, 2024
| // extend @swc/core types by missing apis | ||
| declare module '@swc/core' { | ||
| interface BaseModuleConfig { | ||
| resolveFully?: boolean; |
Contributor
There was a problem hiding this comment.
Should we create a new issue/PR for @swc/core or @swc/types to fix this?
Contributor
Author
There was a problem hiding this comment.
we definitely should , ty
Contributor
Author
There was a problem hiding this comment.
Co-authored-by: Dmytro Kirpa <kirpadv@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
New Behavior
Features
Workspace inferred plugin 🧪
Targets build based on project context
following targets are added to project based on project configuration:
storybook(any project)startexecuting storybook ( v9 project in split mode "library/stories")Configuration options
becuase
testSSRandverifyPackagingtools have no physical configuration that we can infer from, we need to implement include/exclude options on plugin level.Now both target support:
include,exclude,targetNameExample:
Performance
--verbosemodeFixes
Build executor
.jsfile extensions to all relative import/export statement within built output to support native ESM within browser #32997transformFilewhich mirrors whatswc cliuses and resolves issues when using absolute pathssourceRootgenerationcwdin order to correctly resolve path aliases when executing@griffeltransformsassetsschema that was not reflecting the implementationType-check, Generate-api executor
baseUrlvia absolute path to properly turn off path aliasesVerify-packaging executor
Related Issue(s)