chore: migrate v9 and tools to nx inferred tasks#33074
Merged
Hotell merged 6 commits intomicrosoft:masterfrom Nov 4, 2024
Merged
chore: migrate v9 and tools to nx inferred tasks#33074Hotell merged 6 commits intomicrosoft:masterfrom
Hotell merged 6 commits intomicrosoft:masterfrom
Conversation
Collaborator
📊 Bundle size report
Unchanged fixtures
|
fabricteam
reviewed
Oct 17, 2024
Collaborator
🕵 FluentUIV0 No visual regressions between this PR and main |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 653 | 623 | 5000 | |
| Button | mount | 305 | 306 | 5000 | |
| Field | mount | 1150 | 1128 | 5000 | |
| FluentProvider | mount | 724 | 719 | 5000 | |
| FluentProviderWithTheme | mount | 84 | 89 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 40 | 36 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 89 | 81 | 10 | |
| MakeStyles | mount | 886 | 864 | 50000 | |
| Persona | mount | 1749 | 1708 | 5000 | |
| SpinButton | mount | 1405 | 1435 | 5000 | |
| SwatchPicker | mount | 1656 | 1682 | 5000 |
Collaborator
Perf Analysis (
|
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| ButtonMinimalPerf.default | 100 | 90 | 1.11:1 |
| ReactionMinimalPerf.default | 215 | 194 | 1.11:1 |
| PortalMinimalPerf.default | 89 | 81 | 1.1:1 |
| TreeWith60ListItems.default | 92 | 84 | 1.1:1 |
| SkeletonMinimalPerf.default | 212 | 196 | 1.08:1 |
| AvatarMinimalPerf.default | 114 | 107 | 1.07:1 |
| RefMinimalPerf.default | 113 | 106 | 1.07:1 |
| ToolbarMinimalPerf.default | 548 | 519 | 1.06:1 |
| ButtonSlotsPerf.default | 321 | 307 | 1.05:1 |
| ChatDuplicateMessagesPerf.default | 160 | 153 | 1.05:1 |
| ProviderMinimalPerf.default | 208 | 198 | 1.05:1 |
| AccordionMinimalPerf.default | 81 | 78 | 1.04:1 |
| AttachmentMinimalPerf.default | 88 | 85 | 1.04:1 |
| AttachmentSlotsPerf.default | 652 | 629 | 1.04:1 |
| ListWith60ListItems.default | 379 | 366 | 1.04:1 |
| TooltipMinimalPerf.default | 1276 | 1229 | 1.04:1 |
| GridMinimalPerf.default | 182 | 177 | 1.03:1 |
| ImageMinimalPerf.default | 226 | 220 | 1.03:1 |
| IconMinimalPerf.default | 382 | 371 | 1.03:1 |
| VideoMinimalPerf.default | 441 | 429 | 1.03:1 |
| HeaderMinimalPerf.default | 214 | 209 | 1.02:1 |
| ListNestedPerf.default | 332 | 324 | 1.02:1 |
| RadioGroupMinimalPerf.default | 269 | 263 | 1.02:1 |
| SegmentMinimalPerf.default | 199 | 195 | 1.02:1 |
| SliderMinimalPerf.default | 762 | 746 | 1.02:1 |
| TableMinimalPerf.default | 228 | 223 | 1.02:1 |
| TreeMinimalPerf.default | 490 | 479 | 1.02:1 |
| BoxMinimalPerf.default | 193 | 191 | 1.01:1 |
| ChatMinimalPerf.default | 438 | 433 | 1.01:1 |
| DropdownManyItemsPerf.default | 385 | 382 | 1.01:1 |
| DropdownMinimalPerf.default | 1475 | 1463 | 1.01:1 |
| InputMinimalPerf.default | 535 | 532 | 1.01:1 |
| ListCommonPerf.default | 393 | 388 | 1.01:1 |
| ListMinimalPerf.default | 307 | 305 | 1.01:1 |
| PopupMinimalPerf.default | 354 | 350 | 1.01:1 |
| ProviderMergeThemesPerf.default | 654 | 645 | 1.01:1 |
| CustomToolbarPrototype.default | 1475 | 1463 | 1.01:1 |
| AnimationMinimalPerf.default | 296 | 297 | 1:1 |
| CardMinimalPerf.default | 300 | 299 | 1:1 |
| DatepickerMinimalPerf.default | 3593 | 3599 | 1:1 |
| DialogMinimalPerf.default | 446 | 444 | 1:1 |
| FormMinimalPerf.default | 221 | 222 | 1:1 |
| ItemLayoutMinimalPerf.default | 709 | 710 | 1:1 |
| CarouselMinimalPerf.default | 266 | 268 | 0.99:1 |
| EmbedMinimalPerf.default | 1848 | 1858 | 0.99:1 |
| LayoutMinimalPerf.default | 198 | 199 | 0.99:1 |
| MenuButtonMinimalPerf.default | 942 | 952 | 0.99:1 |
| ButtonOverridesMissPerf.default | 640 | 654 | 0.98:1 |
| ChatWithPopoverPerf.default | 193 | 197 | 0.98:1 |
| LabelMinimalPerf.default | 214 | 218 | 0.98:1 |
| RosterPerf.default | 1554 | 1589 | 0.98:1 |
| SplitButtonMinimalPerf.default | 2226 | 2277 | 0.98:1 |
| StatusMinimalPerf.default | 395 | 404 | 0.98:1 |
| TextAreaMinimalPerf.default | 285 | 290 | 0.98:1 |
| DividerMinimalPerf.default | 203 | 209 | 0.97:1 |
| FlexMinimalPerf.default | 151 | 155 | 0.97:1 |
| HeaderSlotsPerf.default | 452 | 464 | 0.97:1 |
| TableManyItemsPerf.default | 1072 | 1103 | 0.97:1 |
| TextMinimalPerf.default | 187 | 192 | 0.97:1 |
| AlertMinimalPerf.default | 152 | 159 | 0.96:1 |
| CheckboxMinimalPerf.default | 1112 | 1156 | 0.96:1 |
| LoaderMinimalPerf.default | 180 | 187 | 0.96:1 |
| MenuMinimalPerf.default | 491 | 509 | 0.96:1 |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 631 | 640 | 5000 | |
| Breadcrumb | mount | 1715 | 1700 | 1000 | |
| Checkbox | mount | 1687 | 1747 | 5000 | |
| CheckboxBase | mount | 1508 | 1503 | 5000 | |
| ChoiceGroup | mount | 3029 | 3021 | 5000 | |
| ComboBox | mount | 697 | 682 | 1000 | |
| CommandBar | mount | 6628 | 6713 | 1000 | |
| ContextualMenu | mount | 12264 | 12367 | 1000 | |
| DefaultButton | mount | 808 | 800 | 5000 | |
| DetailsRow | mount | 2302 | 2256 | 5000 | |
| DetailsRowFast | mount | 2311 | 2235 | 5000 | |
| DetailsRowNoStyles | mount | 2065 | 2098 | 5000 | |
| Dialog | mount | 2692 | 2733 | 1000 | |
| DocumentCardTitle | mount | 242 | 237 | 1000 | |
| Dropdown | mount | 2017 | 2001 | 5000 | |
| FocusTrapZone | mount | 1162 | 1126 | 5000 | |
| FocusZone | mount | 1128 | 1107 | 5000 | |
| GroupedList | mount | 43009 | 42820 | 2 | |
| GroupedList | virtual-rerender | 20596 | 20584 | 2 | |
| GroupedList | virtual-rerender-with-unmount | 52212 | 52325 | 2 | |
| GroupedListV2 | mount | 229 | 228 | 2 | |
| GroupedListV2 | virtual-rerender | 221 | 220 | 2 | |
| GroupedListV2 | virtual-rerender-with-unmount | 228 | 232 | 2 | |
| IconButton | mount | 1160 | 1175 | 5000 | |
| Label | mount | 342 | 346 | 5000 | |
| Layer | mount | 2862 | 2793 | 5000 | |
| Link | mount | 398 | 401 | 5000 | |
| MenuButton | mount | 1005 | 1020 | 5000 | |
| MessageBar | mount | 21638 | 21738 | 5000 | |
| Nav | mount | 2072 | 2140 | 1000 | |
| OverflowSet | mount | 830 | 788 | 5000 | |
| Panel | mount | 1895 | 1924 | 1000 | |
| Persona | mount | 775 | 755 | 1000 | |
| Pivot | mount | 930 | 931 | 1000 | |
| PrimaryButton | mount | 960 | 966 | 5000 | |
| Rating | mount | 4769 | 4716 | 5000 | |
| SearchBox | mount | 924 | 930 | 5000 | |
| Shimmer | mount | 1907 | 1941 | 5000 | |
| Slider | mount | 1355 | 1371 | 5000 | |
| SpinButton | mount | 3039 | 3018 | 5000 | |
| Spinner | mount | 395 | 387 | 5000 | |
| SplitButton | mount | 1884 | 1929 | 5000 | |
| Stack | mount | 433 | 426 | 5000 | |
| StackWithIntrinsicChildren | mount | 880 | 896 | 5000 | |
| StackWithTextChildren | mount | 2805 | 2852 | 5000 | |
| SwatchColorPicker | mount | 6510 | 6543 | 5000 | |
| TagPicker | mount | 1542 | 1485 | 5000 | |
| Text | mount | 388 | 398 | 5000 | |
| TextField | mount | 953 | 949 | 5000 | |
| ThemeProvider | mount | 866 | 856 | 5000 | |
| ThemeProvider | virtual-rerender | 582 | 598 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1293 | 1306 | 5000 | |
| Toggle | mount | 632 | 631 | 5000 | |
| buttonNative | mount | 197 | 194 | 5000 |
28244e1 to
c8a2463
Compare
fabricteam
reviewed
Oct 21, 2024
This was referenced Oct 22, 2024
87a70ab to
1d438b7
Compare
4d98204 to
13e692a
Compare
Hotell
commented
Oct 25, 2024
dmytrokirpa
approved these changes
Oct 29, 2024
change/@fluentui-babel-preset-global-context-be7bd550-e553-4a5f-9aa9-50399a752c06.json
Show resolved
Hide resolved
layershifter
approved these changes
Oct 29, 2024
spmonahan
approved these changes
Oct 29, 2024
TristanWatanabe
approved these changes
Oct 29, 2024
13e692a to
4666dac
Compare
4666dac to
e2ea968
Compare
📊 Bundle size reportUnchanged fixtures
|
cd0f62b to
9ef9819
Compare
… api-extractor twice
…ic from generators
9ef9819 to
a8367b1
Compare
Collaborator
🕵 fluentui-web-components-v3 No visual regressions between this PR and main |
📊 Bundle size reportUnchanged fixtures
|
|
Pull request demo site: URL |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Previous Behavior
New Behavior
Migrates v9 and tools packages to use project crystal ( inferred tasks )
additional changes
🔐 security
package.json#scriptsanymore, mitigating exposure of tools used that could be possibly compromised to run malicious code in user land👨🔧 less boilerplate
git diff stats (excluding change files):
🧹 task cleanup/normalization
unified task names across all projects ( example of v9 library/ project ):
storybooktesttest-ssrlintformatandformat:checktype-checkbuildbundle-sizegenerate-apie2eande2e:localverify-packagingghost configurations that were not properly executed are now ran ( because project crystall properly defines them based on context )
bundle-sizeentries for packagese2etask, but had no e2e setup/tests are no longer presenttest-ssrtask, but had no supporting stories to run actual test are no longer present🧹 project cleanup
just-scriptsare gonne🎬 react-components project
unstable.d.tsis not using api-extractor anymore rather switches to template/unstableapi is deprecated and cannot be tweaked by anyone🚨 Breaking changes:
1. using
yarn workspacewon't work anymore (for packages using project crystal)how to run tasks going forward?
yarn nx run <project>:<task-name>yarn startfrom monorepo root2.
package.json#scriptsare gone and forbidden to use going forwardhow can I determine what tasks are available per project ?:
yarn nx show project <project-name>yarn startRelated Issue(s)