Skip to content

chore(scripts/,tools/): switch to inferred tasks#33019

Closed
Hotell wants to merge 1 commit intomicrosoft:masterfrom
Hotell:nx/enable-inferred-plugins/for-scripts
Closed

chore(scripts/,tools/): switch to inferred tasks#33019
Hotell wants to merge 1 commit intomicrosoft:masterfrom
Hotell:nx/enable-inferred-plugins/for-scripts

Conversation

@Hotell
Copy link
Collaborator

@Hotell Hotell commented Oct 10, 2024 •
edited
Loading

Pre-requirements

Previous Behavior

New Behavior

enable inferred plugins for all projects within /scripts and /tools

Related Issue(s)

@Hotell Hotell changed the title Nx/enable inferred plugins/for scripts chore(scripts/,tools/): switch to iinferred task Oct 10, 2024
@Hotell Hotell changed the title chore(scripts/,tools/): switch to iinferred task chore(scripts/,tools/): switch to inferred tasks Oct 10, 2024
@Hotell Hotell force-pushed the nx/enable-inferred-plugins/for-scripts branch from 8a7a53e to 5bdda8b Compare October 10, 2024 16:42
@fabricteam
Copy link
Collaborator

fabricteam commented Oct 10, 2024 •
edited
Loading

🕵 fluentui-web-components-v3 No visual regressions between this PR and main

fabricteam
fabricteam reviewed Oct 10, 2024
View reviewed changes
@fabricteam
Copy link
Collaborator

fabricteam commented Oct 10, 2024 •
edited
Loading

🕵 FluentUIV0 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Oct 10, 2024 •
edited
Loading

Perf Analysis (@fluentui/react-northstar)

⚠️ 1 potential perf regressions detected

Potential regressions comparing to master

Scenario Current PR Ticks Baseline Ticks Ratio Regression Analysis
AttachmentMinimalPerf.default 79 81 0.98:1 analysis
Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
AccordionMinimalPerf.default 85 74 1.15:1
AvatarMinimalPerf.default 117 103 1.14:1
DividerMinimalPerf.default 221 196 1.13:1
ReactionMinimalPerf.default 233 208 1.12:1
ChatWithPopoverPerf.default 221 200 1.11:1
ButtonMinimalPerf.default 93 85 1.09:1
TreeWith60ListItems.default 88 81 1.09:1
AlertMinimalPerf.default 166 155 1.07:1
AnimationMinimalPerf.default 315 294 1.07:1
FlexMinimalPerf.default 159 148 1.07:1
BoxMinimalPerf.default 201 190 1.06:1
InputMinimalPerf.default 564 530 1.06:1
LabelMinimalPerf.default 225 212 1.06:1
TableMinimalPerf.default 237 224 1.06:1
RefMinimalPerf.default 115 110 1.05:1
TableManyItemsPerf.default 1137 1079 1.05:1
TextAreaMinimalPerf.default 306 292 1.05:1
FormMinimalPerf.default 219 210 1.04:1
GridMinimalPerf.default 187 179 1.04:1
MenuButtonMinimalPerf.default 988 950 1.04:1
SegmentMinimalPerf.default 195 188 1.04:1
IconMinimalPerf.default 399 385 1.04:1
ToolbarMinimalPerf.default 567 546 1.04:1
TreeMinimalPerf.default 500 482 1.04:1
CardMinimalPerf.default 315 306 1.03:1
DropdownManyItemsPerf.default 398 386 1.03:1
ListMinimalPerf.default 311 303 1.03:1
DropdownMinimalPerf.default 1474 1444 1.02:1
EmbedMinimalPerf.default 1937 1906 1.02:1
ProviderMinimalPerf.default 204 200 1.02:1
SkeletonMinimalPerf.default 199 196 1.02:1
StatusMinimalPerf.default 401 395 1.02:1
TooltipMinimalPerf.default 1299 1273 1.02:1
ButtonSlotsPerf.default 317 314 1.01:1
HeaderMinimalPerf.default 212 210 1.01:1
ListCommonPerf.default 390 385 1.01:1
PopupMinimalPerf.default 361 359 1.01:1
RadioGroupMinimalPerf.default 257 254 1.01:1
ChatMinimalPerf.default 429 431 1:1
DatepickerMinimalPerf.default 3878 3864 1:1
DialogMinimalPerf.default 445 444 1:1
HeaderSlotsPerf.default 463 463 1:1
MenuMinimalPerf.default 508 508 1:1
RosterPerf.default 1577 1583 1:1
SliderMinimalPerf.default 757 759 1:1
ButtonOverridesMissPerf.default 655 664 0.99:1
CarouselMinimalPerf.default 263 267 0.99:1
LayoutMinimalPerf.default 197 200 0.99:1
CustomToolbarPrototype.default 1485 1503 0.99:1
VideoMinimalPerf.default 452 457 0.99:1
CheckboxMinimalPerf.default 1156 1179 0.98:1
ItemLayoutMinimalPerf.default 713 726 0.98:1
ProviderMergeThemesPerf.default 651 666 0.98:1
TextMinimalPerf.default 193 197 0.98:1
AttachmentSlotsPerf.default 626 645 0.97:1
ChatDuplicateMessagesPerf.default 148 153 0.97:1
ImageMinimalPerf.default 230 238 0.97:1
ListNestedPerf.default 310 318 0.97:1
PortalMinimalPerf.default 89 92 0.97:1
SplitButtonMinimalPerf.default 2237 2297 0.97:1
ListWith60ListItems.default 379 396 0.96:1
LoaderMinimalPerf.default 190 202 0.94:1

@fabricteam
Copy link
Collaborator

fabricteam commented Oct 10, 2024 •
edited
Loading

Perf Analysis (@fluentui/react-components)

Scenario Render type Master Ticks PR Ticks Iterations Status
FluentProviderWithTheme mount 85 83 10 Possible regression
All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 649 630 5000
Button mount 305 303 5000
Field mount 1184 1134 5000
FluentProvider mount 687 714 5000
FluentProviderWithTheme mount 85 83 10 Possible regression
FluentProviderWithTheme virtual-rerender 35 33 10
FluentProviderWithTheme virtual-rerender-with-unmount 76 78 10
MakeStyles mount 890 874 50000
Persona mount 1789 1739 5000
SpinButton mount 1395 1425 5000
SwatchPicker mount 1701 1723 5000

@fabricteam
Copy link
Collaborator

fabricteam commented Oct 10, 2024 •
edited
Loading

📊 Bundle size report

✅ No changes found

@Hotell Hotell force-pushed the nx/enable-inferred-plugins/for-scripts branch from 5bdda8b to ad45b68 Compare October 10, 2024 16:59
fabricteam
fabricteam reviewed Oct 10, 2024
View reviewed changes
@fabricteam
Copy link
Collaborator

fabricteam commented Oct 10, 2024 •
edited
Loading

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 728 670 5000
Breadcrumb mount 2902 2569 1000
Checkbox mount 2108 2095 5000
CheckboxBase mount 1873 1828 5000
ChoiceGroup mount 3066 3563 5000
ComboBox mount 658 677 1000
CommandBar mount 6588 6500 1000
ContextualMenu mount 11527 11490 1000
DefaultButton mount 794 787 5000
DetailsRow mount 2247 2292 5000
DetailsRowFast mount 2223 2231 5000
DetailsRowNoStyles mount 2036 2070 5000
Dialog mount 2696 2732 1000
DocumentCardTitle mount 227 223 1000
Dropdown mount 2022 2020 5000
FocusTrapZone mount 1152 1175 5000
FocusZone mount 1125 1058 5000
GroupedList mount 42179 42638 2
GroupedList virtual-rerender 20392 20259 2
GroupedList virtual-rerender-with-unmount 51793 52010 2
GroupedListV2 mount 217 231 2
GroupedListV2 virtual-rerender 215 215 2
GroupedListV2 virtual-rerender-with-unmount 236 229 2
IconButton mount 1144 1122 5000
Label mount 344 337 5000
Layer mount 2718 2775 5000
Link mount 399 383 5000
MenuButton mount 996 983 5000
MessageBar mount 21234 21186 5000
Nav mount 2060 2036 1000
OverflowSet mount 817 819 5000
Panel mount 1887 1861 1000
Persona mount 748 750 1000
Pivot mount 909 906 1000
PrimaryButton mount 965 939 5000
Rating mount 4782 4687 5000
SearchBox mount 918 930 5000
Shimmer mount 1863 1871 5000
Slider mount 1360 1379 5000
SpinButton mount 3029 3005 5000
Spinner mount 389 395 5000
SplitButton mount 1870 1893 5000
Stack mount 418 427 5000
StackWithIntrinsicChildren mount 896 891 5000
StackWithTextChildren mount 2822 2811 5000
SwatchColorPicker mount 6394 6444 5000
TagPicker mount 1473 1476 5000
Text mount 384 375 5000
TextField mount 966 964 5000
ThemeProvider mount 858 862 5000
ThemeProvider virtual-rerender 586 584 5000
ThemeProvider virtual-rerender-with-unmount 1326 1297 5000
Toggle mount 616 619 5000
buttonNative mount 194 193 5000

@Hotell Hotell mentioned this pull request Oct 14, 2024
Closed
39 tasks
@Hotell Hotell force-pushed the nx/enable-inferred-plugins/for-scripts branch from ad45b68 to 982eaa5 Compare October 14, 2024 11:49
@Hotell Hotell mentioned this pull request Oct 24, 2024
Merged
@Hotell Hotell closed this Nov 4, 2024
@Hotell Hotell deleted the nx/enable-inferred-plugins/for-scripts branch November 4, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fabricteam fabricteam fabricteam left review comments

Assignees

No one assigned

Labels

NX: core

Projects

None yet

Milestone

October Project Cycle Q4 2024

Development

Successfully merging this pull request may close these issues.

2 participants

@Hotell @fabricteam