Skip to content

feat(workspace-plugin): implement build executor#32439

Merged
Hotell merged 13 commits intomicrosoft:masterfrom
Hotell:nx/workspace-plugin/build-executor
Sep 24, 2024
Merged

feat(workspace-plugin): implement build executor#32439
Hotell merged 13 commits intomicrosoft:masterfrom
Hotell:nx/workspace-plugin/build-executor

Conversation

@Hotell
Copy link
Collaborator

@Hotell Hotell commented Sep 2, 2024

Previous Behavior

New Behavior

💡 What is nx executor ? https://nx.dev/concepts/executors-and-configurations

  • implements build executor
  • replacement for npm script alias build which uses just-scripts (build:react-components)
  • NOTE:
    • executor implementation fixes inconsistencies with generating source maps that are present within our just-scripts logic
    • this first implementation wont emit .d.ts nor rolluped .d.ts - this is handled by generate-api executor but for sake of encapsulation we will invoke generate-api executor within this executor ( executor composition ) as a follow-up.

Related Issue(s)

@fabricteam
Copy link
Collaborator

fabricteam commented Sep 2, 2024

📊 Bundle size report

✅ No changes found

@Hotell Hotell force-pushed the nx/workspace-plugin/build-executor branch from c886f12 to 0d40dcd Compare September 6, 2024 12:36
@Hotell
Copy link
Collaborator Author

Hotell commented Sep 10, 2024

/azp run

@Hotell Hotell marked this pull request as ready for review September 10, 2024 12:02
@Hotell Hotell requested a review from a team as a code owner September 10, 2024 12:02
@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@Hotell Hotell force-pushed the nx/workspace-plugin/build-executor branch from 99afc31 to 3c913ab Compare September 11, 2024 13:19
@Hotell Hotell merged commit 20bfbad into microsoft:master Sep 24, 2024
@Hotell Hotell deleted the nx/workspace-plugin/build-executor branch September 24, 2024 08:55
Hotell added a commit to Hotell/fluentui that referenced this pull request Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants