chore: normalize project names in whole repo by Hotell · Pull Request #31893 · microsoft/fluentui

Hotell · 2024-07-01T13:53:17Z

Previous Behavior

New Behavior

All projects project.json#name have been changed to not use npmScope as part of their name, in order to to run all commands in more concise fashion.

Before:

yarn nx run @fluentui/react-text:storybook

After:

yarn nx run react-text:storybook

Additional Changes:

lot of refactors needed across our tooling utils
docs updates
prettierignore pattern fix for versions.ts

Related Issue(s)

Fixes partially [Feature]: migrate to nx #30267

.gitignore

fabricteam · 2024-07-01T14:03:23Z

Perf Analysis (`@fluentui/react-components`)

Scenario	Render type	Master Ticks	PR Ticks	Iterations	Status
FluentProviderWithTheme	virtual-rerender	37	26	10	Possible regression
FluentProviderWithTheme	virtual-rerender-with-unmount	80	74	10	Possible regression

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations	Status
Avatar	mount	635	634	5000
Button	mount	288	290	5000
Field	mount	1101	1103	5000
FluentProvider	mount	717	717	5000
FluentProviderWithTheme	mount	77	87	10
FluentProviderWithTheme	virtual-rerender	37	26	10	Possible regression
FluentProviderWithTheme	virtual-rerender-with-unmount	80	74	10	Possible regression
MakeStyles	mount	860	842	50000
Persona	mount	1718	1738	5000
SpinButton	mount	1420	1356	5000
SwatchPicker	mount	1649	1646	5000

fabricteam · 2024-07-01T14:04:08Z

📊 Bundle size report

✅ No changes found

fabricteam · 2024-07-01T14:08:26Z

Perf Analysis (`@fluentui/react-northstar`)

⚠️ 1 potential perf regressions detected

Potential regressions comparing to master

Scenario	Current PR Ticks	Baseline Ticks	Ratio	Regression Analysis
PortalMinimalPerf.default	89	80	1.11:1	analysis

Perf tests with no regressions

Scenario	Current PR Ticks	Baseline Ticks	Ratio
BoxMinimalPerf.default	207	188	1.1:1
ButtonMinimalPerf.default	96	89	1.08:1
ReactionMinimalPerf.default	215	199	1.08:1
LoaderMinimalPerf.default	196	183	1.07:1
PopupMinimalPerf.default	364	340	1.07:1
IconMinimalPerf.default	381	357	1.07:1
TextAreaMinimalPerf.default	297	278	1.07:1
ChatDuplicateMessagesPerf.default	162	153	1.06:1
StatusMinimalPerf.default	398	377	1.06:1
DropdownManyItemsPerf.default	400	381	1.05:1
FormMinimalPerf.default	233	221	1.05:1
InputMinimalPerf.default	543	515	1.05:1
RefMinimalPerf.default	111	106	1.05:1
GridMinimalPerf.default	192	185	1.04:1
LayoutMinimalPerf.default	201	193	1.04:1
AnimationMinimalPerf.default	305	296	1.03:1
AttachmentMinimalPerf.default	80	78	1.03:1
ButtonSlotsPerf.default	323	314	1.03:1
CheckboxMinimalPerf.default	1141	1112	1.03:1
DialogMinimalPerf.default	448	433	1.03:1
FlexMinimalPerf.default	162	158	1.03:1
LabelMinimalPerf.default	223	217	1.03:1
TableMinimalPerf.default	242	234	1.03:1
CarouselMinimalPerf.default	257	252	1.02:1
EmbedMinimalPerf.default	1876	1832	1.02:1
RosterPerf.default	1581	1556	1.02:1
ProviderMinimalPerf.default	206	201	1.02:1
SegmentMinimalPerf.default	207	203	1.02:1
ToolbarMinimalPerf.default	540	529	1.02:1
AttachmentSlotsPerf.default	643	634	1.01:1
AvatarMinimalPerf.default	105	104	1.01:1
ChatMinimalPerf.default	439	435	1.01:1
DropdownMinimalPerf.default	1425	1412	1.01:1
HeaderSlotsPerf.default	464	461	1.01:1
ImageMinimalPerf.default	231	229	1.01:1
MenuMinimalPerf.default	496	492	1.01:1
TableManyItemsPerf.default	1130	1124	1.01:1
TooltipMinimalPerf.default	1318	1301	1.01:1
TreeWith60ListItems.default	86	85	1.01:1
CardMinimalPerf.default	302	301	1:1
ItemLayoutMinimalPerf.default	713	710	1:1
ListMinimalPerf.default	311	311	1:1
ListWith60ListItems.default	367	366	1:1
ProviderMergeThemesPerf.default	650	647	1:1
SplitButtonMinimalPerf.default	2252	2246	1:1
CustomToolbarPrototype.default	1463	1470	1:1
ButtonOverridesMissPerf.default	626	635	0.99:1
DatepickerMinimalPerf.default	3480	3515	0.99:1
HeaderMinimalPerf.default	205	207	0.99:1
MenuButtonMinimalPerf.default	933	938	0.99:1
VideoMinimalPerf.default	437	440	0.99:1
DividerMinimalPerf.default	199	203	0.98:1
RadioGroupMinimalPerf.default	260	264	0.98:1
SkeletonMinimalPerf.default	198	202	0.98:1
ChatWithPopoverPerf.default	195	202	0.97:1
ListNestedPerf.default	312	321	0.97:1
SliderMinimalPerf.default	736	755	0.97:1
TreeMinimalPerf.default	466	482	0.97:1
TextMinimalPerf.default	190	197	0.96:1
AlertMinimalPerf.default	153	162	0.94:1
ListCommonPerf.default	373	402	0.93:1
AccordionMinimalPerf.default	73	82	0.89:1

fabricteam · 2024-07-01T14:10:10Z

🕵 FluentUIV0 No visual regressions between this PR and main

fabricteam · 2024-07-01T14:18:32Z

Perf Analysis (`@fluentui/react`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
BaseButton	mount	634	637	5000
Breadcrumb	mount	1678	1665	1000
Checkbox	mount	1707	1682	5000
CheckboxBase	mount	1474	1465	5000
ChoiceGroup	mount	2996	3015	5000
ComboBox	mount	672	676	1000
CommandBar	mount	6613	6598	1000
ContextualMenu	mount	12009	12249	1000
DefaultButton	mount	803	781	5000
DetailsRow	mount	2221	2240	5000
DetailsRowFast	mount	2216	2243	5000
DetailsRowNoStyles	mount	2034	2031	5000
Dialog	mount	2651	2665	1000
DocumentCardTitle	mount	215	234	1000
Dropdown	mount	1986	2018	5000
FocusTrapZone	mount	1157	1161	5000
FocusZone	mount	1099	1065	5000
GroupedList	mount	37603	42354	2
GroupedList	virtual-rerender	20239	20262	2
GroupedList	virtual-rerender-with-unmount	50747	51122	2
GroupedListV2	mount	223	228	2
GroupedListV2	virtual-rerender	202	212	2
GroupedListV2	virtual-rerender-with-unmount	224	230	2
IconButton	mount	1143	1142	5000
Label	mount	337	335	5000
Layer	mount	2770	2730	5000
Link	mount	387	398	5000
MenuButton	mount	988	977	5000
MessageBar	mount	21656	21574	5000
Nav	mount	2004	2019	1000
OverflowSet	mount	773	798	5000
Panel	mount	1818	1814	1000
Persona	mount	765	763	1000
Pivot	mount	906	920	1000
PrimaryButton	mount	941	980	5000
Rating	mount	4788	4688	5000
SearchBox	mount	903	955	5000
Shimmer	mount	1940	1900	5000
Slider	mount	1374	1351	5000
SpinButton	mount	2967	2990	5000
Spinner	mount	394	404	5000
SplitButton	mount	1924	1890	5000
Stack	mount	425	421	5000
StackWithIntrinsicChildren	mount	886	876	5000
StackWithTextChildren	mount	2838	2811	5000
SwatchColorPicker	mount	6365	6445	5000
TagPicker	mount	1514	1508	5000
Text	mount	392	392	5000
TextField	mount	923	975	5000
ThemeProvider	mount	866	870	5000
ThemeProvider	virtual-rerender	594	587	5000
ThemeProvider	virtual-rerender-with-unmount	1291	1279	5000
Toggle	mount	627	614	5000
buttonNative	mount	190	192	5000

.prettierignore

scripts/generators/src/copy-notices.js

tools/workspace-plugin/src/generators/normalize-package-dependencies/index.spec.ts

.devops/templates/build-test-lint.yml

… npm scope

…tierignore

…etup

fabricteam · 2024-07-04T10:31:23Z

🕵 fluentuiv8 No visual regressions between this PR and main

Hotell mentioned this pull request Jul 1, 2024

[Feature]: migrate to nx #30267

Closed

39 tasks

fabricteam reviewed Jul 1, 2024

View reviewed changes

.gitignore Show resolved Hide resolved

github-actions bot added this to the July Project Cycle Q3 2024 milestone Jul 1, 2024

Hotell force-pushed the nx/project-names-normalize branch from 5ee689c to cda8f93 Compare July 2, 2024 15:26

Hotell commented Jul 3, 2024

View reviewed changes

fabricteam reviewed Jul 3, 2024

View reviewed changes

.devops/templates/build-test-lint.yml Show resolved Hide resolved

Hotell added 10 commits July 4, 2024 12:17

chore: normalize all project.json names to omit @FluentUI scope

1335d9d

feat: update all api's to accommodate workspace project names without…

db6d32d

… npm scope

feat: make normalize-package-dependencies work with new project.names

ccabbb6

feat(fluentui-publish): update code to work with new project names setup

4f3dc50

style(fluentui-publish): resolve version.ts files clashes within pret…

41a2d85

…tierignore

feat(scripts-storybook): update code to work with new project names s…

ffe66d6

…etup

change files

1d91514

fix(projecs-test): update logic to work with new project names

a979150

style: typo

347656e

docs: update v9 contributing

1cc43f8

Hotell force-pushed the nx/project-names-normalize branch from d5ded0f to 1cc43f8 Compare July 4, 2024 10:17

Hotell marked this pull request as ready for review July 4, 2024 11:26

Hotell requested review from a team as code owners July 4, 2024 11:26

Hotell added NX: core Area: Build System labels Jul 4, 2024

mainframev approved these changes Jul 4, 2024

View reviewed changes

Hotell merged commit 674cdee into microsoft:master Jul 4, 2024

Hotell deleted the nx/project-names-normalize branch July 4, 2024 15:00

mainframev mentioned this pull request Jul 6, 2024

[Bug]: App not run in dev mode #31928

Closed

2 tasks

AtishayMsft added a commit that referenced this pull request Sep 3, 2024

Normalize package name as per fluent updates #31893

7bd8ff3

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: normalize project names in whole repo#31893

chore: normalize project names in whole repo#31893
Hotell merged 10 commits intomicrosoft:masterfrom
Hotell:nx/project-names-normalize

Hotell commented Jul 1, 2024 •

edited

Loading

Uh oh!

Uh oh!

fabricteam commented Jul 1, 2024 •

edited

Loading

Uh oh!

fabricteam commented Jul 1, 2024 •

edited

Loading

Uh oh!

fabricteam commented Jul 1, 2024 •

edited

Loading

Uh oh!

fabricteam commented Jul 1, 2024 •

edited

Loading

Uh oh!

fabricteam commented Jul 1, 2024 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fabricteam commented Jul 4, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Hotell commented Jul 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Previous Behavior

New Behavior

Related Issue(s)

Uh oh!

Uh oh!

fabricteam commented Jul 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Perf Analysis (@fluentui/react-components)

Uh oh!

fabricteam commented Jul 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Bundle size report

Uh oh!

fabricteam commented Jul 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Perf Analysis (@fluentui/react-northstar)

Potential regressions comparing to master

Uh oh!

fabricteam commented Jul 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🕵 FluentUIV0 No visual regressions between this PR and main

Uh oh!

fabricteam commented Jul 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Perf Analysis (@fluentui/react)

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fabricteam commented Jul 4, 2024

🕵 fluentuiv8 No visual regressions between this PR and main

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Hotell commented Jul 1, 2024 •

edited

Loading

fabricteam commented Jul 1, 2024 •

edited

Loading

Perf Analysis (`@fluentui/react-components`)

fabricteam commented Jul 1, 2024 •

edited

Loading

fabricteam commented Jul 1, 2024 •

edited

Loading

Perf Analysis (`@fluentui/react-northstar`)

fabricteam commented Jul 1, 2024 •

edited

Loading

fabricteam commented Jul 1, 2024 •

edited

Loading

Perf Analysis (`@fluentui/react`)