Skip to content

fix(react-swatch-picker): added aria-labels and fixed popup example#31702

Merged
ValentinaKozlova merged 1 commit intomicrosoft:masterfrom
ValentinaKozlova:fix/swatch-picker-a11y
Jun 17, 2024
Merged

fix(react-swatch-picker): added aria-labels and fixed popup example#31702
ValentinaKozlova merged 1 commit intomicrosoft:masterfrom
ValentinaKozlova:fix/swatch-picker-a11y

Conversation

@ValentinaKozlova
Copy link
Contributor

Previous Behavior

  • aria-labels were missing buttons in EmptySwatch examples
  • there were no feedback for user after button clicks

New Behavior

  • Added aria-labels for EmptySwatch examples
  • Added live regions for feedback when clicks on buttons occur
  • Added grid layout for an example with popup

@fabricteam
Copy link
Collaborator

📊 Bundle size report

✅ No changes found

@ValentinaKozlova ValentinaKozlova marked this pull request as ready for review June 17, 2024 10:40
@ValentinaKozlova ValentinaKozlova requested a review from a team as a code owner June 17, 2024 10:40
@ValentinaKozlova ValentinaKozlova merged commit 13d0fd8 into microsoft:master Jun 17, 2024
@ValentinaKozlova ValentinaKozlova deleted the fix/swatch-picker-a11y branch June 17, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants