chore: Remove recipes-react-components in favor of recipes package#31647
Merged
sopranopillow merged 1 commit intomicrosoft:masterfrom Jun 11, 2024
Merged
chore: Remove recipes-react-components in favor of recipes package#31647sopranopillow merged 1 commit intomicrosoft:masterfrom
sopranopillow merged 1 commit intomicrosoft:masterfrom
Conversation
fabricteam
reviewed
Jun 10, 2024
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 629 | 658 | 5000 | |
| Button | mount | 312 | 315 | 5000 | |
| Field | mount | 1153 | 1184 | 5000 | |
| FluentProvider | mount | 685 | 704 | 5000 | |
| FluentProviderWithTheme | mount | 86 | 85 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 37 | 37 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 76 | 73 | 10 | |
| MakeStyles | mount | 864 | 865 | 50000 | |
| Persona | mount | 1760 | 1743 | 5000 | |
| SpinButton | mount | 1351 | 1409 | 5000 | |
| SwatchPicker | mount | 1541 | 1559 | 5000 |
fabricteam
reviewed
Jun 10, 2024
Collaborator
Perf Analysis (
|
| Scenario | Current PR Ticks | Baseline Ticks | Ratio | Regression Analysis |
|---|---|---|---|---|
| AlertMinimalPerf.default | 157 | 163 | 0.96:1 | analysis |
Perf tests with no regressions
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| AttachmentMinimalPerf.default | 81 | 74 | 1.09:1 |
| ListNestedPerf.default | 337 | 308 | 1.09:1 |
| AccordionMinimalPerf.default | 88 | 82 | 1.07:1 |
| ChatDuplicateMessagesPerf.default | 158 | 147 | 1.07:1 |
| FormMinimalPerf.default | 225 | 211 | 1.07:1 |
| ButtonSlotsPerf.default | 316 | 301 | 1.05:1 |
| ChatWithPopoverPerf.default | 199 | 190 | 1.05:1 |
| GridMinimalPerf.default | 200 | 190 | 1.05:1 |
| HeaderMinimalPerf.default | 214 | 203 | 1.05:1 |
| LabelMinimalPerf.default | 229 | 218 | 1.05:1 |
| SegmentMinimalPerf.default | 196 | 186 | 1.05:1 |
| SliderMinimalPerf.default | 742 | 709 | 1.05:1 |
| AnimationMinimalPerf.default | 296 | 285 | 1.04:1 |
| CardMinimalPerf.default | 322 | 311 | 1.04:1 |
| HeaderSlotsPerf.default | 466 | 450 | 1.04:1 |
| InputMinimalPerf.default | 552 | 532 | 1.04:1 |
| LayoutMinimalPerf.default | 201 | 193 | 1.04:1 |
| PortalMinimalPerf.default | 86 | 83 | 1.04:1 |
| ProviderMinimalPerf.default | 210 | 201 | 1.04:1 |
| ButtonMinimalPerf.default | 92 | 89 | 1.03:1 |
| CarouselMinimalPerf.default | 265 | 258 | 1.03:1 |
| EmbedMinimalPerf.default | 1909 | 1848 | 1.03:1 |
| LoaderMinimalPerf.default | 198 | 192 | 1.03:1 |
| RosterPerf.default | 1624 | 1572 | 1.03:1 |
| PopupMinimalPerf.default | 350 | 341 | 1.03:1 |
| ReactionMinimalPerf.default | 219 | 212 | 1.03:1 |
| SplitButtonMinimalPerf.default | 2276 | 2209 | 1.03:1 |
| TableMinimalPerf.default | 241 | 233 | 1.03:1 |
| AttachmentSlotsPerf.default | 646 | 636 | 1.02:1 |
| CheckboxMinimalPerf.default | 1157 | 1132 | 1.02:1 |
| DatepickerMinimalPerf.default | 3807 | 3719 | 1.02:1 |
| DialogMinimalPerf.default | 446 | 437 | 1.02:1 |
| DropdownMinimalPerf.default | 1444 | 1420 | 1.02:1 |
| FlexMinimalPerf.default | 158 | 155 | 1.02:1 |
| ProviderMergeThemesPerf.default | 646 | 633 | 1.02:1 |
| TextMinimalPerf.default | 194 | 191 | 1.02:1 |
| TooltipMinimalPerf.default | 1271 | 1247 | 1.02:1 |
| TreeWith60ListItems.default | 84 | 82 | 1.02:1 |
| VideoMinimalPerf.default | 425 | 415 | 1.02:1 |
| ChatMinimalPerf.default | 447 | 442 | 1.01:1 |
| ListCommonPerf.default | 389 | 386 | 1.01:1 |
| RadioGroupMinimalPerf.default | 261 | 258 | 1.01:1 |
| RefMinimalPerf.default | 110 | 109 | 1.01:1 |
| TableManyItemsPerf.default | 1104 | 1089 | 1.01:1 |
| ToolbarMinimalPerf.default | 546 | 541 | 1.01:1 |
| DropdownManyItemsPerf.default | 385 | 386 | 1:1 |
| MenuMinimalPerf.default | 497 | 498 | 1:1 |
| StatusMinimalPerf.default | 391 | 392 | 1:1 |
| TextAreaMinimalPerf.default | 286 | 287 | 1:1 |
| CustomToolbarPrototype.default | 1476 | 1477 | 1:1 |
| ButtonOverridesMissPerf.default | 652 | 657 | 0.99:1 |
| ImageMinimalPerf.default | 218 | 220 | 0.99:1 |
| ListMinimalPerf.default | 296 | 298 | 0.99:1 |
| MenuButtonMinimalPerf.default | 935 | 956 | 0.98:1 |
| TreeMinimalPerf.default | 466 | 477 | 0.98:1 |
| AvatarMinimalPerf.default | 106 | 109 | 0.97:1 |
| IconMinimalPerf.default | 368 | 380 | 0.97:1 |
| ItemLayoutMinimalPerf.default | 689 | 721 | 0.96:1 |
| DividerMinimalPerf.default | 203 | 213 | 0.95:1 |
| ListWith60ListItems.default | 354 | 376 | 0.94:1 |
| SkeletonMinimalPerf.default | 186 | 198 | 0.94:1 |
| BoxMinimalPerf.default | 196 | 220 | 0.89:1 |
Collaborator
🕵 FluentUIV0 No visual regressions between this PR and main |
Collaborator
📊 Bundle size report✅ No changes found |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 633 | 651 | 5000 | |
| Breadcrumb | mount | 1741 | 1726 | 1000 | |
| Checkbox | mount | 1684 | 1706 | 5000 | |
| CheckboxBase | mount | 1487 | 1505 | 5000 | |
| ChoiceGroup | mount | 3036 | 3028 | 5000 | |
| ComboBox | mount | 687 | 704 | 1000 | |
| CommandBar | mount | 6962 | 7091 | 1000 | |
| ContextualMenu | mount | 15868 | 14316 | 1000 | |
| DefaultButton | mount | 805 | 795 | 5000 | |
| DetailsRow | mount | 2271 | 2223 | 5000 | |
| DetailsRowFast | mount | 2259 | 2221 | 5000 | |
| DetailsRowNoStyles | mount | 2024 | 2030 | 5000 | |
| Dialog | mount | 2694 | 2849 | 1000 | |
| DocumentCardTitle | mount | 227 | 231 | 1000 | |
| Dropdown | mount | 2016 | 1973 | 5000 | |
| FocusTrapZone | mount | 1143 | 1166 | 5000 | |
| FocusZone | mount | 1106 | 1095 | 5000 | |
| GroupedList | mount | 38433 | 43033 | 2 | |
| GroupedList | virtual-rerender | 18527 | 20486 | 2 | |
| GroupedList | virtual-rerender-with-unmount | 52366 | 52477 | 2 | |
| GroupedListV2 | mount | 230 | 229 | 2 | |
| GroupedListV2 | virtual-rerender | 230 | 224 | 2 | |
| GroupedListV2 | virtual-rerender-with-unmount | 223 | 245 | 2 | |
| IconButton | mount | 1133 | 1160 | 5000 | |
| Label | mount | 338 | 347 | 5000 | |
| Layer | mount | 2813 | 2808 | 5000 | |
| Link | mount | 407 | 414 | 5000 | |
| MenuButton | mount | 989 | 966 | 5000 | |
| MessageBar | mount | 21873 | 21730 | 5000 | |
| Nav | mount | 2096 | 2024 | 1000 | |
| OverflowSet | mount | 797 | 788 | 5000 | |
| Panel | mount | 1804 | 1880 | 1000 | |
| Persona | mount | 752 | 760 | 1000 | |
| Pivot | mount | 911 | 918 | 1000 | |
| PrimaryButton | mount | 945 | 938 | 5000 | |
| Rating | mount | 4727 | 4732 | 5000 | |
| SearchBox | mount | 915 | 940 | 5000 | |
| Shimmer | mount | 1921 | 1918 | 5000 | |
| Slider | mount | 1364 | 1334 | 5000 | |
| SpinButton | mount | 3026 | 2989 | 5000 | |
| Spinner | mount | 389 | 397 | 5000 | |
| SplitButton | mount | 1875 | 1896 | 5000 | |
| Stack | mount | 407 | 412 | 5000 | |
| StackWithIntrinsicChildren | mount | 846 | 856 | 5000 | |
| StackWithTextChildren | mount | 2711 | 2682 | 5000 | |
| SwatchColorPicker | mount | 6489 | 6433 | 5000 | |
| TagPicker | mount | 1507 | 1461 | 5000 | |
| Text | mount | 396 | 379 | 5000 | |
| TextField | mount | 937 | 956 | 5000 | |
| ThemeProvider | mount | 864 | 856 | 5000 | |
| ThemeProvider | virtual-rerender | 595 | 600 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1336 | 1331 | 5000 | |
| Toggle | mount | 609 | 624 | 5000 | |
| buttonNative | mount | 188 | 193 | 5000 |
fabricteam
reviewed
Jun 10, 2024
Hotell
approved these changes
Jun 11, 2024
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Jun 12, 2024
…escription * master: chore(react-list-preview): Add bundle size tests (microsoft#31658) applying package updates feat:react-nav-preview Add a handful of accessibility features for Nav (microsoft#31649) feat: refactor anchor-button to use element internals and anchor proxy element (microsoft#31653) chore:(docs) New Component doc (microsoft#31611) style(react-nav-preview): fix formatting in barel file (microsoft#31671) feat(web-components): refactor progress bar to use ElementInternals (microsoft#31652) chore(react-components): split react libraries in two (/library and /stories) - last batch (microsoft#31581) fix(scripts-beachball): ignore web-components packages from v8 release scope (microsoft#31667) chore(react-components): split react libraries in two (/library and /stories) - cxe-red /2nd batch (microsoft#31580) chore: Remove recipes-react-components in favor of recipes package (microsoft#31647) feat: Add consistent start and finish lifecycle callbacks (microsoft#31644) chore(docs): Remove requirement of performance tests from epic template (microsoft#31662) chore(react-components): split react libraries in two (/library and /stories) - cxe-red /1st batch (microsoft#31579) docs(react-swatch-picker): added SwatchPicker page to Component Mapping (microsoft#31637) docs(dev-env): update minimal node version (microsoft#31638)
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Jun 12, 2024
* master: chore(react-list-preview): Add bundle size tests (microsoft#31658) applying package updates feat:react-nav-preview Add a handful of accessibility features for Nav (microsoft#31649) feat: refactor anchor-button to use element internals and anchor proxy element (microsoft#31653) chore:(docs) New Component doc (microsoft#31611) style(react-nav-preview): fix formatting in barel file (microsoft#31671) feat(web-components): refactor progress bar to use ElementInternals (microsoft#31652) chore(react-components): split react libraries in two (/library and /stories) - last batch (microsoft#31581) fix(scripts-beachball): ignore web-components packages from v8 release scope (microsoft#31667) chore(react-components): split react libraries in two (/library and /stories) - cxe-red /2nd batch (microsoft#31580) chore: Remove recipes-react-components in favor of recipes package (microsoft#31647) feat: Add consistent start and finish lifecycle callbacks (microsoft#31644) chore(docs): Remove requirement of performance tests from epic template (microsoft#31662) chore(react-components): split react libraries in two (/library and /stories) - cxe-red /1st batch (microsoft#31579) docs(react-swatch-picker): added SwatchPicker page to Component Mapping (microsoft#31637) docs(dev-env): update minimal node version (microsoft#31638)
miroslavstastny
pushed a commit
to miroslavstastny/fluentui
that referenced
this pull request
Jun 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
We were using an app for recipes, but this is not the way we'll be using them forward.
New Behavior
Remove app in favor of package that is consumed by the docsite.
Related Issue(s)