Skip to content

fix(react-calendar-compat): fixed focus indicator cut off#31596

Merged
ValentinaKozlova merged 2 commits intomicrosoft:masterfrom
ValentinaKozlova:fix/calendar-compat-focus-state
Jun 17, 2024
Merged

fix(react-calendar-compat): fixed focus indicator cut off#31596
ValentinaKozlova merged 2 commits intomicrosoft:masterfrom
ValentinaKozlova:fix/calendar-compat-focus-state

Conversation

@ValentinaKozlova
Copy link
Contributor

@ValentinaKozlova ValentinaKozlova commented Jun 6, 2024

Previous Behavior

  • Focus indicator get cut off in Calendar Month selection
    focus-bug

New Behavior

  • Focus should be fully visible
  • Removed TRANSITION_ROW_DISAPPEARANCE animation to improve performance
    focus-fix-

@ValentinaKozlova ValentinaKozlova added the Component: Calendar Compat Calendar Compat component label Jun 6, 2024
@ValentinaKozlova ValentinaKozlova self-assigned this Jun 6, 2024
@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 6, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@fabricteam
Copy link
Collaborator

fabricteam commented Jun 6, 2024

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-calendar-compat
Calendar Compat
149.45 kB
39.786 kB
149.583 kB
39.839 kB
133 B
53 B
react-datepicker-compat
DatePicker Compat
222.874 kB
63.098 kB
223.007 kB
63.137 kB
133 B
39 B

🤖 This report was generated against 5139ad8299071bb70681a140ce52b12cc24763fc

@ValentinaKozlova ValentinaKozlova force-pushed the fix/calendar-compat-focus-state branch from d764df2 to e1b8794 Compare June 13, 2024 10:08
@ValentinaKozlova ValentinaKozlova marked this pull request as ready for review June 13, 2024 10:17
@ValentinaKozlova ValentinaKozlova requested review from a team and sopranopillow as code owners June 13, 2024 10:17
@ValentinaKozlova ValentinaKozlova force-pushed the fix/calendar-compat-focus-state branch from e1b8794 to 700c1e1 Compare June 13, 2024 10:18
Copy link
Contributor

@mainframev mainframev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@ValentinaKozlova ValentinaKozlova force-pushed the fix/calendar-compat-focus-state branch from 700c1e1 to 6e1b3ca Compare June 17, 2024 10:43
@ValentinaKozlova ValentinaKozlova merged commit 5b3fcbd into microsoft:master Jun 17, 2024
@ValentinaKozlova ValentinaKozlova deleted the fix/calendar-compat-focus-state branch June 17, 2024 16:27
EdDaWord pushed a commit to EdDaWord/fluentui that referenced this pull request Jun 17, 2024
EdDaWord pushed a commit to EdDaWord/fluentui that referenced this pull request Aug 14, 2024
chore(motion): add bundle size fixtures (microsoft#31730)

fix(react-calendar-compat): fixed focus indicator cut off (microsoft#31596)

feat: use custom states for button and anchor button variants (microsoft#31718)

docs: add min-width styles to Table and DataGrid stories, add best practices (microsoft#31721)

fix:react-nav-preview: High contrast issues (microsoft#31704)

Pretty & lint & yarn change

Somehow missed change files

Fix one of the tests

Fix React-text test

Use hashed name for each semantic and control token
EdDaWord pushed a commit to EdDaWord/fluentui that referenced this pull request Aug 14, 2024
chore(motion): add bundle size fixtures (microsoft#31730)

fix(react-calendar-compat): fixed focus indicator cut off (microsoft#31596)

feat: use custom states for button and anchor button variants (microsoft#31718)

docs: add min-width styles to Table and DataGrid stories, add best practices (microsoft#31721)

fix:react-nav-preview: High contrast issues (microsoft#31704)

Pretty & lint & yarn change

Somehow missed change files

Fix one of the tests

Fix React-text test

Use hashed name for each semantic and control token
EdDaWord pushed a commit to EdDaWord/fluentui that referenced this pull request Aug 16, 2024
EdDaWord added a commit that referenced this pull request Aug 19, 2024
Change most tokens in useButtonStyles file

Give all the react-components a try

chore(motion): add bundle size fixtures (#31730)

fix(react-calendar-compat): fixed focus indicator cut off (#31596)

feat: use custom states for button and anchor button variants (#31718)

feat: update badge to use custom states (#31733)

fix: Teaching bubble carousel tabs are visible in windows high contrast (#31734)

fix:react-nav-preview: High contrast issues (#31704)

Pretty & lint & yarn change

Somehow missed change files

Fix one of the tests

Fix React-text test
EdDaWord added a commit that referenced this pull request Aug 19, 2024
Change most tokens in useButtonStyles file

Give all the react-components a try

fix: Teaching bubble carousel tabs are visible in windows high contrast (#31734)

fix:react-nav-preview: High contrast issues (#31704)

chore(motion): add bundle size fixtures (#31730)

fix(react-calendar-compat): fixed focus indicator cut off (#31596)

feat: use custom states for button and anchor button variants (#31718)

docs: add min-width styles to Table and DataGrid stories, add best practices (#31721)

fix:react-nav-preview: High contrast issues (#31704)

Pretty & lint & yarn change

Somehow missed change files

Fix one of the tests

Fix React-text test

Use hashed name for each semantic and control token

Build

missed one

Fix small mistake

Fix small mistake

Fix small mistake
EdDaWord added a commit that referenced this pull request Aug 19, 2024
Change most tokens in useButtonStyles file

Give all the react-components a try

fix: Teaching bubble carousel tabs are visible in windows high contrast (#31734)

fix:react-nav-preview: High contrast issues (#31704)

chore(motion): add bundle size fixtures (#31730)

fix(react-calendar-compat): fixed focus indicator cut off (#31596)

feat: use custom states for button and anchor button variants (#31718)

docs: add min-width styles to Table and DataGrid stories, add best practices (#31721)

fix:react-nav-preview: High contrast issues (#31704)

Pretty & lint & yarn change

Somehow missed change files

Fix one of the tests

Fix React-text test

Use hashed name for each semantic and control token

Build

missed one

Fix small mistake

Fix small mistake

Fix small mistake

Fix Random YML File
EdDaWord added a commit that referenced this pull request Aug 20, 2024
Change most tokens in useButtonStyles file

Give all the react-components a try

fix: Teaching bubble carousel tabs are visible in windows high contrast (#31734)

fix:react-nav-preview: High contrast issues (#31704)

chore(motion): add bundle size fixtures (#31730)

fix(react-calendar-compat): fixed focus indicator cut off (#31596)

feat: use custom states for button and anchor button variants (#31718)

docs: add min-width styles to Table and DataGrid stories, add best practices (#31721)

fix:react-nav-preview: High contrast issues (#31704)

Pretty & lint & yarn change

Somehow missed change files

Fix one of the tests

Fix React-text test

Use hashed name for each semantic and control token

Build

missed one

Fix small mistake

Fix small mistake

Fix small mistake

Fix Random YML File

Fix rebase mistake
EdDaWord added a commit that referenced this pull request Aug 23, 2024
Change most tokens in useButtonStyles file

Give all the react-components a try

fix: Teaching bubble carousel tabs are visible in windows high contrast (#31734)

fix:react-nav-preview: High contrast issues (#31704)

chore(motion): add bundle size fixtures (#31730)

fix(react-calendar-compat): fixed focus indicator cut off (#31596)

feat: use custom states for button and anchor button variants (#31718)

docs: add min-width styles to Table and DataGrid stories, add best practices (#31721)

fix:react-nav-preview: High contrast issues (#31704)

Pretty & lint & yarn change

Somehow missed change files

Fix one of the tests

Fix React-text test

Use hashed name for each semantic and control token

Build

missed one

Fix small mistake

Fix small mistake

Fix small mistake

Fix Random YML File

Fix rebase mistake

Fix mistake on number of quotes

Fix any possible merge conflicts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: Calendar Compat Calendar Compat component

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants