chore(react-components): split react libraries in two (/library and /stories) - cxe-prg#31565
Merged
Hotell merged 4 commits intomicrosoft:masterfrom Jun 6, 2024
Merged
Conversation
17 tasks
8d165fd to
03f25ad
Compare
Collaborator
📊 Bundle size reportUnchanged fixtures
|
fabricteam
reviewed
Jun 4, 2024
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| FluentProviderWithTheme | virtual-rerender | 29 | 36 | 10 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 626 | 618 | 5000 | |
| Button | mount | 311 | 295 | 5000 | |
| Field | mount | 1125 | 1136 | 5000 | |
| FluentProvider | mount | 707 | 697 | 5000 | |
| FluentProviderWithTheme | mount | 83 | 82 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 29 | 36 | 10 | Possible regression |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 76 | 75 | 10 | |
| MakeStyles | mount | 871 | 834 | 50000 | |
| Persona | mount | 1775 | 1689 | 5000 | |
| SpinButton | mount | 1385 | 1410 | 5000 | |
| SwatchPicker | mount | 1544 | 1536 | 5000 |
fabricteam
reviewed
Jun 4, 2024
Collaborator
Perf Analysis (
|
| Scenario | Current PR Ticks | Baseline Ticks | Ratio | Regression Analysis |
|---|---|---|---|---|
| ButtonMinimalPerf.default | 85 | 84 | 1.01:1 | analysis |
Perf tests with no regressions
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| AvatarMinimalPerf.default | 117 | 101 | 1.16:1 |
| CardMinimalPerf.default | 330 | 294 | 1.12:1 |
| PortalMinimalPerf.default | 92 | 82 | 1.12:1 |
| TreeWith60ListItems.default | 98 | 90 | 1.09:1 |
| GridMinimalPerf.default | 189 | 175 | 1.08:1 |
| LoaderMinimalPerf.default | 197 | 182 | 1.08:1 |
| RefMinimalPerf.default | 117 | 109 | 1.07:1 |
| BoxMinimalPerf.default | 203 | 191 | 1.06:1 |
| AlertMinimalPerf.default | 165 | 157 | 1.05:1 |
| AttachmentSlotsPerf.default | 677 | 642 | 1.05:1 |
| ChatWithPopoverPerf.default | 192 | 183 | 1.05:1 |
| CheckboxMinimalPerf.default | 1149 | 1099 | 1.05:1 |
| HeaderMinimalPerf.default | 213 | 203 | 1.05:1 |
| ItemLayoutMinimalPerf.default | 734 | 700 | 1.05:1 |
| ProviderMinimalPerf.default | 206 | 197 | 1.05:1 |
| SegmentMinimalPerf.default | 199 | 190 | 1.05:1 |
| AttachmentMinimalPerf.default | 84 | 81 | 1.04:1 |
| ButtonOverridesMissPerf.default | 668 | 642 | 1.04:1 |
| ButtonSlotsPerf.default | 321 | 308 | 1.04:1 |
| FlexMinimalPerf.default | 158 | 152 | 1.04:1 |
| InputMinimalPerf.default | 553 | 534 | 1.04:1 |
| AnimationMinimalPerf.default | 301 | 291 | 1.03:1 |
| ChatDuplicateMessagesPerf.default | 151 | 147 | 1.03:1 |
| DialogMinimalPerf.default | 449 | 436 | 1.03:1 |
| ListNestedPerf.default | 330 | 319 | 1.03:1 |
| StatusMinimalPerf.default | 401 | 389 | 1.03:1 |
| CarouselMinimalPerf.default | 261 | 257 | 1.02:1 |
| ListCommonPerf.default | 400 | 394 | 1.02:1 |
| MenuMinimalPerf.default | 500 | 492 | 1.02:1 |
| MenuButtonMinimalPerf.default | 961 | 938 | 1.02:1 |
| RadioGroupMinimalPerf.default | 257 | 253 | 1.02:1 |
| SplitButtonMinimalPerf.default | 2299 | 2254 | 1.02:1 |
| TextAreaMinimalPerf.default | 297 | 291 | 1.02:1 |
| TreeMinimalPerf.default | 478 | 470 | 1.02:1 |
| AccordionMinimalPerf.default | 84 | 83 | 1.01:1 |
| DropdownMinimalPerf.default | 1429 | 1411 | 1.01:1 |
| FormMinimalPerf.default | 220 | 217 | 1.01:1 |
| ListWith60ListItems.default | 370 | 366 | 1.01:1 |
| SkeletonMinimalPerf.default | 200 | 198 | 1.01:1 |
| TableManyItemsPerf.default | 1133 | 1126 | 1.01:1 |
| ToolbarMinimalPerf.default | 545 | 540 | 1.01:1 |
| TooltipMinimalPerf.default | 1286 | 1271 | 1.01:1 |
| VideoMinimalPerf.default | 448 | 443 | 1.01:1 |
| DatepickerMinimalPerf.default | 3603 | 3617 | 1:1 |
| DividerMinimalPerf.default | 203 | 202 | 1:1 |
| EmbedMinimalPerf.default | 1862 | 1861 | 1:1 |
| LabelMinimalPerf.default | 215 | 215 | 1:1 |
| ProviderMergeThemesPerf.default | 654 | 654 | 1:1 |
| TableMinimalPerf.default | 235 | 234 | 1:1 |
| CustomToolbarPrototype.default | 1454 | 1461 | 1:1 |
| DropdownManyItemsPerf.default | 397 | 401 | 0.99:1 |
| HeaderSlotsPerf.default | 452 | 457 | 0.99:1 |
| PopupMinimalPerf.default | 345 | 349 | 0.99:1 |
| TextMinimalPerf.default | 194 | 196 | 0.99:1 |
| ChatMinimalPerf.default | 422 | 430 | 0.98:1 |
| ImageMinimalPerf.default | 221 | 226 | 0.98:1 |
| RosterPerf.default | 1525 | 1562 | 0.98:1 |
| ReactionMinimalPerf.default | 211 | 216 | 0.98:1 |
| SliderMinimalPerf.default | 714 | 732 | 0.98:1 |
| IconMinimalPerf.default | 392 | 398 | 0.98:1 |
| ListMinimalPerf.default | 301 | 315 | 0.96:1 |
| LayoutMinimalPerf.default | 188 | 205 | 0.92:1 |
Collaborator
🕵 FluentUIV0 No visual regressions between this PR and main |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 619 | 631 | 5000 | |
| Breadcrumb | mount | 1687 | 1670 | 1000 | |
| Checkbox | mount | 1675 | 1710 | 5000 | |
| CheckboxBase | mount | 1463 | 1486 | 5000 | |
| ChoiceGroup | mount | 3025 | 2977 | 5000 | |
| ComboBox | mount | 694 | 709 | 1000 | |
| CommandBar | mount | 6442 | 6442 | 1000 | |
| ContextualMenu | mount | 11925 | 11451 | 1000 | |
| DefaultButton | mount | 801 | 790 | 5000 | |
| DetailsRow | mount | 2257 | 2229 | 5000 | |
| DetailsRowFast | mount | 2261 | 2268 | 5000 | |
| DetailsRowNoStyles | mount | 2035 | 2071 | 5000 | |
| Dialog | mount | 2823 | 2685 | 1000 | |
| DocumentCardTitle | mount | 229 | 240 | 1000 | |
| Dropdown | mount | 2024 | 1985 | 5000 | |
| FocusTrapZone | mount | 1128 | 1162 | 5000 | |
| FocusZone | mount | 1100 | 1118 | 5000 | |
| GroupedList | mount | 41939 | 42010 | 2 | |
| GroupedList | virtual-rerender | 17960 | 20111 | 2 | |
| GroupedList | virtual-rerender-with-unmount | 51088 | 51280 | 2 | |
| GroupedListV2 | mount | 228 | 225 | 2 | |
| GroupedListV2 | virtual-rerender | 210 | 208 | 2 | |
| GroupedListV2 | virtual-rerender-with-unmount | 230 | 234 | 2 | |
| IconButton | mount | 1146 | 1151 | 5000 | |
| Label | mount | 337 | 349 | 5000 | |
| Layer | mount | 2801 | 2739 | 5000 | |
| Link | mount | 390 | 410 | 5000 | |
| MenuButton | mount | 965 | 982 | 5000 | |
| MessageBar | mount | 21432 | 21433 | 5000 | |
| Nav | mount | 2026 | 1993 | 1000 | |
| OverflowSet | mount | 801 | 763 | 5000 | |
| Panel | mount | 1867 | 1835 | 1000 | |
| Persona | mount | 778 | 773 | 1000 | |
| Pivot | mount | 889 | 915 | 1000 | |
| PrimaryButton | mount | 918 | 936 | 5000 | |
| Rating | mount | 4705 | 4684 | 5000 | |
| SearchBox | mount | 954 | 927 | 5000 | |
| Shimmer | mount | 1905 | 1906 | 5000 | |
| Slider | mount | 1331 | 1336 | 5000 | |
| SpinButton | mount | 3011 | 2967 | 5000 | |
| Spinner | mount | 389 | 369 | 5000 | |
| SplitButton | mount | 1876 | 1863 | 5000 | |
| Stack | mount | 411 | 408 | 5000 | |
| StackWithIntrinsicChildren | mount | 853 | 854 | 5000 | |
| StackWithTextChildren | mount | 2634 | 2627 | 5000 | |
| SwatchColorPicker | mount | 6368 | 6359 | 5000 | |
| TagPicker | mount | 1473 | 1488 | 5000 | |
| Text | mount | 367 | 379 | 5000 | |
| TextField | mount | 940 | 951 | 5000 | |
| ThemeProvider | mount | 854 | 848 | 5000 | |
| ThemeProvider | virtual-rerender | 585 | 584 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1291 | 1283 | 5000 | |
| Toggle | mount | 606 | 621 | 5000 | |
| buttonNative | mount | 198 | 199 | 5000 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Contributor
Author
ling1726
approved these changes
Jun 5, 2024
62c0358 to
05b6848
Compare
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Collaborator
🕵 fluentuiv9 No visual regressions between this PR and main |
ValentinaKozlova
approved these changes
Jun 5, 2024
|
This has broken docs at https://react.fluentui.dev/?path=/docs/components-card-card--default |
miroslavstastny
pushed a commit
to miroslavstastny/fluentui
that referenced
this pull request
Jun 14, 2024
…stories) - cxe-prg (microsoft#31565)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Previous Behavior
New Behavior
Note
Based on RFC v9 react packages are split in two: #30514
Package/Scaffold changes:

yarn nx g @fluentui/workspace-plugin:split-library-in-two --project @fluentui/react-<name>Related Issue(s)