chore(Dialog): migrate to new motion APIs#31380
Merged
layershifter merged 5 commits intomicrosoft:masterfrom May 22, 2024
Merged
chore(Dialog): migrate to new motion APIs#31380layershifter merged 5 commits intomicrosoft:masterfrom
layershifter merged 5 commits intomicrosoft:masterfrom
Conversation
7186318 to
da83358
Compare
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| FluentProviderWithTheme | virtual-rerender | 30 | 39 | 10 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 627 | 643 | 5000 | |
| Button | mount | 321 | 315 | 5000 | |
| Field | mount | 1148 | 1138 | 5000 | |
| FluentProvider | mount | 717 | 718 | 5000 | |
| FluentProviderWithTheme | mount | 88 | 90 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 30 | 39 | 10 | Possible regression |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 71 | 74 | 10 | |
| MakeStyles | mount | 840 | 872 | 50000 | |
| Persona | mount | 1747 | 1733 | 5000 | |
| SpinButton | mount | 1379 | 1402 | 5000 | |
| SwatchPicker | mount | 1545 | 1541 | 5000 |
Collaborator
📊 Bundle size report
Unchanged fixtures
|
7118a08 to
99686f3
Compare
layershifter
commented
May 16, 2024
packages/react-components/react-dialog/src/contexts/dialogTransitionContext.ts
Outdated
Show resolved
Hide resolved
248389f to
fd4ddd9
Compare
robertpenner
approved these changes
May 16, 2024
Collaborator
robertpenner
left a comment
There was a problem hiding this comment.
The motion logic is so concise and easy to read now. 🥇
bsunderhus
reviewed
May 17, 2024
packages/react-components/react-dialog/src/components/Dialog/renderDialog.tsx
Show resolved
Hide resolved
packages/react-components/react-dialog/src/components/DialogSurface/useDialogSurface.ts
Show resolved
Hide resolved
bsunderhus
approved these changes
May 17, 2024
2 tasks
marcosmoura
approved these changes
May 22, 2024
…enderDialog.tsx Co-authored-by: Bernardo Sunderhus <bernardo.sunderhus@gmail.com>
a3a5f74 to
385b919
Compare
fabricteam
reviewed
May 22, 2024
| @@ -0,0 +1,7 @@ | |||
| { | |||
Collaborator
There was a problem hiding this comment.
🕵 fluentuiv9 Open the Visual Regressions report to inspect the affected screenshots
SwatchPicker Converged 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| SwatchPicker Converged.spacing.default.chromium.png | 0 | Removed |
miroslavstastny
pushed a commit
to miroslavstastny/fluentui
that referenced
this pull request
Jun 14, 2024
Co-authored-by: Bernardo Sunderhus <bernardo.sunderhus@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
Dialogusesreact-transition-groupfor animations.New Behavior
Dialoguses@fluentui/react-motions-previewfor animations.Related Issue(s)
Fixes #30041.
Fixes #30695.
Fixes #31369