chore(react-tag-picker): release stable version#31321
Merged
bsunderhus merged 2 commits intomicrosoft:masterfrom May 9, 2024
Merged
chore(react-tag-picker): release stable version#31321bsunderhus merged 2 commits intomicrosoft:masterfrom
bsunderhus merged 2 commits intomicrosoft:masterfrom
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 660 | 647 | 5000 | |
| Button | mount | 299 | 309 | 5000 | |
| Field | mount | 1115 | 1137 | 5000 | |
| FluentProvider | mount | 691 | 728 | 5000 | |
| FluentProviderWithTheme | mount | 82 | 81 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 35 | 37 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 80 | 73 | 10 | |
| MakeStyles | mount | 862 | 844 | 50000 | |
| Persona | mount | 1802 | 1686 | 5000 | |
| SpinButton | mount | 1371 | 1381 | 5000 | |
| SwatchPicker | mount | 1520 | 1526 | 5000 |
Collaborator
Perf Analysis (
|
| Scenario | Current PR Ticks | Baseline Ticks | Ratio | Regression Analysis |
|---|---|---|---|---|
| TreeWith60ListItems.default | 96 | 83 | 1.16:1 | analysis |
Perf tests with no regressions
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| PortalMinimalPerf.default | 94 | 82 | 1.15:1 |
| RefMinimalPerf.default | 120 | 104 | 1.15:1 |
| ImageMinimalPerf.default | 240 | 211 | 1.14:1 |
| FormMinimalPerf.default | 247 | 220 | 1.12:1 |
| ButtonMinimalPerf.default | 89 | 82 | 1.09:1 |
| BoxMinimalPerf.default | 205 | 190 | 1.08:1 |
| GridMinimalPerf.default | 199 | 184 | 1.08:1 |
| ListNestedPerf.default | 337 | 311 | 1.08:1 |
| TableMinimalPerf.default | 257 | 238 | 1.08:1 |
| DropdownManyItemsPerf.default | 400 | 375 | 1.07:1 |
| FlexMinimalPerf.default | 158 | 149 | 1.06:1 |
| ListWith60ListItems.default | 372 | 352 | 1.06:1 |
| SegmentMinimalPerf.default | 201 | 190 | 1.06:1 |
| AlertMinimalPerf.default | 159 | 152 | 1.05:1 |
| AttachmentSlotsPerf.default | 658 | 625 | 1.05:1 |
| CarouselMinimalPerf.default | 268 | 255 | 1.05:1 |
| ChatWithPopoverPerf.default | 200 | 190 | 1.05:1 |
| CardMinimalPerf.default | 322 | 311 | 1.04:1 |
| DividerMinimalPerf.default | 208 | 200 | 1.04:1 |
| ItemLayoutMinimalPerf.default | 713 | 688 | 1.04:1 |
| RosterPerf.default | 1614 | 1551 | 1.04:1 |
| ReactionMinimalPerf.default | 216 | 207 | 1.04:1 |
| AttachmentMinimalPerf.default | 79 | 77 | 1.03:1 |
| ButtonOverridesMissPerf.default | 655 | 636 | 1.03:1 |
| TooltipMinimalPerf.default | 1287 | 1245 | 1.03:1 |
| VideoMinimalPerf.default | 445 | 432 | 1.03:1 |
| ChatMinimalPerf.default | 443 | 436 | 1.02:1 |
| CheckboxMinimalPerf.default | 1162 | 1137 | 1.02:1 |
| DatepickerMinimalPerf.default | 3699 | 3638 | 1.02:1 |
| EmbedMinimalPerf.default | 1879 | 1844 | 1.02:1 |
| ListCommonPerf.default | 392 | 383 | 1.02:1 |
| MenuMinimalPerf.default | 515 | 505 | 1.02:1 |
| ToolbarMinimalPerf.default | 548 | 535 | 1.02:1 |
| DialogMinimalPerf.default | 444 | 438 | 1.01:1 |
| HeaderSlotsPerf.default | 455 | 449 | 1.01:1 |
| SplitButtonMinimalPerf.default | 2277 | 2265 | 1.01:1 |
| TableManyItemsPerf.default | 1117 | 1102 | 1.01:1 |
| TextMinimalPerf.default | 198 | 196 | 1.01:1 |
| TextAreaMinimalPerf.default | 289 | 285 | 1.01:1 |
| AnimationMinimalPerf.default | 310 | 309 | 1:1 |
| DropdownMinimalPerf.default | 1437 | 1441 | 1:1 |
| ListMinimalPerf.default | 296 | 296 | 1:1 |
| MenuButtonMinimalPerf.default | 946 | 947 | 1:1 |
| PopupMinimalPerf.default | 348 | 349 | 1:1 |
| RadioGroupMinimalPerf.default | 260 | 261 | 1:1 |
| SkeletonMinimalPerf.default | 202 | 202 | 1:1 |
| IconMinimalPerf.default | 385 | 385 | 1:1 |
| TreeMinimalPerf.default | 478 | 480 | 1:1 |
| AvatarMinimalPerf.default | 105 | 106 | 0.99:1 |
| ButtonSlotsPerf.default | 306 | 310 | 0.99:1 |
| InputMinimalPerf.default | 535 | 539 | 0.99:1 |
| LabelMinimalPerf.default | 220 | 222 | 0.99:1 |
| ProviderMergeThemesPerf.default | 632 | 638 | 0.99:1 |
| CustomToolbarPrototype.default | 1469 | 1478 | 0.99:1 |
| LoaderMinimalPerf.default | 187 | 190 | 0.98:1 |
| ProviderMinimalPerf.default | 200 | 204 | 0.98:1 |
| SliderMinimalPerf.default | 747 | 761 | 0.98:1 |
| StatusMinimalPerf.default | 388 | 397 | 0.98:1 |
| LayoutMinimalPerf.default | 202 | 208 | 0.97:1 |
| HeaderMinimalPerf.default | 204 | 214 | 0.95:1 |
| ChatDuplicateMessagesPerf.default | 140 | 149 | 0.94:1 |
| AccordionMinimalPerf.default | 71 | 92 | 0.77:1 |
YuanboXue-Amber
approved these changes
May 9, 2024
Collaborator
📊 Bundle size reportUnchanged fixtures
|
Collaborator
🕵 FluentUIV0 No visual regressions between this PR and main |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 644 | 621 | 5000 | |
| Breadcrumb | mount | 1694 | 1695 | 1000 | |
| Checkbox | mount | 1702 | 1735 | 5000 | |
| CheckboxBase | mount | 1487 | 1476 | 5000 | |
| ChoiceGroup | mount | 2951 | 2959 | 5000 | |
| ComboBox | mount | 676 | 685 | 1000 | |
| CommandBar | mount | 6583 | 6595 | 1000 | |
| ContextualMenu | mount | 14277 | 14639 | 1000 | |
| DefaultButton | mount | 806 | 817 | 5000 | |
| DetailsRow | mount | 2239 | 2245 | 5000 | |
| DetailsRowFast | mount | 2256 | 2256 | 5000 | |
| DetailsRowNoStyles | mount | 2026 | 2063 | 5000 | |
| Dialog | mount | 2771 | 2720 | 1000 | |
| DocumentCardTitle | mount | 244 | 234 | 1000 | |
| Dropdown | mount | 2001 | 2006 | 5000 | |
| FocusTrapZone | mount | 1146 | 1173 | 5000 | |
| FocusZone | mount | 1090 | 1084 | 5000 | |
| GroupedList | mount | 42317 | 42415 | 2 | |
| GroupedList | virtual-rerender | 18240 | 20512 | 2 | |
| GroupedList | virtual-rerender-with-unmount | 51019 | 51564 | 2 | |
| GroupedListV2 | mount | 231 | 233 | 2 | |
| GroupedListV2 | virtual-rerender | 215 | 207 | 2 | |
| GroupedListV2 | virtual-rerender-with-unmount | 229 | 233 | 2 | |
| IconButton | mount | 1141 | 1162 | 5000 | |
| Label | mount | 340 | 348 | 5000 | |
| Layer | mount | 2727 | 2759 | 5000 | |
| Link | mount | 392 | 399 | 5000 | |
| MenuButton | mount | 968 | 998 | 5000 | |
| MessageBar | mount | 21464 | 21548 | 5000 | |
| Nav | mount | 2069 | 2052 | 1000 | |
| OverflowSet | mount | 802 | 778 | 5000 | |
| Panel | mount | 1807 | 1813 | 1000 | |
| Persona | mount | 735 | 759 | 1000 | |
| Pivot | mount | 876 | 894 | 1000 | |
| PrimaryButton | mount | 929 | 915 | 5000 | |
| Rating | mount | 4631 | 4678 | 5000 | |
| SearchBox | mount | 922 | 904 | 5000 | |
| Shimmer | mount | 1940 | 1910 | 5000 | |
| Slider | mount | 1339 | 1352 | 5000 | |
| SpinButton | mount | 3006 | 2975 | 5000 | |
| Spinner | mount | 395 | 396 | 5000 | |
| SplitButton | mount | 1858 | 1909 | 5000 | |
| Stack | mount | 405 | 407 | 5000 | |
| StackWithIntrinsicChildren | mount | 849 | 866 | 5000 | |
| StackWithTextChildren | mount | 2626 | 2641 | 5000 | |
| SwatchColorPicker | mount | 6310 | 6337 | 5000 | |
| TagPicker | mount | 1472 | 1483 | 5000 | |
| Text | mount | 376 | 376 | 5000 | |
| TextField | mount | 953 | 912 | 5000 | |
| ThemeProvider | mount | 850 | 832 | 5000 | |
| ThemeProvider | virtual-rerender | 582 | 576 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1289 | 1275 | 5000 | |
| Toggle | mount | 623 | 604 | 5000 | |
| buttonNative | mount | 185 | 186 | 5000 |
Collaborator
🕵 fluentuiv9 No visual regressions between this PR and main |
Hotell
reviewed
May 9, 2024
packages/react-components/react-tag-picker/bundle-size/Package.fixture.js
Show resolved
Hide resolved
Hotell
approved these changes
May 9, 2024
JustSlone
approved these changes
May 9, 2024
spmonahan
reviewed
May 9, 2024
spmonahan
approved these changes
May 9, 2024
089d770 to
852a2fc
Compare
Collaborator
🕵 fluentuiv8 No visual regressions between this PR and main |
miroslavstastny
pushed a commit
to miroslavstastny/fluentui
that referenced
this pull request
Jun 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Previous Behavior
New Behavior
Follows up on Stable release for
@fluentui/react-tag-pickerpackageRelated Issue(s)