chore: merge web-components-v3 feature branch by chrisdholt · Pull Request #31288 · microsoft/fluentui

chrisdholt · 2024-05-06T22:04:39Z

Previous Behavior

Development was done in a feature branch.

New Behavior

This PR merges the feature branch into master.

Related Issue(s)

Fixes #

.github/CODEOWNERS

TristanWatanabe · 2024-05-06T22:15:44Z

/azp run

fabricteam · 2024-05-06T22:16:07Z

📊 Bundle size report

✅ No changes found

azure-pipelines · 2024-05-06T22:16:09Z

Azure Pipelines successfully started running 4 pipeline(s).

codesandbox-ci · 2024-05-06T22:16:09Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

fabricteam · 2024-05-06T22:17:38Z

Perf Analysis (`@fluentui/react-components`)

Scenario	Render type	Master Ticks	PR Ticks	Iterations	Status
FluentProviderWithTheme	virtual-rerender	36	36	10	Possible regression

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations	Status
Avatar	mount	613	647	5000
Button	mount	308	296	5000
Field	mount	1139	1143	5000
FluentProvider	mount	704	709	5000
FluentProviderWithTheme	mount	70	86	10
FluentProviderWithTheme	virtual-rerender	36	36	10	Possible regression
FluentProviderWithTheme	virtual-rerender-with-unmount	82	81	10
MakeStyles	mount	850	867	50000
Persona	mount	1744	1740	5000
SpinButton	mount	1390	1449	5000
SwatchPicker	mount	1495	1556	5000

fabricteam · 2024-05-06T22:19:47Z

Perf Analysis (`@fluentui/react-northstar`)

Perf tests with no regressions

Scenario	Current PR Ticks	Baseline Ticks	Ratio
AccordionMinimalPerf.default	93	72	1.29:1
PortalMinimalPerf.default	99	80	1.24:1
SkeletonMinimalPerf.default	220	199	1.11:1
SegmentMinimalPerf.default	206	189	1.09:1
ChatDuplicateMessagesPerf.default	172	160	1.08:1
RefMinimalPerf.default	114	106	1.08:1
ButtonMinimalPerf.default	95	89	1.07:1
ButtonSlotsPerf.default	339	316	1.07:1
LabelMinimalPerf.default	228	213	1.07:1
LayoutMinimalPerf.default	205	191	1.07:1
ProviderMinimalPerf.default	208	194	1.07:1
CarouselMinimalPerf.default	270	254	1.06:1
ImageMinimalPerf.default	231	218	1.06:1
StatusMinimalPerf.default	414	391	1.06:1
IconMinimalPerf.default	388	365	1.06:1
TreeWith60ListItems.default	94	89	1.06:1
ChatMinimalPerf.default	464	441	1.05:1
ChatWithPopoverPerf.default	205	196	1.05:1
GridMinimalPerf.default	196	187	1.05:1
ListCommonPerf.default	407	386	1.05:1
AttachmentMinimalPerf.default	85	82	1.04:1
FlexMinimalPerf.default	157	151	1.04:1
SliderMinimalPerf.default	773	744	1.04:1
AnimationMinimalPerf.default	303	294	1.03:1
CheckboxMinimalPerf.default	1175	1145	1.03:1
HeaderMinimalPerf.default	214	207	1.03:1
ListWith60ListItems.default	374	362	1.03:1
TextAreaMinimalPerf.default	282	274	1.03:1
CardMinimalPerf.default	314	308	1.02:1
DatepickerMinimalPerf.default	3739	3669	1.02:1
DropdownManyItemsPerf.default	400	393	1.02:1
HeaderSlotsPerf.default	487	476	1.02:1
InputMinimalPerf.default	545	535	1.02:1
RosterPerf.default	1590	1565	1.02:1
SplitButtonMinimalPerf.default	2310	2266	1.02:1
FormMinimalPerf.default	232	229	1.01:1
ReactionMinimalPerf.default	214	211	1.01:1
CustomToolbarPrototype.default	1488	1477	1.01:1
TreeMinimalPerf.default	482	478	1.01:1
AttachmentSlotsPerf.default	654	651	1:1
DialogMinimalPerf.default	445	445	1:1
DropdownMinimalPerf.default	1442	1448	1:1
EmbedMinimalPerf.default	1883	1877	1:1
ListMinimalPerf.default	306	306	1:1
MenuMinimalPerf.default	511	513	1:1
RadioGroupMinimalPerf.default	260	261	1:1
TableMinimalPerf.default	232	232	1:1
VideoMinimalPerf.default	444	443	1:1
AlertMinimalPerf.default	160	162	0.99:1
DividerMinimalPerf.default	199	201	0.99:1
MenuButtonMinimalPerf.default	947	957	0.99:1
TableManyItemsPerf.default	1095	1109	0.99:1
ButtonOverridesMissPerf.default	634	647	0.98:1
ItemLayoutMinimalPerf.default	710	722	0.98:1
ListNestedPerf.default	322	329	0.98:1
ProviderMergeThemesPerf.default	650	664	0.98:1
TooltipMinimalPerf.default	1258	1289	0.98:1
PopupMinimalPerf.default	335	347	0.97:1
TextMinimalPerf.default	190	196	0.97:1
BoxMinimalPerf.default	185	192	0.96:1
LoaderMinimalPerf.default	190	197	0.96:1
ToolbarMinimalPerf.default	533	558	0.96:1
AvatarMinimalPerf.default	102	111	0.92:1

fabricteam · 2024-05-06T22:31:25Z

Perf Analysis (`@fluentui/react`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
BaseButton	mount	629	617	5000
Breadcrumb	mount	1675	1650	1000
Checkbox	mount	1674	1698	5000
CheckboxBase	mount	1509	1467	5000
ChoiceGroup	mount	2979	3034	5000
ComboBox	mount	660	679	1000
CommandBar	mount	6442	6445	1000
ContextualMenu	mount	11414	11704	1000
DefaultButton	mount	798	814	5000
DetailsRow	mount	2215	2214	5000
DetailsRowFast	mount	2203	2232	5000
DetailsRowNoStyles	mount	2063	1999	5000
Dialog	mount	2780	2708	1000
DocumentCardTitle	mount	226	241	1000
Dropdown	mount	2014	2007	5000
FocusTrapZone	mount	1112	1153	5000
FocusZone	mount	1082	1055	5000
GroupedList	mount	41928	41886	2
GroupedList	virtual-rerender	18046	20107	2
GroupedList	virtual-rerender-with-unmount	50522	50572	2
GroupedListV2	mount	227	235	2
GroupedListV2	virtual-rerender	206	217	2
GroupedListV2	virtual-rerender-with-unmount	229	221	2
IconButton	mount	1117	1122	5000
Label	mount	351	344	5000
Layer	mount	2792	2786	5000
Link	mount	402	388	5000
MenuButton	mount	976	958	5000
MessageBar	mount	21568	21645	5000
Nav	mount	2055	2034	1000
OverflowSet	mount	798	777	5000
Panel	mount	1808	1820	1000
Persona	mount	760	741	1000
Pivot	mount	864	878	1000
PrimaryButton	mount	910	919	5000
Rating	mount	4676	4738	5000
SearchBox	mount	894	914	5000
Shimmer	mount	1890	1870	5000
Slider	mount	1330	1340	5000
SpinButton	mount	3007	3007	5000
Spinner	mount	384	380	5000
SplitButton	mount	1918	1829	5000
Stack	mount	416	408	5000
StackWithIntrinsicChildren	mount	877	850	5000
StackWithTextChildren	mount	2618	2684	5000
SwatchColorPicker	mount	6268	6347	5000
TagPicker	mount	1435	1458	5000
Text	mount	371	379	5000
TextField	mount	942	930	5000
ThemeProvider	mount	831	826	5000
ThemeProvider	virtual-rerender	574	593	5000
ThemeProvider	virtual-rerender-with-unmount	1263	1296	5000
Toggle	mount	624	595	5000
buttonNative	mount	195	182	5000

.github/CODEOWNERS

tools/workspace-plugin/src/generators/normalize-package-dependencies/index.ts

apps/vr-tests-web-components/package.json

apps/stress-test/package.json

apps/public-docsite-v9/.storybook/docs-root-v9.css

apps/public-docsite-v9/.storybook/manager-head.html

packages/web-components/.npmignore

packages/web-components/package.json

packages/web-components/public/shell.css

apps/vr-tests-web-components/jest.config.cjs

apps/vr-tests-web-components/tsconfig.json

apps/vr-tests-web-components/package.json

Hotell · 2024-05-07T10:59:03Z

Besides providing comments in this PR ( some of them are blockers ) we need to bring in this PR #31296

packages/web-components/scripts/run-benchmarks.js

+  for (const file of benchFiles) {
+    try {
+      // eslint-disable-next-line no-undef
+      execSync(`tensile --file ./${file} --config ${tensileConfig} ${process.argv[2]}`, { stdio: 'inherit' });


…1296)

chrisdholt · 2024-05-10T18:25:04Z

Besides providing comments in this PR ( some of them are blockers ) we need to bring in this PR #31296

Thank you!

…31336)

Hotell · 2024-05-13T12:43:55Z

Required to merge to unblock this PR: #31348
Follow-up Epic: #31349

…#31348)

JustSlone

Thanks @chrisdholt @radium-v @Hotell @TristanWatanabe @spmonahan and all that helped get this ready to go!

chrisdholt · 2024-05-13T17:58:45Z

/azp run

azure-pipelines · 2024-05-13T17:59:16Z

Azure Pipelines successfully started running 4 pipeline(s).

.github/CODEOWNERS

fabricteam · 2024-05-13T20:51:53Z

🕵 fluentuiv8 No visual regressions between this PR and main

JustSlone · 2024-05-13T21:49:59Z

[celebrate] Justin Slone reacted to your message:

…

________________________________

Co-authored-by: Miroslav Stastny <miroslav.stastny@microsoft.com> Co-authored-by: Martin Hochel <martinhochel@microsoft.com> Co-authored-by: Ryan Merrill <ryanmerrill@microsoft.com> Co-authored-by: Fluent UI Build <fluentui-internal@service.microsoft.com> Co-authored-by: ling1726 <lingfangao@hotmail.com> Co-authored-by: Justin Slone <40304143+JustSlone@users.noreply.github.com> Co-authored-by: BrdyBrn <brian.christopher.brady@gmail.com> Co-authored-by: Tudor Popa <97875118+tudorpopams@users.noreply.github.com> Co-authored-by: Hale Rankin <harankin@microsoft.com> Co-authored-by: Miroslav Stastny <mistastn@microsoft.com> Co-authored-by: Levi Thomason <me@levithomason.com> Co-authored-by: Jeff Smith <37851214+eljefe223@users.noreply.github.com> Co-authored-by: bearcat-msft <90428651+bearcat-msft@users.noreply.github.com> Co-authored-by: Tristan Watanabe <tristan.watanabe@gmail.com> Co-authored-by: Devjoyti Barman <53661347+Devjoyti-Barman@users.noreply.github.com> Co-authored-by: Mohamed Mansour <mmansour@microsoft.com> Co-authored-by: Hale Rankin <hale.rankin@microsoft.com> Co-authored-by: Danny van Velzen <dannyvv@microsoft.com> Co-authored-by: Sean Monahan <seanmonahan@microsoft.com> Co-authored-by: John Kreitlow <863023+radium-v@users.noreply.github.com>

chrisdholt requested review from a team, JustSlone, jurokapsiar, micahgodbolt, spmonahan and tudorpopams as code owners May 6, 2024 22:04

fabricteam reviewed May 6, 2024

View reviewed changes

.github/CODEOWNERS Show resolved Hide resolved

fabricteam reviewed May 6, 2024

View reviewed changes

.github/CODEOWNERS Show resolved Hide resolved

fabricteam reviewed May 6, 2024

View reviewed changes

.github/CODEOWNERS Show resolved Hide resolved

Hotell mentioned this pull request May 7, 2024

feat(workspace-plugin): make normalize-package-dependencies generic and faster #31293

Merged

Hotell reviewed May 7, 2024

View reviewed changes

tools/workspace-plugin/src/generators/normalize-package-dependencies/index.ts Outdated Show resolved Hide resolved

Hotell mentioned this pull request May 7, 2024

chore: wc-3 changes necessary in order to bring it back to master #31296

Merged

Hotell reviewed May 7, 2024

View reviewed changes

apps/vr-tests-web-components/jest.config.cjs Outdated Show resolved Hide resolved

Hotell reviewed May 7, 2024

View reviewed changes

apps/vr-tests-web-components/tsconfig.json Outdated Show resolved Hide resolved

Hotell reviewed May 7, 2024

View reviewed changes

apps/vr-tests-web-components/package.json Outdated Show resolved Hide resolved

spmonahan mentioned this pull request May 7, 2024

chore: remove stress-test app #31301

Merged

github-advanced-security bot found potential problems May 7, 2024

View reviewed changes

radium-v force-pushed the web-components-v3 branch from 707be68 to 3ba33e2 Compare May 8, 2024 00:35

radium-v and others added 4 commits May 10, 2024 11:12

sync change directory

4b16c70

resolve workspace lint

79ccd5e

chore: wc-3 changes necessary in order to bring it back to master (#3…

a2c8be9

…1296)

[web-components-v3] Revert storybook modifications (#31332)

cb6fdf3

radium-v force-pushed the web-components-v3 branch from 8f49a44 to cb6fdf3 Compare May 10, 2024 18:22

chrisdholt mentioned this pull request May 10, 2024

chore: remove types from tsconfig in vr tests and remove jest config #31336

Merged

chore: remove types from tsconfig in vr tests and remove jest config (#…

becdc34

…31336)

spmonahan approved these changes May 10, 2024

View reviewed changes

This was referenced May 13, 2024

chore: wc-3 tweaks to pass type-checking and cleanup task definitions #31348

Merged

[Feature]: wc-3 in master infra/setup follow-up #31349

Closed

chore: wc-3 tweaks to pass type-checking and cleanup task definitions (…

4a6f16b

…#31348)

Hotell approved these changes May 13, 2024

View reviewed changes

JustSlone approved these changes May 13, 2024

View reviewed changes

chrisdholt added 3 commits May 13, 2024 12:03

chore(web-components): fix web component vr tests type-checking (#31353)

a6cb564

Merge branch 'master' into web-components-v3

2a0db9a

Merge branch 'master' into web-components-v3

c975fec

chrisdholt enabled auto-merge (squash) May 13, 2024 19:59

fabricteam reviewed May 13, 2024

View reviewed changes

.github/CODEOWNERS Show resolved Hide resolved

Merge branch 'master' into web-components-v3

53e259b

eljefe223 approved these changes May 13, 2024

View reviewed changes

chrisdholt merged commit f9e93df into master May 13, 2024
14 checks passed

smhigley mentioned this pull request May 17, 2024

chore:(docs) - Adds type check to command cheat sheet #31411

Merged

Hotell deleted the web-components-v3 branch March 17, 2025 17:17

Conversation

chrisdholt commented May 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Previous Behavior

New Behavior

Related Issue(s)

Uh oh!

Uh oh!

TristanWatanabe commented May 6, 2024

Uh oh!

fabricteam commented May 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Bundle size report

Uh oh!

azure-pipelines bot commented May 6, 2024

Uh oh!

codesandbox-ci bot commented May 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fabricteam commented May 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Perf Analysis (@fluentui/react-components)

Uh oh!

fabricteam commented May 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Perf Analysis (@fluentui/react-northstar)

Uh oh!

fabricteam commented May 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Perf Analysis (@fluentui/react)

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Hotell commented May 7, 2024

Uh oh!

Check warning

chrisdholt commented May 10, 2024

Uh oh!

Hotell commented May 13, 2024

Uh oh!

JustSlone left a comment

Choose a reason for hiding this comment

Uh oh!

chrisdholt commented May 13, 2024

Uh oh!

azure-pipelines bot commented May 13, 2024

Uh oh!

Uh oh!

fabricteam commented May 13, 2024

🕵 fluentuiv8 No visual regressions between this PR and main

Uh oh!

Uh oh!

JustSlone commented May 13, 2024 via email • edited by microsoft-github-policy-service bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

19 participants

chrisdholt commented May 6, 2024 •

edited

Loading

fabricteam commented May 6, 2024 •

edited

Loading

codesandbox-ci bot commented May 6, 2024 •

edited

Loading

fabricteam commented May 6, 2024 •

edited

Loading

Perf Analysis (`@fluentui/react-components`)

fabricteam commented May 6, 2024 •

edited

Loading

Perf Analysis (`@fluentui/react-northstar`)

fabricteam commented May 6, 2024 •

edited

Loading

Perf Analysis (`@fluentui/react`)

JustSlone commented May 13, 2024 via email •

edited by microsoft-github-policy-service bot

Loading