Measure "all up" bundle size for @fluentui/react and @fluentui/react-components#31110
Merged
spmonahan merged 2 commits intomicrosoft:masterfrom Apr 18, 2024
Merged
Conversation
This allows us to better understand the bundle size impact of changes to folks using multiple components in the library.
@fluentui/react and @fluentui/react-components
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
khmakoto
approved these changes
Apr 18, 2024
Collaborator
🕵 fluentuiv8 No visual regressions between this PR and main |
Collaborator
📊 Bundle size report
Unchanged fixtures
|
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 656 | 639 | 5000 | |
| Button | mount | 313 | 312 | 5000 | |
| Field | mount | 1155 | 1181 | 5000 | |
| FluentProvider | mount | 741 | 749 | 5000 | |
| FluentProviderWithTheme | mount | 83 | 80 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 33 | 32 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 91 | 98 | 10 | |
| MakeStyles | mount | 863 | 883 | 50000 | |
| Persona | mount | 1792 | 1821 | 5000 | |
| SpinButton | mount | 1429 | 1412 | 5000 | |
| SwatchPicker | mount | 1569 | 1568 | 5000 |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 624 | 628 | 5000 | |
| Breadcrumb | mount | 1748 | 1717 | 1000 | |
| Checkbox | mount | 1705 | 1708 | 5000 | |
| CheckboxBase | mount | 1460 | 1493 | 5000 | |
| ChoiceGroup | mount | 2975 | 2927 | 5000 | |
| ComboBox | mount | 637 | 646 | 1000 | |
| CommandBar | mount | 6366 | 6321 | 1000 | |
| ContextualMenu | mount | 14186 | 13694 | 1000 | |
| DefaultButton | mount | 766 | 796 | 5000 | |
| DetailsRow | mount | 2217 | 2183 | 5000 | |
| DetailsRowFast | mount | 2205 | 2233 | 5000 | |
| DetailsRowNoStyles | mount | 2054 | 2024 | 5000 | |
| Dialog | mount | 2765 | 2718 | 1000 | |
| DocumentCardTitle | mount | 236 | 232 | 1000 | |
| Dropdown | mount | 1999 | 2014 | 5000 | |
| FocusTrapZone | mount | 1182 | 1153 | 5000 | |
| FocusZone | mount | 1111 | 1094 | 5000 | |
| GroupedList | mount | 37469 | 41686 | 2 | |
| GroupedList | virtual-rerender | 17870 | 20232 | 2 | |
| GroupedList | virtual-rerender-with-unmount | 51129 | 50971 | 2 | |
| GroupedListV2 | mount | 225 | 229 | 2 | |
| GroupedListV2 | virtual-rerender | 217 | 219 | 2 | |
| GroupedListV2 | virtual-rerender-with-unmount | 214 | 233 | 2 | |
| IconButton | mount | 1075 | 1093 | 5000 | |
| Label | mount | 343 | 342 | 5000 | |
| Layer | mount | 2732 | 2744 | 5000 | |
| Link | mount | 395 | 387 | 5000 | |
| MenuButton | mount | 956 | 913 | 5000 | |
| MessageBar | mount | 21884 | 21919 | 5000 | |
| Nav | mount | 1952 | 1969 | 1000 | |
| OverflowSet | mount | 792 | 758 | 5000 | |
| Panel | mount | 1817 | 1747 | 1000 | |
| Persona | mount | 724 | 792 | 1000 | |
| Pivot | mount | 872 | 867 | 1000 | |
| PrimaryButton | mount | 863 | 835 | 5000 | |
| Rating | mount | 4643 | 4711 | 5000 | |
| SearchBox | mount | 913 | 948 | 5000 | |
| Shimmer | mount | 1909 | 1906 | 5000 | |
| Slider | mount | 1308 | 1356 | 5000 | |
| SpinButton | mount | 2896 | 2867 | 5000 | |
| Spinner | mount | 391 | 390 | 5000 | |
| SplitButton | mount | 1855 | 1869 | 5000 | |
| Stack | mount | 407 | 409 | 5000 | |
| StackWithIntrinsicChildren | mount | 877 | 855 | 5000 | |
| StackWithTextChildren | mount | 2609 | 2613 | 5000 | |
| SwatchColorPicker | mount | 6242 | 6235 | 5000 | |
| TagPicker | mount | 1455 | 1460 | 5000 | |
| Text | mount | 373 | 359 | 5000 | |
| TextField | mount | 930 | 945 | 5000 | |
| ThemeProvider | mount | 847 | 838 | 5000 | |
| ThemeProvider | virtual-rerender | 587 | 593 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1288 | 1287 | 5000 | |
| Toggle | mount | 596 | 618 | 5000 | |
| buttonNative | mount | 184 | 189 | 5000 |
@fluentui/react and @fluentui/react-components@fluentui/react and @fluentui/react-components
miroslavstastny
pushed a commit
to miroslavstastny/fluentui
that referenced
this pull request
Jun 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
We measured bundle size for individual components but not for the entire library.
New Behavior
We now measure the bundle size of the entire library. This will give us better insight into how changes affect bundle size in applications as most users a likely to use many components from the library rather than a single one.
Related Issue(s)
This came out of #30689 as we want to understand the overall bundle size impact of the shadow DOM feature in Fluent v8.