Skip to content

feat(react-tag-picker-preview): adds SecondaryAction#30829

Merged
bsunderhus merged 2 commits intomicrosoft:masterfrom
bsunderhus:react-tag-picker/feat--secondary-action
Mar 26, 2024
Merged

feat(react-tag-picker-preview): adds SecondaryAction#30829
bsunderhus merged 2 commits intomicrosoft:masterfrom
bsunderhus:react-tag-picker/feat--secondary-action

Conversation

@bsunderhus
Copy link
Contributor

@bsunderhus bsunderhus commented Mar 20, 2024

Previous Behavior

New Behavior

  1. Adds internal aside slot
  2. Adds secondaryAction slot
  3. moves expandIcon slot to TagPickerControl

Related Issue(s)

  • Fixes #

TODO:

  1. Better discuss with design team

@bsunderhus bsunderhus self-assigned this Mar 20, 2024
@github-actions github-actions bot added this to the March Project Cycle Q1 2024 milestone Mar 20, 2024
@fabricteam
Copy link
Collaborator

fabricteam commented Mar 20, 2024

📊 Bundle size report

🤖 This report was generated against 10e6d9d6e75da57fa7728acffbd7eed06f7f9fa6

@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 20, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@bsunderhus bsunderhus force-pushed the react-tag-picker/feat--secondary-action branch from c411205 to bcc71dc Compare March 20, 2024 12:26
@bsunderhus bsunderhus mentioned this pull request Mar 20, 2024
46 tasks
@bsunderhus bsunderhus force-pushed the react-tag-picker/feat--secondary-action branch 3 times, most recently from 89bad53 to 37e272d Compare March 21, 2024 09:00
@bsunderhus bsunderhus force-pushed the react-tag-picker/feat--secondary-action branch 2 times, most recently from 679f20b to 57419ab Compare March 25, 2024 12:43
@bsunderhus bsunderhus marked this pull request as ready for review March 25, 2024 13:39
@bsunderhus bsunderhus requested a review from a team as a code owner March 25, 2024 13:39
@bsunderhus bsunderhus force-pushed the react-tag-picker/feat--secondary-action branch from 57419ab to 2bc8931 Compare March 25, 2024 19:03
@bsunderhus bsunderhus force-pushed the react-tag-picker/feat--secondary-action branch from 2bc8931 to e46a059 Compare March 25, 2024 19:03
@bsunderhus bsunderhus requested a review from ling1726 March 25, 2024 19:04
@bsunderhus bsunderhus merged commit f51fea2 into microsoft:master Mar 26, 2024
robertpenner pushed a commit to robertpenner/fluentui that referenced this pull request Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants