chore(input): Increase hit target of input element to fill to the border#30825
Merged
behowell merged 2 commits intomicrosoft:masterfrom Mar 19, 2024
Merged
chore(input): Increase hit target of input element to fill to the border#30825behowell merged 2 commits intomicrosoft:masterfrom
behowell merged 2 commits intomicrosoft:masterfrom
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 640 | 674 | 5000 | |
| Button | mount | 299 | 308 | 5000 | |
| Field | mount | 1176 | 1199 | 5000 | |
| FluentProvider | mount | 765 | 754 | 5000 | |
| FluentProviderWithTheme | mount | 80 | 89 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 60 | 61 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 75 | 81 | 10 | |
| MakeStyles | mount | 909 | 918 | 50000 | |
| Persona | mount | 1841 | 1793 | 5000 | |
| SpinButton | mount | 1447 | 1480 | 5000 |
Collaborator
📊 Bundle size report
Unchanged fixtures
|
Collaborator
🕵 fluentuiv9 No visual regressions between this PR and main |
spmonahan
approved these changes
Mar 19, 2024
robertpenner
pushed a commit
to robertpenner/fluentui
that referenced
this pull request
Apr 11, 2024
…der (microsoft#30825) Combine the padding from the `root` and `input` slots onto just the `input` itself. This expands the hit target of the input to extend to the borders of the `root`. If there is `contentBefore` or `contentAfter`, the original padding values are used to make sure everything aligns appropriately.
Closed
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
The Input control had padding on the root div, which reduced the size of the true input element, and reduced its hit target to not fill the entire space.
New Behavior
Combine the padding from the
rootandinputslots onto just theinputitself. This expands the hit target of the input to extend to the borders of theroot.If there is
contentBeforeorcontentAfter, the original padding values are used to make sure everything aligns appropriately.Related Issue(s)