fix(foundation-legacy): Fix build errors in TypeScript 5.3.3#30808
Merged
behowell merged 1 commit intomicrosoft:masterfrom Mar 21, 2024
Merged
fix(foundation-legacy): Fix build errors in TypeScript 5.3.3#30808behowell merged 1 commit intomicrosoft:masterfrom
behowell merged 1 commit intomicrosoft:masterfrom
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Collaborator
🕵 fluentuiv8 No visual regressions between this PR and main |
Collaborator
📊 Bundle size reportUnchanged fixtures
|
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 634 | 626 | 5000 | |
| Breadcrumb | mount | 1655 | 1679 | 1000 | |
| Checkbox | mount | 1680 | 1702 | 5000 | |
| CheckboxBase | mount | 1488 | 1485 | 5000 | |
| ChoiceGroup | mount | 2964 | 2924 | 5000 | |
| ComboBox | mount | 661 | 673 | 1000 | |
| CommandBar | mount | 6156 | 6163 | 1000 | |
| ContextualMenu | mount | 12360 | 11852 | 1000 | |
| DefaultButton | mount | 754 | 750 | 5000 | |
| DetailsRow | mount | 2246 | 2190 | 5000 | |
| DetailsRowFast | mount | 2235 | 2173 | 5000 | |
| DetailsRowNoStyles | mount | 2000 | 2043 | 5000 | |
| Dialog | mount | 2659 | 2664 | 1000 | |
| DocumentCardTitle | mount | 234 | 225 | 1000 | |
| Dropdown | mount | 2014 | 1965 | 5000 | |
| FocusTrapZone | mount | 1150 | 1150 | 5000 | |
| FocusZone | mount | 1059 | 1085 | 5000 | |
| GroupedList | mount | 42067 | 47083 | 2 | |
| GroupedList | virtual-rerender | 20150 | 20130 | 2 | |
| GroupedList | virtual-rerender-with-unmount | 50807 | 51032 | 2 | |
| GroupedListV2 | mount | 229 | 225 | 2 | |
| GroupedListV2 | virtual-rerender | 204 | 214 | 2 | |
| GroupedListV2 | virtual-rerender-with-unmount | 216 | 229 | 2 | |
| IconButton | mount | 1062 | 1063 | 5000 | |
| Label | mount | 329 | 342 | 5000 | |
| Layer | mount | 2688 | 2740 | 5000 | |
| Link | mount | 386 | 395 | 5000 | |
| MenuButton | mount | 929 | 927 | 5000 | |
| MessageBar | mount | 21417 | 21354 | 5000 | |
| Nav | mount | 1948 | 1926 | 1000 | |
| OverflowSet | mount | 778 | 773 | 5000 | |
| Panel | mount | 1738 | 1854 | 1000 | |
| Persona | mount | 733 | 750 | 1000 | |
| Pivot | mount | 898 | 858 | 1000 | |
| PrimaryButton | mount | 840 | 852 | 5000 | |
| Rating | mount | 4643 | 4642 | 5000 | |
| SearchBox | mount | 921 | 917 | 5000 | |
| Shimmer | mount | 1830 | 1928 | 5000 | |
| Slider | mount | 1320 | 1303 | 5000 | |
| SpinButton | mount | 2918 | 2899 | 5000 | |
| Spinner | mount | 385 | 383 | 5000 | |
| SplitButton | mount | 1792 | 1800 | 5000 | |
| Stack | mount | 405 | 405 | 5000 | |
| StackWithIntrinsicChildren | mount | 846 | 854 | 5000 | |
| StackWithTextChildren | mount | 2565 | 2628 | 5000 | |
| SwatchColorPicker | mount | 6189 | 6099 | 5000 | |
| TagPicker | mount | 1453 | 1468 | 5000 | |
| Text | mount | 367 | 376 | 5000 | |
| TextField | mount | 937 | 946 | 5000 | |
| ThemeProvider | mount | 826 | 827 | 5000 | |
| ThemeProvider | virtual-rerender | 573 | 590 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1258 | 1281 | 5000 | |
| Toggle | mount | 591 | 606 | 5000 | |
| buttonNative | mount | 193 | 190 | 5000 |
This was referenced Mar 18, 2024
Merged
khmakoto
approved these changes
Mar 20, 2024
robertpenner
pushed a commit
to robertpenner/fluentui
that referenced
this pull request
Apr 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
TypeScript 5 introduced some breaking changes to the way that implicit type coercion happens in templates, as well as a few other breaking changes. Although we don't currently use TypeScript 5.3.3 in the repo, experimental work in the
xplatbranch requires building against TypesScript 5+. There are also customers using TypeScript 5+, who are seeing build errors when importing FluentUI.New Behavior
Fix build errors seen if the repo is updated to TypeScript 5.3.3. This is part of a set of PRs intending to fix all build errors when building against TypeScript 5.3.3.
The fixes in this PR are caused by a breaking change in TS 4.8: Unconstrained Generics No Longer Assignable to
{}.extends {}constraint to template types that previously had no constraint (effectivelyextends unknown). The new constraint disallowsnullandundefinedas template parameters, which were never valid values for these type parameters anyways.ℹ️ Note: This is NOT updating the project to use TypeScript 5.3.3, and an update to the TypeScript version is not planned as part of this change. It is only fixing build errors that would occur if it were built against TypeScript 5.3.3.
Related Issue(s)
This PR was split out from a draft PR that contains all of the changes. I'm not going to publish the monolith PR, but in case it helps to see all of the changes in one place:
Here are all of the split-out PRs: