feat(react-tags): adds appearance and dismissible to TagGroupContext#30800
Merged
bsunderhus merged 1 commit intomicrosoft:masterfrom Mar 19, 2024
Conversation
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 627 | 624 | 5000 | |
| Button | mount | 307 | 308 | 5000 | |
| Field | mount | 1140 | 1154 | 5000 | |
| FluentProvider | mount | 717 | 724 | 5000 | |
| FluentProviderWithTheme | mount | 83 | 89 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 73 | 65 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 72 | 74 | 10 | |
| MakeStyles | mount | 864 | 871 | 50000 | |
| Persona | mount | 1737 | 1689 | 5000 | |
| SpinButton | mount | 1351 | 1404 | 5000 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Collaborator
📊 Bundle size report
Unchanged fixtures
|
Collaborator
🕵 fluentuiv9 No visual regressions between this PR and main |
layershifter
approved these changes
Mar 19, 2024
robertpenner
pushed a commit
to robertpenner/fluentui
that referenced
this pull request
Apr 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
New Behavior
appearanceanddismissibletoTagGroupContextas optional properties to ensure no breaking changeRelated Issue(s)