feat(react-swatch-picker): Added ImageSwatch#30769
Merged
ValentinaKozlova merged 7 commits intomicrosoft:masterfrom Mar 18, 2024
Merged
feat(react-swatch-picker): Added ImageSwatch#30769ValentinaKozlova merged 7 commits intomicrosoft:masterfrom
ValentinaKozlova merged 7 commits intomicrosoft:masterfrom
Conversation
Collaborator
📊 Bundle size report🤖 This report was generated against 6a3e6bbbf140f0b87f1fe98a8b27fd813c16aec2 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
marcosmoura
reviewed
Mar 18, 2024
Contributor
marcosmoura
left a comment
There was a problem hiding this comment.
It looks good overall. Just left a few comments here.
...es/react-components/react-swatch-picker-preview/src/components/ImageSwatch/useImageSwatch.ts
Outdated
Show resolved
Hide resolved
packages/react-components/react-swatch-picker-preview/src/index.ts
Outdated
Show resolved
Hide resolved
marcosmoura
approved these changes
Mar 18, 2024
...es/react-components/react-swatch-picker-preview/src/components/ImageSwatch/useImageSwatch.ts
Show resolved
Hide resolved
...ct-components/react-swatch-picker-preview/stories/SwatchPicker/SwatchPickerImage.stories.tsx
Show resolved
Hide resolved
...ct-components/react-swatch-picker-preview/stories/SwatchPicker/SwatchPickerImage.stories.tsx
Show resolved
Hide resolved
...ct-components/react-swatch-picker-preview/stories/SwatchPicker/SwatchPickerImage.stories.tsx
Show resolved
Hide resolved
...ct-components/react-swatch-picker-preview/stories/SwatchPicker/SwatchPickerImage.stories.tsx
Show resolved
Hide resolved
robertpenner
pushed a commit
to robertpenner/fluentui
that referenced
this pull request
Apr 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added ImageSwatch
Note: I haven't renamed
selectedColorprop. It'll be done in the following PR